)]}'
{"src/openvpn/multi.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a4bb23c3d136cfe604250f4d75e14d8009313ee0","unresolved":true,"context_lines":[{"line_number":252,"context_line":" */"},{"line_number":253,"context_line":"int_hash_function(const void *key, uint32_t iv)"},{"line_number":254,"context_line":"{"},{"line_number":255,"context_line":"    return (uint32_t)(uintptr_t)key;"},{"line_number":256,"context_line":"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"static bool"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1f666d5a_d31b9d89","line":255,"updated":"2026-03-12 11:27:48.000000000","message":"Why not remove the uint32_t cast here?","commit_id":"b2dce6b6db2ee8d188384ec2b2b9c1bb32068cb1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"3d745f1c31401f999551b85a9cf2d00a27bc970e","unresolved":false,"context_lines":[{"line_number":252,"context_line":" */"},{"line_number":253,"context_line":"int_hash_function(const void *key, uint32_t iv)"},{"line_number":254,"context_line":"{"},{"line_number":255,"context_line":"    return (uint32_t)(uintptr_t)key;"},{"line_number":256,"context_line":"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"static bool"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"301d83f2_79ac416f","line":255,"in_reply_to":"1f666d5a_d31b9d89","updated":"2026-03-19 13:06:49.000000000","message":"Acknowledged","commit_id":"b2dce6b6db2ee8d188384ec2b2b9c1bb32068cb1"}],"tests/unit_tests/openvpn/test_misc.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"28229b9ba65914fb72b692c87da2725c29c228e3","unresolved":true,"context_lines":[{"line_number":173,"context_line":"     */"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":176,"context_line":"    struct hash *hash \u003d hash_init(10000, (uint32_t)get_random(), word_hash_function, word_compare_function);"},{"line_number":177,"context_line":"    struct hash *nhash \u003d hash_init(256, (uint32_t)get_random(), word_hash_function, word_compare_function);"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    printf(\"hash_init n_buckets\u003d%u mask\u003d0x%08x\\n\", hash-\u003en_buckets, hash-\u003emask);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e9ce02ce_c816e1a1","line":176,"updated":"2026-03-12 11:35:24.000000000","message":"get_random already returns uint32_t, so this is a meaningless cast.","commit_id":"b2dce6b6db2ee8d188384ec2b2b9c1bb32068cb1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0929bb4f8ac2e4ad3687527a9b092725b28259c6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"     */"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":176,"context_line":"    struct hash *hash \u003d hash_init(10000, (uint32_t)get_random(), word_hash_function, word_compare_function);"},{"line_number":177,"context_line":"    struct hash *nhash \u003d hash_init(256, (uint32_t)get_random(), word_hash_function, word_compare_function);"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    printf(\"hash_init n_buckets\u003d%u mask\u003d0x%08x\\n\", hash-\u003en_buckets, hash-\u003emask);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"71b58226_c5cd5e8a","line":176,"in_reply_to":"e9ce02ce_c816e1a1","updated":"2026-03-19 12:58:29.000000000","message":"Done","commit_id":"b2dce6b6db2ee8d188384ec2b2b9c1bb32068cb1"}]}
