)]}'
{"id":"openvpn~1570","triplet_id":"openvpn~master~Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c","project":"openvpn","branch":"master","attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-19 14:17:13.000000000","reason":"Vote got outdated and was removed: Code-Review-1"}},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-19 12:58:29.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}},"hashtags":[],"change_id":"Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c","subject":"Change hash values in our hash map from uint32_t to uint64_t","status":"NEW","created":"2026-03-11 17:48:37.000000000","updated":"2026-03-19 14:17:13.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"057e429f99c42fa31e8a3099eb6db790cf24dc16","_number":1570,"virtual_id_number":1570,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-11 17:48:40.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-12 11:27:48.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"94a59a4de88a6ff4a4b13b69ec065e49e47a046b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-11 17:48:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2ae6157cad208243c9c1381b1f9ae2d984e3dddc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-11 18:51:06.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a4bb23c3d136cfe604250f4d75e14d8009313ee0","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-12 11:27:48.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"28229b9ba65914fb72b692c87da2725c29c228e3","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-12 11:35:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"033ddb3b2a97c6e0cf8fccfcd4a6dd22212e29ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-12 13:04:18.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"0929bb4f8ac2e4ad3687527a9b092725b28259c6","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-19 12:58:29.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3d745f1c31401f999551b85a9cf2d00a27bc970e","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-19 13:06:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"057e429f99c42fa31e8a3099eb6db790cf24dc16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-19 14:17:13.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"ff8593c4b5a461ce21c90b4ca24aad676e582199","revisions":{"6ca464faa294db105579c6190f03a978d3b378bc":{"kind":"REWORK","_number":1,"created":"2026-03-11 17:48:37.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/70/1570/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/1570/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1 \u0026\u0026 git checkout -b change-1570 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29c11fedbb0b7fc3fbaae6beec4c1a779993864c","subject":"Increase default size of internal hash maps to 1024"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-23 10:57:04.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-11 17:27:42.000000000","tz":60},"subject":"Change hash values in our hash map from uint32_t to uint64_t","message":"Change hash values in our hash map from uint32_t to uint64_t\n\n32 bit architectures are playing a very small role today, so the difference\nbetween 64 bit and 32 bit hash values is not expected to be large anymore.\n\nThis is also in preparation to replace our hash function with a more modern\nreplacement.\n\nChange-Id: Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b2dce6b6db2ee8d188384ec2b2b9c1bb32068cb1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-11 18:51:06.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/70/1570/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/1570/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2 \u0026\u0026 git checkout -b change-1570 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0719fb4fc6e4c5a50a29037b9ad9aa9a7fb88241","subject":"Increase default size of internal hash maps to 1024"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-23 10:57:04.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-11 18:15:07.000000000","tz":60},"subject":"Change hash values in our hash map from uint32_t to uint64_t","message":"Change hash values in our hash map from uint32_t to uint64_t\n\n32 bit architectures are playing a very small role today, so the difference\nbetween 64 bit and 32 bit hash values is not expected to be large anymore.\n\nThis is also in preparation to replace our hash function with a more modern\nreplacement.\n\nChange-Id: Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"dfdcdde3608810edac880e8a58f654ea9646cc8e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-03-12 13:04:18.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/70/1570/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/1570/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3 \u0026\u0026 git checkout -b change-1570 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5cb0e94b5e2ca3a2cff01e8fb7214956f816885f","subject":"Increase default size of internal hash maps to 4 * --max-clients"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-23 10:57:04.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-12 12:59:24.000000000","tz":60},"subject":"Change hash values in our hash map from uint32_t to uint64_t","message":"Change hash values in our hash map from uint32_t to uint64_t\n\n32 bit architectures are playing a very small role today, so the difference\nbetween 64 bit and 32 bit hash values is not expected to be large anymore.\n\nThis is also in preparation to replace our hash function with a more modern\nreplacement.\n\nChange-Id: Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"ff8593c4b5a461ce21c90b4ca24aad676e582199":{"kind":"REWORK","_number":4,"created":"2026-03-19 14:17:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/70/1570/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/1570/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4 \u0026\u0026 git checkout -b change-1570 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/1570/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"528a321da78836bfa3c4dd0d4527fa7ec92234b7","subject":"Optimise iterating over all clients by remembering highest peer id"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-23 10:57:04.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-19 14:13:11.000000000","tz":60},"subject":"Change hash values in our hash map from uint32_t to uint64_t","message":"Change hash values in our hash map from uint32_t to uint64_t\n\n32 bit architectures are playing a very small role today, so the difference\nbetween 64 bit and 32 bit hash values is not expected to be large anymore.\n\nThis is also in preparation to replace our hash function with a more modern\nreplacement.\n\nChange-Id: Ib8140107f98164d2a2e1768a6d8ac65016cd7f7c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}