)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0ce5f17ca9723da7ad7dd80924039b8ec7436dda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c4a5a366_3e35e2f8","updated":"2026-07-22 10:32:27.000000000","message":"Added headers since the cleanup of headers in previous now requires additional headers in aws-lc part.","commit_id":"9d0ee07b20b50dc7d63643cd521f4ddb0a8005df"}],"src/openvpn/siphash.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"48f20d3b831aff5a5e4aedc0b65aafdd6ed17761","unresolved":true,"context_lines":[{"line_number":40,"context_line":"#include \"error.h\""},{"line_number":41,"context_line":"/**"},{"line_number":42,"context_line":" *  Computes a SipHash value"},{"line_number":43,"context_line":" * @param   in: pointer to input data (read-only)"},{"line_number":44,"context_line":" * @param   inlen: input data length in bytes (any size_t value)"},{"line_number":45,"context_line":" * @param   k: pointer to the key data (read-only), must be 16 bytes"},{"line_number":46,"context_line":" * @param   out: pointer to output data (write-only), outlen bytes must be allocated"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"50f1bd52_999eb12f","line":43,"updated":"2026-07-30 10:26:54.000000000","message":"I don\u0027t think the \":\" makes sense in doxygen","commit_id":"f225b8088e3f1528e265249674dda2449e83ad3e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5f21d441013ff5df75ff49b149662d3bb90424b0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#include \"error.h\""},{"line_number":41,"context_line":"/**"},{"line_number":42,"context_line":" *  Computes a SipHash value"},{"line_number":43,"context_line":" * @param   in: pointer to input data (read-only)"},{"line_number":44,"context_line":" * @param   inlen: input data length in bytes (any size_t value)"},{"line_number":45,"context_line":" * @param   k: pointer to the key data (read-only), must be 16 bytes"},{"line_number":46,"context_line":" * @param   out: pointer to output data (write-only), outlen bytes must be allocated"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"269bfc1b_1414f2fd","line":43,"in_reply_to":"50f1bd52_999eb12f","updated":"2026-07-30 11:39:14.000000000","message":"Acknowledged","commit_id":"f225b8088e3f1528e265249674dda2449e83ad3e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"48f20d3b831aff5a5e4aedc0b65aafdd6ed17761","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    uint64_t sipout \u003d SIPHASH_24(k, in, inlen);"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    memcpy(out, \u0026sipout, sizeof(uint64_t));"},{"line_number":57,"context_line":"    return 0;"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":"#endif"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":21,"id":"a725d900_e6ee51cd","line":57,"updated":"2026-07-30 10:26:54.000000000","message":"Can we please have a documentation for the return value. Also above in siphash_reference.","commit_id":"f225b8088e3f1528e265249674dda2449e83ad3e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5f21d441013ff5df75ff49b149662d3bb90424b0","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    uint64_t sipout \u003d SIPHASH_24(k, in, inlen);"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    memcpy(out, \u0026sipout, sizeof(uint64_t));"},{"line_number":57,"context_line":"    return 0;"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":"#endif"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":21,"id":"fc523b81_b0ba030d","line":57,"in_reply_to":"a725d900_e6ee51cd","updated":"2026-07-30 11:39:14.000000000","message":"I removed the return type as we no longer use OpenSSL and the other two implementation cannot fail and need no return type.","commit_id":"f225b8088e3f1528e265249674dda2449e83ad3e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b6e44cbd776eb7e213e327675ca1bb50d6f13af2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    uint64_t sipout \u003d SIPHASH_24(k, in, inlen);"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    memcpy(out, \u0026sipout, sizeof(uint64_t));"},{"line_number":57,"context_line":"    return 0;"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":"#endif"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":21,"id":"840e5c22_91b66536","line":57,"in_reply_to":"fc523b81_b0ba030d","updated":"2026-07-30 18:27:42.000000000","message":"Done","commit_id":"f225b8088e3f1528e265249674dda2449e83ad3e"}]}