)]}'
{"id":"openvpn~1581","triplet_id":"openvpn~master~I350ca5b08379ede1480b81055d35dd9a33e30cff","project":"openvpn","branch":"master","topic":"buffer","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-10 12:02:29.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-10 12:33:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I350ca5b08379ede1480b81055d35dd9a33e30cff","subject":"doc: add Doxygen documentation to buffer.h","status":"MERGED","created":"2026-03-18 13:53:56.000000000","updated":"2026-08-10 12:33:56.000000000","submitted":"2026-08-10 12:33:56.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1581-buffer","meta_rev_id":"fffc4ecf77c6157d3d07c1017cce993771c93c88","_number":1581,"virtual_id_number":1581,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-18 13:53:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-18 13:53:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"74b093762d46c4353cd863190f56993a38b96878","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-18 13:53:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c85c22609e0e804ecd5bebe5549c70fc2e36f86d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-07 12:14:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"62a40bec6e0d3e5acec5c16e9e294a35ccad2ba5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-07 13:05:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ef0f9ec5356d248cb45cae1a1d655be8a87fc999","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-07 15:48:02.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"2f3adcfd2904c94890968da6153ba583a92366de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-10 11:46:32.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"25de1aced890f57a4b82763f35d58b28d6b2e222","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-10 12:02:29.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"fffc4ecf77c6157d3d07c1017cce993771c93c88","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-10 12:33:56.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"21ef7fa82a39895a7b65459078fd78bdd3a43e27","revisions":{"ee2306bf27ce4561612f175e17d9b38d7a1e4e11":{"kind":"REWORK","_number":1,"created":"2026-03-18 13:53:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/81/1581/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1581/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1 \u0026\u0026 git checkout -b change-1581 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4ba117ec02c86f55c95fe13a3ff667bfba77e093","subject":"test_buffer: Add test for buf_null_terminate"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-17 18:09:39.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-18 13:50:37.000000000","tz":60},"subject":"doc: add Doxygen documentation to buffer.h","message":"doc: add Doxygen documentation to buffer.h\n\nDocument all previously undocumented elements.\n\nGithub: Fixes #864\nChange-Id: I350ca5b08379ede1480b81055d35dd9a33e30cff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5d7e824367219788ad9547e865123dfa2cba76a9":{"kind":"REWORK","_number":2,"created":"2026-08-07 12:14:03.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/81/1581/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1581/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2 \u0026\u0026 git checkout -b change-1581 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64bcf0ad06bbab1f862c749cb3b9947162f67291","subject":"Remove --with-mem-check\u003ddmalloc"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-17 18:09:39.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-07 12:13:13.000000000","tz":120},"subject":"doc: add Doxygen documentation to buffer.h","message":"doc: add Doxygen documentation to buffer.h\n\nDocument all previously undocumented elements.\n\nGithub: Fixes #864\nChange-Id: I350ca5b08379ede1480b81055d35dd9a33e30cff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"dae71a5a2922c4289364250840dd08d5b9d2b086":{"kind":"REWORK","_number":3,"created":"2026-08-07 13:05:33.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/81/1581/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1581/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3 \u0026\u0026 git checkout -b change-1581 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64bcf0ad06bbab1f862c749cb3b9947162f67291","subject":"Remove --with-mem-check\u003ddmalloc"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-17 18:09:39.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-07 13:05:21.000000000","tz":120},"subject":"doc: add Doxygen documentation to buffer.h","message":"doc: add Doxygen documentation to buffer.h\n\nDocument all previously undocumented elements.\n\nGithub: Fixes #864\nChange-Id: I350ca5b08379ede1480b81055d35dd9a33e30cff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3f9752c66048ef840eaa0641294544606994e16c":{"kind":"REWORK","_number":4,"created":"2026-08-10 11:46:32.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/81/1581/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1581/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4 \u0026\u0026 git checkout -b change-1581 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d42a9912c1d62006323a12af86baa148c77592e9","subject":"Add check that username is identical to multi float"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-17 18:09:39.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-10 11:45:48.000000000","tz":120},"subject":"doc: add Doxygen documentation to buffer.h","message":"doc: add Doxygen documentation to buffer.h\n\nDocument all previously undocumented elements.\n\nGithub: Fixes #864\nChange-Id: I350ca5b08379ede1480b81055d35dd9a33e30cff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"21ef7fa82a39895a7b65459078fd78bdd3a43e27":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-08-10 12:33:56.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/1581/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1581/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5 \u0026\u0026 git checkout -b change-1581 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/1581/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"603aa9698c140d15b7464af8fb83bd2aa71da680","subject":"Reenable xmit_hold when using p2p tcp-server and tls-server"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-10 12:09:35.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-10 12:29:13.000000000","tz":120},"subject":"doc: add Doxygen documentation to buffer.h","message":"doc: add Doxygen documentation to buffer.h\n\nDocument all previously undocumented elements.\n\nGithub: Fixes #864\nChange-Id: I350ca5b08379ede1480b81055d35dd9a33e30cff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1581\nMessage-Id: \u003c20260810120941.31423-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38269.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}