)]}'
{"id":"openvpn~1582","triplet_id":"openvpn~master~I4920318ac537064508eee3ca449d48de76c2ea5d","project":"openvpn","branch":"master","topic":"buffer","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-24 17:51:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-09 08:34:06.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I4920318ac537064508eee3ca449d48de76c2ea5d","subject":"Remove --with-mem-check\u003ddmalloc","status":"MERGED","created":"2026-03-18 13:53:56.000000000","updated":"2026-08-09 08:34:06.000000000","submitted":"2026-08-09 08:34:06.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1582-buffer","meta_rev_id":"86ba9a4f869dcb27ea8c661d252688e92e41ad11","_number":1582,"virtual_id_number":1582,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-18 13:53:58.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-18 13:53:58.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c22c38efe9384c4ebc1ef4e96f998e3b86b8db3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-18 13:53:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"52c4c52e234625b9f0b5f5a8a17ebed5525e747a","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-24 17:51:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1da2bf9bd742001515337346bab029fe758a10a8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-07 12:14:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dae1eeb2740c591fe5c65d5af61fc467ef94bd39","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-08-07 12:52:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e52605d4d0c4244a911aa2e0eccb2235ced22b36","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-07 13:15:50.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"86ba9a4f869dcb27ea8c661d252688e92e41ad11","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-09 08:34:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1219685ad8eda403d1b9afcf630f3c8b09f2c347","revisions":{"b7b768c1787d2f6b7193e3a73c525a592c63d8c0":{"kind":"REWORK","_number":1,"created":"2026-03-18 13:53:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/82/1582/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1582/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1 \u0026\u0026 git checkout -b change-1582 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee2306bf27ce4561612f175e17d9b38d7a1e4e11","subject":"doc: add Doxygen documentation to buffer.h"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-18 13:52:40.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-18 13:52:40.000000000","tz":60},"subject":"Fix compilation with --with-mem-check\u003ddmalloc","message":"Fix compilation with --with-mem-check\u003ddmalloc\n\nOnly tested compilation and make check. Did not\nactually verify dmalloc functionality.\n\nChange-Id: I4920318ac537064508eee3ca449d48de76c2ea5d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"64bcf0ad06bbab1f862c749cb3b9947162f67291":{"kind":"REWORK","_number":2,"created":"2026-08-07 12:14:03.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/82/1582/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1582/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2 \u0026\u0026 git checkout -b change-1582 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d1106970f76e955b0a5fa19b566e97bba98d4c9b","subject":"Change hash iv to a be a fixed sized array"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-18 13:52:40.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-07 12:12:33.000000000","tz":120},"subject":"Remove --with-mem-check\u003ddmalloc","message":"Remove --with-mem-check\u003ddmalloc\n\nThis code hasn\u0027t compiled for years and noone complained.\nWe generally use ASAN instead.\n\nSo remove the dead code.\n\nv2: The first version of this change tried to fix the\n    code. v2 instead removes it.\n\nChange-Id: I4920318ac537064508eee3ca449d48de76c2ea5d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1219685ad8eda403d1b9afcf630f3c8b09f2c347":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-08-09 08:34:06.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/82/1582/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1582/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3 \u0026\u0026 git checkout -b change-1582 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/82/1582/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06ced3fd84e4e28f2774c4156f8032a2bed736a2","subject":"Allow extracing other integers from peer info and add a unit test for it"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-07 13:15:39.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-09 08:32:15.000000000","tz":120},"subject":"Remove --with-mem-check\u003ddmalloc","message":"Remove --with-mem-check\u003ddmalloc\n\nThis code hasn\u0027t compiled for years and noone complained.\nWe generally use ASAN instead.\n\nSo remove the dead code.\n\nv2: The first version of this change tried to fix the\n    code. v2 instead removes it.\n\nChange-Id: I4920318ac537064508eee3ca449d48de76c2ea5d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1582\nMessage-Id: \u003c20260807131539.53877-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38208.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}