)]}'
{"id":"openvpn~1583","triplet_id":"openvpn~master~I8ca07e2bbb5de229204191d61e90f084a58969af","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-27 17:50:02.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-23 12:48:24.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"I8ca07e2bbb5de229204191d61e90f084a58969af","subject":"Change type of option flag from unsigned int to uint64_t","status":"MERGED","created":"2026-03-20 13:53:44.000000000","updated":"2026-03-27 17:50:02.000000000","submitted":"2026-03-27 17:50:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1583","meta_rev_id":"6f6d36c76a263094eb0b1d8d23fc2105c12bbf80","_number":1583,"virtual_id_number":1583,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-20 13:53:45.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-23 11:53:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"96dd8d5594a6294363161bbf9338e53dd5609acc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-20 13:53:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e495a8a7c97362c4fd57cfd3377d4325ebd83d5","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-23 11:53:23.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"20f285df5330c10610176b24332ed992a3926a79","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-23 12:14:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6d27417a1d08ea57235646d633cf03683666d6f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-23 12:16:13.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6f15da0dc2166d9f9765f9646d1994d09951d6f8","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-23 12:48:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"79e29f1b514bfbad19528222088770368d4f10bb","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-25 12:43:55.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"6f6d36c76a263094eb0b1d8d23fc2105c12bbf80","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-27 17:50:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"91fd9614f980b02772e4dfbb09144c822ec97df0","revisions":{"df61f669d357b5b855a6feba412a407074e9bfb9":{"kind":"REWORK","_number":1,"created":"2026-03-20 13:53:44.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/83/1583/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/83/1583/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1 \u0026\u0026 git checkout -b change-1583 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a04a3cedd41a3b552e56d19dafc7042b95dd527d","subject":"ssl_mbedtls: Avoid conversion and sign-compare warnings"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-20 13:35:48.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-20 13:53:36.000000000","tz":60},"subject":"Change type of option flag from unsigned int to uint64_t","message":"Change type of option flag from unsigned int to uint64_t\n\nWe currently use all 32 bits of the unsigned int for option classes.\nWhile we can probably can retire 2-3 of the existing options, at some\npoint we will hit the limit again.\n\nInstead of fully rewriting this logic to use a different approach or\nstructure, changing the type from unsigned int to uint64_t seem to be\na lot less intrusive approach.\n\nChange-Id: I8ca07e2bbb5de229204191d61e90f084a58969af\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"c09c9108cce5439ed978c18da9c7e9155b15448d":{"kind":"REWORK","_number":2,"created":"2026-03-23 12:16:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/83/1583/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/83/1583/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2 \u0026\u0026 git checkout -b change-1583 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee2af6655d1dae8b87d8128e2afeec4f5506d79b","subject":"Use openssl_err_t typedef to deal with difference between TLS libraries"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-20 13:35:48.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-23 12:16:07.000000000","tz":60},"subject":"Change type of option flag from unsigned int to uint64_t","message":"Change type of option flag from unsigned int to uint64_t\n\nWe currently use all 32 bits of the unsigned int for option classes.\nWhile we can probably can retire 2-3 of the existing options, at some\npoint we will hit the limit again.\n\nInstead of fully rewriting this logic to use a different approach or\nstructure, changing the type from unsigned int to uint64_t seem to be\na lot less intrusive approach.\n\nChange-Id: I8ca07e2bbb5de229204191d61e90f084a58969af\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"91fd9614f980b02772e4dfbb09144c822ec97df0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-03-27 17:50:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/83/1583/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/83/1583/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3 \u0026\u0026 git checkout -b change-1583 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/83/1583/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5933af1620a93bb06b8c48b6f1f0eb23ed13cbf9","subject":"auth_token: Clean up type handling in verify_auth_token and its UT"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-03-25 12:43:38.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-27 17:46:29.000000000","tz":60},"subject":"Change type of option flag from unsigned int to uint64_t","message":"Change type of option flag from unsigned int to uint64_t\n\nWe currently use all 32 bits of the unsigned int for option classes.\nWhile we can probably can retire 2-3 of the existing options, at some\npoint we will hit the limit again.\n\nInstead of fully rewriting this logic to use a different approach or\nstructure, changing the type from unsigned int to uint64_t seem to be\na lot less intrusive approach.\n\nChange-Id: I8ca07e2bbb5de229204191d61e90f084a58969af\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1583\nMessage-Id: \u003c20260325124338.123477-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36266.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}