)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"f57ccc24cd825a5ade8444fb6f1a307bbfe4c749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f4b8f78_ee440df3","updated":"2026-03-25 13:06:31.000000000","message":"LGTM","commit_id":"3308ed7e43bef200c93ca1d5db947e5c6f708854"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"0143552fe7f795f33762418a80dc98b8bf484b4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9cf89c92_fcb3dcf6","updated":"2026-08-22 16:07:01.000000000","message":"Razvan\u0027s finding need to be addressed","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"}],"tests/t_net.sh":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5eff0fc5fb2436b34dd52e43d65f3a53618c6875","unresolved":true,"context_lines":[{"line_number":27,"context_line":"{"},{"line_number":28,"context_line":"    $RUN_SUDO $IP_EXEC ip link del $IFACE || true"},{"line_number":29,"context_line":"    $RUN_SUDO $IP_EXEC ip link add $IFACE address 00:11:22:33:44:55 type dummy"},{"line_number":30,"context_line":"    $RUN_SUDO $IP_EXEC ip link set dev $IFACE state up"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":33,"context_line":"        echo \"can\u0027t create interface $IFACE $IP_NETNS\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"96fc37e2_1e4267d8","line":30,"updated":"2026-08-18 11:17:03.000000000","message":"`$IP_EXEC` is already defined as calling `$RUN_SUDO`, so the `$RUN_SUDO` on these 3 line now appears to be superfluous.","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5eff0fc5fb2436b34dd52e43d65f3a53618c6875","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    $RUN_SUDO $IP_EXEC ip link add $IFACE address 00:11:22:33:44:55 type dummy"},{"line_number":30,"context_line":"    $RUN_SUDO $IP_EXEC ip link set dev $IFACE state up"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":33,"context_line":"        echo \"can\u0027t create interface $IFACE $IP_NETNS\""},{"line_number":34,"context_line":"        exit 1"},{"line_number":35,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"2c48207f_99e26859","line":32,"updated":"2026-08-18 11:17:03.000000000","message":"Doesn\u0027t `set -e` exit before this can even be reached?","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5eff0fc5fb2436b34dd52e43d65f3a53618c6875","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    $RUN_SUDO $IP_EXEC ip link set dev $IFACE state up"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":33,"context_line":"        echo \"can\u0027t create interface $IFACE $IP_NETNS\""},{"line_number":34,"context_line":"        exit 1"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"072ad77b_f1c9c60c","line":33,"updated":"2026-08-18 11:17:03.000000000","message":"I can\u0027t find `IP_NETNS` as defined anywhere.","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"}],"tests/unit_tests/openvpn/test_networking.c":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5eff0fc5fb2436b34dd52e43d65f3a53618c6875","unresolved":true,"context_lines":[{"line_number":213,"context_line":"static void"},{"line_number":214,"context_line":"usage(char *name)"},{"line_number":215,"context_line":"{"},{"line_number":216,"context_line":"    printf(\"Usage: %s \u003c0-8\u003e\\n\", name);"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"int"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"6a9933b2_a59067f2","line":216,"updated":"2026-08-18 11:17:03.000000000","message":"Should `usage()` be changed as well now?","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"5eff0fc5fb2436b34dd52e43d65f3a53618c6875","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        ctx \u003d malloc(sizeof(*ctx));"},{"line_number":244,"context_line":"        CLEAR(*ctx);"},{"line_number":245,"context_line":"        ctx-\u003enetns \u003d argv[3];"},{"line_number":246,"context_line":"        ctx-\u003egc \u003d gc_new();"},{"line_number":247,"context_line":"    }"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    test \u003d atoi(argv[1]);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d2ab3f93_912c2297","line":246,"updated":"2026-08-18 11:17:03.000000000","message":"Maybe acceptable because this is just a test, but we never check that `ctx` it not `NULL`.\n\nThere\u0027s also no corresponding `free()` for it.","commit_id":"103f2bd05530c0ed4e3670018c3dbe4a6dc02d59"}]}