)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8270503395f6523d513b2956daa33cc825c31afc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"of accessing the internal, we have to use a method now to check these"},{"line_number":11,"context_line":"attributes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The bit counting in ANS.1 and of this method is a bit strange and"},{"line_number":14,"context_line":"it will count bits from the left instead of the right, so the previous"},{"line_number":15,"context_line":"mask of 0x80 for clients is now 0 and 0x40 for server is now 1."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a6196a88_86a2feb6","line":13,"updated":"2026-04-01 10:24:45.000000000","message":"ASN","commit_id":"574cd86d570b0e9b7fce99cbe1a63111b1059147"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"99b7d509046dd2e0a14dda1ffcfa13b2b27adbc2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of accessing the internal, we have to use a method now to check these"},{"line_number":11,"context_line":"attributes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The bit counting in ANS.1 and of this method is a bit strange and"},{"line_number":14,"context_line":"it will count bits from the left instead of the right, so the previous"},{"line_number":15,"context_line":"mask of 0x80 for clients is now 0 and 0x40 for server is now 1."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d59c8f6b_50a3406d","line":13,"in_reply_to":"a6196a88_86a2feb6","updated":"2026-04-02 12:13:14.000000000","message":"Done","commit_id":"574cd86d570b0e9b7fce99cbe1a63111b1059147"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2a32a9bfd6753ccf3094a030fcb2bc195f91de25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ad0744ed_4fcb825f","updated":"2026-04-02 11:47:09.000000000","message":"There is still the typo in the commit message","commit_id":"ecaeee1704c720b00df741075456195aa0006bd0"}],"src/openvpn/ssl_verify_openssl.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8270503395f6523d513b2956daa33cc825c31afc","unresolved":true,"context_lines":[{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * old versions of OpenSSL allow us to make the less strict check we used to"},{"line_number":620,"context_line":"         * do. If this less strict check pass, warn user that this might not be the"},{"line_number":621,"context_line":"         * case when its distribution will update to OpenSSL 1.1"},{"line_number":622,"context_line":"         */"},{"line_number":623,"context_line":"        if (result \u003d\u003d FAILURE)"},{"line_number":624,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8acc94f5_568890ee","line":621,"updated":"2026-04-01 10:24:45.000000000","message":"This comments seems very obsolete? Apparently even newest OpenSSL allows us to make this check? The actual warning is probably fine since it just says \"future\", but the comment could clearly use some update?","commit_id":"574cd86d570b0e9b7fce99cbe1a63111b1059147"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"971ef042b12340700ae5d7956fd57fdaea4128aa","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * old versions of OpenSSL allow us to make the less strict check we used to"},{"line_number":620,"context_line":"         * do. If this less strict check pass, warn user that this might not be the"},{"line_number":621,"context_line":"         * case when its distribution will update to OpenSSL 1.1"},{"line_number":622,"context_line":"         */"},{"line_number":623,"context_line":"        if (result \u003d\u003d FAILURE)"},{"line_number":624,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fd8dcdf5_7e06cd35","line":621,"in_reply_to":"8acc94f5_568890ee","updated":"2026-04-01 11:28:27.000000000","message":"Will clarify","commit_id":"574cd86d570b0e9b7fce99cbe1a63111b1059147"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9468288ce4031926acc7dbfad47ce31d430afb8b","unresolved":true,"context_lines":[{"line_number":616,"context_line":"            X509_check_purpose(peer_cert, X509_PURPOSE_SSL_CLIENT, 0) ? SUCCESS : FAILURE;"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."}],"source_content_type":"text/x-csrc","patch_set":4,"id":"261d53a9_1d432fb9","line":619,"updated":"2026-04-01 15:32:48.000000000","message":"This line of the comment appears to describe the check above?","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"b5336ead022e89ffdf533a4a4bdb6c8c833f4870","unresolved":false,"context_lines":[{"line_number":616,"context_line":"            X509_check_purpose(peer_cert, X509_PURPOSE_SSL_CLIENT, 0) ? SUCCESS : FAILURE;"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9c1d6b68_eba94285","line":619,"in_reply_to":"261d53a9_1d432fb9","updated":"2026-04-02 10:56:52.000000000","message":"Acknowledged","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9468288ce4031926acc7dbfad47ce31d430afb8b","unresolved":true,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."},{"line_number":623,"context_line":"         */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"de76a3de_26cc4a05","line":620,"updated":"2026-04-01 15:32:48.000000000","message":"general","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"b5336ead022e89ffdf533a4a4bdb6c8c833f4870","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."},{"line_number":623,"context_line":"         */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"da852456_6bac570a","line":620,"in_reply_to":"de76a3de_26cc4a05","updated":"2026-04-02 10:56:52.000000000","message":"Acknowledged","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9468288ce4031926acc7dbfad47ce31d430afb8b","unresolved":true,"context_lines":[{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."},{"line_number":623,"context_line":"         */"},{"line_number":624,"context_line":"        if (result \u003d\u003d FAILURE)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"88061c4b_a2679e31","line":621,"updated":"2026-04-01 15:32:48.000000000","message":"libraries","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"b5336ead022e89ffdf533a4a4bdb6c8c833f4870","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        /*"},{"line_number":619,"context_line":"         * Note that we do not check for netscape certificate type here but rather"},{"line_number":620,"context_line":"         * check for a gneral SSL/TLS client purpose. We do not know how long nscert"},{"line_number":621,"context_line":"         * attributes are accepted by TLS library in the future. Currently OpenSSL 4.0"},{"line_number":622,"context_line":"         * and aws-lc 1.9.0 still consider nscert client as acceptable."},{"line_number":623,"context_line":"         */"},{"line_number":624,"context_line":"        if (result \u003d\u003d FAILURE)"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a5d1f69a_f10bf290","line":621,"in_reply_to":"88061c4b_a2679e31","updated":"2026-04-02 10:56:52.000000000","message":"Acknowledged","commit_id":"01a5e3908b0c8fe44105c7ab866c2eb729a35604"}]}
