)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"dd1db31a5d8b1bc0706f87124db475a59baea23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de7cd1ed_fa5d8453","updated":"2026-04-04 16:13:14.000000000","message":"This still fails -Werror builds on FreeBSD 13 with \"OpenSSL 1.1.1w-freebsd  11 Sep 2023\".\n\nNot sure how to proceed...?  It works without -Werror, so for \"people can still use 2.7/master on FreeBSD 13 or earlier\" that is good enough...","commit_id":"ace2dca3a0130a618a7be73e2a428a93d506d659"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ae4db6488074ff6d6497a646860ab66592ce023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3903b1f0_95c51a32","in_reply_to":"de7cd1ed_fa5d8453","updated":"2026-04-04 20:05:12.000000000","message":"Rebase \"fixed\" that since it was caused by an earlier version of a patch still in the branch.","commit_id":"ace2dca3a0130a618a7be73e2a428a93d506d659"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d84f22eaae1998f864d529221e9f3c7ea7ec21d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fd096d5c_929b24ad","updated":"2026-04-04 20:10:32.000000000","message":"all green!","commit_id":"47fabd18686601c30676c3d2c57c953a4db93fa8"}],"src/openvpn/ssl_verify_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2beb65171e2877f65324341967abd0ce5dc223c0","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    unsigned char *buf \u003d malloc(len_serial);"},{"line_number":318,"context_line":"    BN_bn2binpad(bn_serial, buf, len_serial);"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    char *ret \u003d format_hex_ex(buf, len_serial, 0, 1, \":\", gc);"},{"line_number":321,"context_line":"    free(buf);"},{"line_number":322,"context_line":"    BN_free(bn_serial);"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f70e7e3e_124725d2","line":320,"updated":"2026-04-01 10:41:52.000000000","message":"So why can\u0027t we use `BN_bn2hex` here?","commit_id":"d54085e91b6f7bd777bde65776efb2f59869a84b"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"29166cbd1c6d228805969a39730fe4ac8b3aa6ce","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    unsigned char *buf \u003d malloc(len_serial);"},{"line_number":318,"context_line":"    BN_bn2binpad(bn_serial, buf, len_serial);"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    char *ret \u003d format_hex_ex(buf, len_serial, 0, 1, \":\", gc);"},{"line_number":321,"context_line":"    free(buf);"},{"line_number":322,"context_line":"    BN_free(bn_serial);"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"c7682b24_7bdda5a6","line":320,"in_reply_to":"07c2a8e3_08873e9b","updated":"2026-04-01 11:54:53.000000000","message":"For reference the change with BN_bn2hex:\n\n/** Wrapper around OpenSSL_free\n *\n * Passing OPENSSL_free to gc_add_special does not work\n * since OPENSSL_free is a macro, so use this small wrapper\n * to allow passing this function instead */\nstatic void\nopensl_free_wrapper(void *arg)\n{\n    OPENSSL_free(arg);\n}\n\n\nchar *\nbackend_x509_get_serial_hex(openvpn_x509_cert_t *cert, struct gc_arena *gc)\n{\n    const ASN1_INTEGER *asn1_i \u003d X509_get_serialNumber(cert);\n    BIGNUM *bn_serial \u003d ASN1_INTEGER_to_BN(asn1_i, NULL);\n    char *ret \u003d BN_bn2hex(bn_serial);\n\n    gc_addspecial(ret, opensl_free_wrapper, gc);\n    BN_free(bn_serial);\n\n    return ret;\n}","commit_id":"d54085e91b6f7bd777bde65776efb2f59869a84b"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"da1ddbc453296bea663dc503fe7e0c436a856671","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    unsigned char *buf \u003d malloc(len_serial);"},{"line_number":318,"context_line":"    BN_bn2binpad(bn_serial, buf, len_serial);"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    char *ret \u003d format_hex_ex(buf, len_serial, 0, 1, \":\", gc);"},{"line_number":321,"context_line":"    free(buf);"},{"line_number":322,"context_line":"    BN_free(bn_serial);"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ff897ba8_973ab117","line":320,"in_reply_to":"c7682b24_7bdda5a6","updated":"2026-04-01 12:29:03.000000000","message":"Acknowledged","commit_id":"d54085e91b6f7bd777bde65776efb2f59869a84b"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ccc9103488a4a25d215b337107e9ca5c37efb466","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    unsigned char *buf \u003d malloc(len_serial);"},{"line_number":318,"context_line":"    BN_bn2binpad(bn_serial, buf, len_serial);"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    char *ret \u003d format_hex_ex(buf, len_serial, 0, 1, \":\", gc);"},{"line_number":321,"context_line":"    free(buf);"},{"line_number":322,"context_line":"    BN_free(bn_serial);"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"07c2a8e3_08873e9b","line":320,"in_reply_to":"f70e7e3e_124725d2","updated":"2026-04-01 11:53:54.000000000","message":"I changed this to use BN_bn2hex only to find out that then test fails since we have : in the output and BN_bn2hex does not.\n\n[  ERROR   ] --- \"826BDDCCBDE55EB708F12D68003C24DE\" !\u003d \"82:6b:dd:cc:bd:e5:5e:b7:08:f1:2d:68:00:3c:24:de\"","commit_id":"d54085e91b6f7bd777bde65776efb2f59869a84b"}]}