)]}'
{".gitignore":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8c253f5c0aafb393a25fe85609e60657ee28beb7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"*.[oa]"},{"line_number":2,"context_line":"*.l[oa]"},{"line_number":3,"context_line":"*.gcda"},{"line_number":4,"context_line":"*.gcno"},{"line_number":5,"context_line":"*.dll"},{"line_number":6,"context_line":"*.exe"},{"line_number":7,"context_line":"*.exe.*"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"affae7e7_184d6289","line":4,"updated":"2026-08-24 14:38:02.000000000","message":"Should we also include `*.gcov`, `*-coverage.info` and `*-coverage/`?","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"},{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"cef86e99ab3c79cd0b5c108657c5f65eab6bf55d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"*.[oa]"},{"line_number":2,"context_line":"*.l[oa]"},{"line_number":3,"context_line":"*.gcda"},{"line_number":4,"context_line":"*.gcno"},{"line_number":5,"context_line":"*.dll"},{"line_number":6,"context_line":"*.exe"},{"line_number":7,"context_line":"*.exe.*"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7fc2af62_d3708a80","line":4,"in_reply_to":"4eee09ac_cb606273","updated":"2026-08-24 15:18:41.000000000","message":"You\u0027re right. I asked because I saw it\u0027s being deleted in the `code-coverage-clean` target in the .m4 file.","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c06e53157275078e29340510a0ae0e5b6ee9d4ed","unresolved":true,"context_lines":[{"line_number":1,"context_line":"*.[oa]"},{"line_number":2,"context_line":"*.l[oa]"},{"line_number":3,"context_line":"*.gcda"},{"line_number":4,"context_line":"*.gcno"},{"line_number":5,"context_line":"*.dll"},{"line_number":6,"context_line":"*.exe"},{"line_number":7,"context_line":"*.exe.*"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"4eee09ac_cb606273","line":4,"in_reply_to":"affae7e7_184d6289","updated":"2026-08-24 15:06:08.000000000","message":"Why *.gcov? We do not seem to generate any such files?","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8c253f5c0aafb393a25fe85609e60657ee28beb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e6d5744a_b76b5d20","updated":"2026-08-24 14:38:02.000000000","message":"Is src/compat not instrumented intentionally? I _think_ it would need `AM_CFLAGS \u003d $(CODE_COVERAGE_CFLAGS)` in its Makefile.am as well if we want to cover it.","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"}],"configure.ac":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8c253f5c0aafb393a25fe85609e60657ee28beb7","unresolved":true,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"# If coverage is enabled remove -O arguments from CFLAGS"},{"line_number":1242,"context_line":"if test \"$enable_code_coverage\" \u003d \"yes\"; then"},{"line_number":1243,"context_line":"   [CFLAGS\u003d\"`echo $CFLAGS | $SED -e \u0027s/-O[s0-9]\\\\?//g\u0027`\"]"},{"line_number":1244,"context_line":"fi"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"if test \"${enable_pedantic}\" \u003d \"yes\"; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"902ed96b_05a168d1","line":1243,"updated":"2026-08-24 14:38:02.000000000","message":"This actually only matches numerical optimization levels (like `O3`, etc.), but GCC accepts other things, like `-Og` or `-Ofast`, which would mangle `CFLAGS` after this: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c06e53157275078e29340510a0ae0e5b6ee9d4ed","unresolved":false,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"# If coverage is enabled remove -O arguments from CFLAGS"},{"line_number":1242,"context_line":"if test \"$enable_code_coverage\" \u003d \"yes\"; then"},{"line_number":1243,"context_line":"   [CFLAGS\u003d\"`echo $CFLAGS | $SED -e \u0027s/-O[s0-9]\\\\?//g\u0027`\"]"},{"line_number":1244,"context_line":"fi"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"if test \"${enable_pedantic}\" \u003d \"yes\"; then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ea5961ef_07c90e9d","line":1243,"in_reply_to":"902ed96b_05a168d1","updated":"2026-08-24 15:06:08.000000000","message":"Done","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"}],"src/openvpn/Makefile.am":[{"author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"8c253f5c0aafb393a25fe85609e60657ee28beb7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"\t-DPLUGIN_LIBDIR\u003d\\\"${plugindir}\\\" \\"},{"line_number":36,"context_line":"\t-DDEFAULT_DNS_UPDOWN\u003d\\\"${scriptdir}/dns-updown\\\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"AM_LIBS \u003d $(CODE_COVERAGE_LIBS)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if WIN32"},{"line_number":41,"context_line":"# we want unicode entry point but not the macro"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"eb78210f_10a68008","line":38,"updated":"2026-08-24 14:38:02.000000000","message":"Is `AM_LIBS` a thing? I can\u0027t find it in the Automake docs and it doesn\u0027t seem to be referenced anywhere in our code. Are you after something like `openvpn_LDADD`?","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c06e53157275078e29340510a0ae0e5b6ee9d4ed","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\t-DPLUGIN_LIBDIR\u003d\\\"${plugindir}\\\" \\"},{"line_number":36,"context_line":"\t-DDEFAULT_DNS_UPDOWN\u003d\\\"${scriptdir}/dns-updown\\\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"AM_LIBS \u003d $(CODE_COVERAGE_LIBS)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"if WIN32"},{"line_number":41,"context_line":"# we want unicode entry point but not the macro"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"a6d383dd_1342d5d0","line":38,"in_reply_to":"eb78210f_10a68008","updated":"2026-08-24 15:06:08.000000000","message":"Hmm, I assume I meant AM_LDFLAGS.\nIt doesn\u0027t really matter since we include AM_CFLAGS in LINK as well, but will fix.","commit_id":"22af3b07e55f081a8fcced4045acf7fc908f1bd3"}]}