)]}'
{"id":"openvpn~1592","triplet_id":"openvpn~master~I79b2dc4a550b1c5068a45407976b0dfc2f765b33","project":"openvpn","branch":"master","topic":"coverage","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-25 15:09:42.000000000","reason":"Reviewer was added"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-24 15:18:41.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-08-24 15:18:41.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I79b2dc4a550b1c5068a45407976b0dfc2f765b33","subject":"configure: Add --enable-code-coverage","status":"NEW","created":"2026-03-25 15:09:40.000000000","updated":"2026-08-24 15:18:41.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cef86e99ab3c79cd0b5c108657c5f65eab6bf55d","_number":1592,"virtual_id_number":1592,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2026-08-24 15:18:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-25 15:09:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-25 15:09:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-14 13:18:31.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"9bb73fde52db5f528bf6faae52fc14e5dd989161","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-25 15:09:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dfe0903b7f5b17c91ebe3d0f1412281f5d26c062","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-14 13:18:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b153b559d3c632f6dab307c09926a6704e15fada","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 11:02:20.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f7ff372647f64bb68d1d58762a458ddeecbbede5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-19 13:41:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"62ffed7c69b75707a3a215f661188b3c36d2d1be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-24 13:37:34.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8c253f5c0aafb393a25fe85609e60657ee28beb7","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-24 14:38:02.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"8373a2759cdd887170946782276c7338aa815c3f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-24 15:05:03.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c06e53157275078e29340510a0ae0e5b6ee9d4ed","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-08-24 15:06:08.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"cef86e99ab3c79cd0b5c108657c5f65eab6bf55d","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-24 15:18:41.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f56747651fa06686bce6339595aa241adc83e990","revisions":{"5e8b993001b5ae3d7746f7c348099f56c39c71e9":{"kind":"REWORK","_number":1,"created":"2026-03-25 15:09:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1592/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1592/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1 \u0026\u0026 git checkout -b change-1592 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8298d70b58ce135f7fddbe848a5307c4d65774d2","subject":"m4: Add ax_code_coverage"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"subject":"configure: Add --enable-code-coverage","message":"configure: Add --enable-code-coverage\n\nCan be used like this\n./configure --enable-code-coverage\nmake\nmake check\nmake code-coverage-capture\n\nChange-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"236ef06899a977a8ddfeae8cd02ba71bb0b5e5cf":{"kind":"REWORK","_number":2,"created":"2026-08-19 11:02:20.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1592/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1592/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2 \u0026\u0026 git checkout -b change-1592 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 11:02:10.000000000","tz":120},"subject":"configure: Add --enable-code-coverage","message":"configure: Add --enable-code-coverage\n\nCan be used like this\n./configure --enable-code-coverage\nmake\nmake check\nmake code-coverage-capture\n\nChange-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b29e5e6d76dcc8a609c89d4bca070bf85ed902ee":{"kind":"REWORK","_number":3,"created":"2026-08-19 13:41:46.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1592/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1592/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3 \u0026\u0026 git checkout -b change-1592 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-19 13:40:54.000000000","tz":120},"subject":"configure: Add --enable-code-coverage","message":"configure: Add --enable-code-coverage\n\nCan be used like this\n./configure --enable-code-coverage\nmake\nmake check\nmake code-coverage-capture\n\nNote that we patch ax_code_coverage.m4 to not incur\na dependency on autoconf-archive for a few lines of\ntrivial code.\n\nChange-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"22af3b07e55f081a8fcced4045acf7fc908f1bd3":{"kind":"REWORK","_number":4,"created":"2026-08-24 13:37:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1592/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1592/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4 \u0026\u0026 git checkout -b change-1592 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89a5c5351028d351ce4f3f093e49dd4168d86638","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-24 13:36:51.000000000","tz":120},"subject":"configure: Add --enable-code-coverage","message":"configure: Add --enable-code-coverage\n\nCan be used like this\n./configure --enable-code-coverage\nmake\nmake check\nmake code-coverage-capture\n\nWe heavily patch ax_code_coverage.m4, mostly to\nachieve better compatibility with non-Linux systems.\n- Do not depend on autoconf-archive\n- Do not depend on GNU make\n- Use more modern --coverage flag to better support\n  different compilers\n\nChange-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f56747651fa06686bce6339595aa241adc83e990":{"kind":"REWORK","_number":5,"created":"2026-08-24 15:05:03.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/1592/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/1592/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5 \u0026\u0026 git checkout -b change-1592 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/1592/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be582b2d2688966335a6485479ce3b2cc4a19320","subject":"Make pull_permission_mask return uint64_t"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-25 15:07:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-08-24 15:04:48.000000000","tz":120},"subject":"configure: Add --enable-code-coverage","message":"configure: Add --enable-code-coverage\n\nCan be used like this\n./configure --enable-code-coverage\nmake\nmake check\nmake code-coverage-capture\n\nWe heavily patch ax_code_coverage.m4, mostly to\nachieve better compatibility with non-Linux systems.\n- Do not depend on autoconf-archive\n- Do not depend on GNU make\n- Use more modern --coverage flag to better support\n  different compilers\n\nChange-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}