)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"556c2fad_0d0ccdd8","updated":"2026-03-28 16:32:15.000000000","message":"Applied as suggested and re-tested, thank you","commit_id":"7b2640c3a1e99eb3012c0d9787897622708ed6be"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"c2f05f8c993aed0875b9d128ca2314250e0a1e06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b7be7b4f_76a422da","updated":"2026-03-29 21:48:39.000000000","message":"Can someone with access please enable buildbot runs on this?","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"1701f6ba10181d10c190a689fc818d7cc6103cd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29a02211_8baf3a74","updated":"2026-03-29 21:42:13.000000000","message":"Tested using a patched OpenVPN-GUI. All look good.","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"dc076f68fd404b0326eefb5c13753817369d32a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bb9864ba_f9070f3f","in_reply_to":"32334bb2_bc14ef4f","updated":"2026-03-29 23:31:51.000000000","message":"nvm, it passed on rerun, all green now","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"8a81a0251c58cabe37782a86a5e35f403b46a100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ef2562cc_e5f4b6c9","in_reply_to":"70a4b19b_9cfcf234","updated":"2026-03-29 22:27:41.000000000","message":"Done","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"38adc419d08f7e554068a367cd5b1c5b83185b69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70a4b19b_9cfcf234","in_reply_to":"b7be7b4f_76a422da","updated":"2026-03-29 21:52:54.000000000","message":"I don\u0027t have the rights to do that but builds are triggered depending on who uploads a patch. If I or you are pushing this patch again as patchset 7 it will build.","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"4877876e5418e575fb2c79839ef19405b9a4be7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b15fd167_b74b3503","in_reply_to":"bb9864ba_f9070f3f","updated":"2026-03-30 14:31:51.000000000","message":"Could you please push again, so that the CI runs again with the latest revision? Thanks!","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"c13721472673ab7cda5338aa6b23eae22c04a778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32334bb2_bc14ef4f","in_reply_to":"ef2562cc_e5f4b6c9","updated":"2026-03-29 22:55:52.000000000","message":"One test failed (222 succeeded) - is it a known issue? The linked page with the result doesn\u0027t load for me:\n\nubuntu-2510-factory--with-crypto-librarymbedtls\n\nhttp://buildbot.community.aws.openvpn.in:8010/#/builders/455/builds/1027","commit_id":"eb00d492609514b2ac4866bb6801b35b831f4c03"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"3cccfdbf4ed420c286400fe609be2a118cbfca56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a1f9e9a_b93d20f8","updated":"2026-03-30 12:52:28.000000000","message":"close...\n\nMCV version *4* is MCV_USERNAME_ONLY (which was in gerrit, but not merged before today).\n\nVarious bits here contradict each other - the docs speak about \"version 3\", the commit message mentions \"MCV 4\" and \"version 6\", so this needs cleaning up towards \"5\".  @selva.nair@gmail.com I think you\u0027re best qualified to verify that all these numbers are correct?  I don\u0027t feel I am.\n\nAlso I need clear guidance if this is going to 2.7.x or 2.8 now - doc/management-notes.txt speaks of \"2.8\" now (this is relevant shall we ever want to add a new feature to the management version in 2.7 - since this is a simplistic version compare, if we bump the version number in pre-2.8, we can\u0027t have new management version-dependent features in 2.7).","commit_id":"821b7ebdd31f0935ce4fc4ceda9b4cac30e934d4"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"44a40c38389b96f6bbb16ce0581c9aed0fb8a868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2f087c17_980e7a8d","in_reply_to":"9a1f9e9a_b93d20f8","updated":"2026-03-30 13:01:15.000000000","message":"Ok, bumped MCV to 5.\n\nAlso updated the docs/comments/etc to consistently refer to version \u003e\u003d 5. It was saying \"\u003e 3\" in a couple of place to indicate \"4 or greater\" which yeah it was a bit confusing. Should be clearer now.\n\nAlso I\u0027ve dropped the openvpn source version from the doc. It now only refers to the management protocol version and the management client version. In the end that\u0027s what matters rather than the source version, which might change and so on.\n\nPlease check again, thanks!","commit_id":"821b7ebdd31f0935ce4fc4ceda9b4cac30e934d4"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"cd1568b37f8abe90f7aa58f195f35e101e7fea50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"482798b2_4c29bbaa","updated":"2026-03-30 14:25:18.000000000","message":"To me this looks safe for 2.7 as the changes are very isolated. As we can already set long passwords via stdin/console, one could argue this is not even a new feature. That said, limitations on password length that could fit in the TLS buffer still stands, so unclear of its immediate utility.","commit_id":"91112af95c5a59927fa5b37e65ffa2dae2b71538"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"05b04ac0c4b2b18073e8c88b27ac91fd57ea00a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9c4bfe77_f392d746","in_reply_to":"482798b2_4c29bbaa","updated":"2026-03-30 14:31:08.000000000","message":"\u003e That said, limitations on password length that could fit in the TLS buffer still stands, so unclear of its immediate utility.\n\nI have a WIP branch with another proposal for the TLS buffer issue, which will hopefully be more acceptable. But it is technically unrelated to this management protocol change, so I\u0027m waiting for this to be approved and merged first. Hope that\u0027s ok!","commit_id":"91112af95c5a59927fa5b37e65ffa2dae2b71538"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"3360323d0e3f4a792463e20e87574da6604aa1f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b4ae6b1f_43562367","updated":"2026-04-02 12:08:33.000000000","message":"This has been submitted to the ML as https://sourceforge.net/p/openvpn/mailman/message/59315742/ - anything else I need to do to move this forward? Thanks!","commit_id":"13008c0901ba7736fee8ab54d71cfc2b00a7f96a"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"c97f74319f0b3b2dcd88584bfb4eaf21e76c611b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"02f85852_6d9947f5","updated":"2026-03-30 16:56:07.000000000","message":"thanks, CI all gree again","commit_id":"13008c0901ba7736fee8ab54d71cfc2b00a7f96a"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c88ce8a189ee70647141eb4bcd28a95566d4d55b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ccf9bde3_e98e6800","in_reply_to":"b4ae6b1f_43562367","updated":"2026-04-02 12:13:07.000000000","message":"No, at this point you don\u0027t need to do anything. It is now in the queue of the patches to be merged.","commit_id":"13008c0901ba7736fee8ab54d71cfc2b00a7f96a"}],"doc/management-notes.txt":[{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b6f0f471986a357f2c248ec87588ae9f69936359","unresolved":true,"context_lines":[{"line_number":326,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":327,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":328,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":329,"context_line":"  commands."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":332,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":1,"id":"ec11ebed_489629cf","line":329,"updated":"2026-03-28 15:49:29.000000000","message":"Update MANAGEMENT_VERSION to 6 and document that multi-line password support requires daemon version \u003e\u003d 6.","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[{"line_number":326,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":327,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":328,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":329,"context_line":"  commands."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":332,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":1,"id":"b759445b_0d2c0f53","line":329,"in_reply_to":"ec11ebed_489629cf","updated":"2026-03-28 16:32:15.000000000","message":"Acknowledged","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"16877a6f876dc39eb0ababd54de79a7120d503ab","unresolved":true,"context_lines":[{"line_number":327,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":328,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":329,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":330,"context_line":"  commands. Requires OpenVPN 2.6+ management version \u003e 6."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":333,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":3,"id":"e6bf8340_48d90d74","line":330,"updated":"2026-03-29 01:00:26.000000000","message":"2.7.x+ or 2.8+ instead of 2.6+ depending on where this lands. Could be fixed at merge time.\nAlso, \"management version \u003e\u003d 6\", right?","commit_id":"121ea5745a6942d320c8d76a52c30e97c1c6a4d3"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"924f28878073bfd730e3be7a2b401eb1f5813690","unresolved":false,"context_lines":[{"line_number":327,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":328,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":329,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":330,"context_line":"  commands. Requires OpenVPN 2.6+ management version \u003e 6."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":333,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":3,"id":"05be92b2_36d8ef0c","line":330,"in_reply_to":"22eb0ca7_548a804f","updated":"2026-03-29 14:38:20.000000000","message":"actually noticed the 2.7.x are on a separate stable branch, so I\u0027ve changed this to \"OpenVPN 2.8+\" now","commit_id":"121ea5745a6942d320c8d76a52c30e97c1c6a4d3"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"77ab546ba5b15d4bcda441e6d6cce10510c10384","unresolved":false,"context_lines":[{"line_number":327,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":328,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":329,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":330,"context_line":"  commands. Requires OpenVPN 2.6+ management version \u003e 6."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":333,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":3,"id":"22eb0ca7_548a804f","line":330,"in_reply_to":"7693b0c0_dad5e836","updated":"2026-03-29 01:05:23.000000000","message":"I could also drop the source version and leave only the management version, if that makes it easier - let me know","commit_id":"121ea5745a6942d320c8d76a52c30e97c1c6a4d3"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"cb8890038f6c4dda344cbfbc8b857dbf3bc04e90","unresolved":false,"context_lines":[{"line_number":327,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":328,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":329,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":330,"context_line":"  commands. Requires OpenVPN 2.6+ management version \u003e 6."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":333,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":3,"id":"7693b0c0_dad5e836","line":330,"in_reply_to":"d87593c5_06589fe7","updated":"2026-03-29 01:03:59.000000000","message":"Acknowledged","commit_id":"121ea5745a6942d320c8d76a52c30e97c1c6a4d3"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"d09af210625b92d412bbab2e59af263bde351ce8","unresolved":true,"context_lines":[{"line_number":327,"context_line":"  In this format, the password is base64-encoded and split across"},{"line_number":328,"context_line":"  multiple lines, followed by END.  Each line can be at most 1024"},{"line_number":329,"context_line":"  bytes.  This is the same format used by pk-sig and certificate"},{"line_number":330,"context_line":"  commands. Requires OpenVPN 2.6+ management version \u003e 6."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"  The PASSWORD real-time message type can also be used to"},{"line_number":333,"context_line":"  indicate password or other types of authentication failure:"}],"source_content_type":"text/plain","patch_set":3,"id":"d87593c5_06589fe7","line":330,"in_reply_to":"e6bf8340_48d90d74","updated":"2026-03-29 01:03:48.000000000","message":"I\u0027m being optimistic, so pushed with 2.7.1+ :-)","commit_id":"121ea5745a6942d320c8d76a52c30e97c1c6a4d3"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"cd1568b37f8abe90f7aa58f195f35e101e7fea50","unresolved":true,"context_lines":[{"line_number":528,"context_line":"Minimum client version required for certain features is listed below:"},{"line_number":529,"context_line":"    \u003ePK_SIGN:[base64]           -- version 2 or greater"},{"line_number":530,"context_line":"    \u003ePK_SIGN:[base64],[alg]     -- version 3 or greater"},{"line_number":531,"context_line":"    \u003ePASSWORD:Need \u0027Auth\u0027 username -- version 4 or greater"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"COMMAND -- auth-retry"},{"line_number":534,"context_line":"---------------------"}],"source_content_type":"text/plain","patch_set":8,"id":"d8383e4f_fc3eda84","line":531,"updated":"2026-03-30 14:25:18.000000000","message":"Please add a line here to keep track of client versions. Usually client version is updated only when new server-\u003eclient commands are added -- this one is a special case. So something like:\nmultiline password from client -- version 5 or greater ??","commit_id":"91112af95c5a59927fa5b37e65ffa2dae2b71538"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"05b04ac0c4b2b18073e8c88b27ac91fd57ea00a1","unresolved":false,"context_lines":[{"line_number":528,"context_line":"Minimum client version required for certain features is listed below:"},{"line_number":529,"context_line":"    \u003ePK_SIGN:[base64]           -- version 2 or greater"},{"line_number":530,"context_line":"    \u003ePK_SIGN:[base64],[alg]     -- version 3 or greater"},{"line_number":531,"context_line":"    \u003ePASSWORD:Need \u0027Auth\u0027 username -- version 4 or greater"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"COMMAND -- auth-retry"},{"line_number":534,"context_line":"---------------------"}],"source_content_type":"text/plain","patch_set":8,"id":"71172fcd_66764247","line":531,"in_reply_to":"d8383e4f_fc3eda84","updated":"2026-03-30 14:31:08.000000000","message":"Done","commit_id":"91112af95c5a59927fa5b37e65ffa2dae2b71538"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"215801b5aa9ea2200b8bc34e9fac4f9b85b632c5","unresolved":true,"context_lines":[{"line_number":529,"context_line":"    \u003ePK_SIGN:[base64]           -- version 2 or greater"},{"line_number":530,"context_line":"    \u003ePK_SIGN:[base64],[alg]     -- version 3 or greater"},{"line_number":531,"context_line":"    \u003ePASSWORD:Need \u0027Auth\u0027 username -- version 4 or greater"},{"line_number":532,"context_line":"    \u003ePASSWORD:multiline password from client -- version 5 or greater"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"COMMAND -- auth-retry"},{"line_number":535,"context_line":"---------------------"}],"source_content_type":"text/plain","patch_set":9,"id":"0c5ab2d1_0627474d","line":532,"updated":"2026-03-30 15:05:07.000000000","message":"This is confusing as its not \u003ePASSWORD: command from management server that is extended, but password \u0027Type\u0027 reply from client.","commit_id":"842458a8174dfba0e88d1e6bc9475ca704076718"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"8715a9bba6f177fac3bc4332f0285cd7523e41e4","unresolved":false,"context_lines":[{"line_number":529,"context_line":"    \u003ePK_SIGN:[base64]           -- version 2 or greater"},{"line_number":530,"context_line":"    \u003ePK_SIGN:[base64],[alg]     -- version 3 or greater"},{"line_number":531,"context_line":"    \u003ePASSWORD:Need \u0027Auth\u0027 username -- version 4 or greater"},{"line_number":532,"context_line":"    \u003ePASSWORD:multiline password from client -- version 5 or greater"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"COMMAND -- auth-retry"},{"line_number":535,"context_line":"---------------------"}],"source_content_type":"text/plain","patch_set":9,"id":"bdf7c8e2_32c89363","line":532,"in_reply_to":"0c5ab2d1_0627474d","updated":"2026-03-30 15:06:38.000000000","message":"Done","commit_id":"842458a8174dfba0e88d1e6bc9475ca704076718"}],"src/openvpn/manage.c":[{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b6f0f471986a357f2c248ec87588ae9f69936359","unresolved":true,"context_lines":[{"line_number":1026,"context_line":" *  END"},{"line_number":1027,"context_line":" *"},{"line_number":1028,"context_line":" * @param man           The management interface struct"},{"line_number":1029,"context_line":" * @param type          The type of password being entered (e.g. \"Auth\", \"TLS-Auth\", etc)"},{"line_number":1030,"context_line":" */"},{"line_number":1031,"context_line":"static void"},{"line_number":1032,"context_line":"man_query_password_base64(struct management *man, const char *type)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0fc3a710_af3796ab","line":1029,"updated":"2026-03-28 15:49:29.000000000","message":"Nitpick: \"TLS-Auth\" is not a valid type -- \"Private Key\" ?","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[{"line_number":1026,"context_line":" *  END"},{"line_number":1027,"context_line":" *"},{"line_number":1028,"context_line":" * @param man           The management interface struct"},{"line_number":1029,"context_line":" * @param type          The type of password being entered (e.g. \"Auth\", \"TLS-Auth\", etc)"},{"line_number":1030,"context_line":" */"},{"line_number":1031,"context_line":"static void"},{"line_number":1032,"context_line":"man_query_password_base64(struct management *man, const char *type)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"637bc2bb_b3e0712d","line":1029,"in_reply_to":"0fc3a710_af3796ab","updated":"2026-03-28 16:32:15.000000000","message":"Acknowledged","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b6f0f471986a357f2c248ec87588ae9f69936359","unresolved":true,"context_lines":[{"line_number":1099,"context_line":"                                                USER_PASS_LEN - 1);"},{"line_number":1100,"context_line":"                if (len \u003c 0)"},{"line_number":1101,"context_line":"                {"},{"line_number":1102,"context_line":"                    msg(M_CLIENT, \"ERROR: could not base64-decode password\");"},{"line_number":1103,"context_line":"                    break;"},{"line_number":1104,"context_line":"                }"},{"line_number":1105,"context_line":"                decoded[len] \u003d \u0027\\0\u0027;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ce75309c_cca007a8","line":1102,"updated":"2026-03-28 15:49:29.000000000","message":"This could lead to an unhelpful decode error or silent truncation which is hard to debug.\n\nInstead, use a larger length like OPENVPN_BASE64_LENGTH(USER_PASS_LEN) + 1024 that will capture some of the excess data (if any), and then check OPENVPN_BASE64_DECODE_LENGTH(BLEN(buf)) \u003c USER_PASS_LEN. On failure, return an ERROR message showing password is too long.","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"                                                USER_PASS_LEN - 1);"},{"line_number":1100,"context_line":"                if (len \u003c 0)"},{"line_number":1101,"context_line":"                {"},{"line_number":1102,"context_line":"                    msg(M_CLIENT, \"ERROR: could not base64-decode password\");"},{"line_number":1103,"context_line":"                    break;"},{"line_number":1104,"context_line":"                }"},{"line_number":1105,"context_line":"                decoded[len] \u003d \u0027\\0\u0027;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7a862134_202d00db","line":1102,"in_reply_to":"ce75309c_cca007a8","updated":"2026-03-28 16:32:15.000000000","message":"Acknowledged","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b6f0f471986a357f2c248ec87588ae9f69936359","unresolved":true,"context_lines":[{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"            man_query_password(man, man-\u003econnection.up_query_type,"},{"line_number":1109,"context_line":"                               decoded);"},{"line_number":1110,"context_line":"            secure_memzero(decoded, sizeof(decoded));"},{"line_number":1111,"context_line":"            break;"},{"line_number":1112,"context_line":"        }"},{"line_number":1113,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"13426238_dff01d9f","line":1110,"updated":"2026-03-28 15:49:29.000000000","message":"Also needs a buf_clear() somewhere as buf contains sensitive data.","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"            man_query_password(man, man-\u003econnection.up_query_type,"},{"line_number":1109,"context_line":"                               decoded);"},{"line_number":1110,"context_line":"            secure_memzero(decoded, sizeof(decoded));"},{"line_number":1111,"context_line":"            break;"},{"line_number":1112,"context_line":"        }"},{"line_number":1113,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ba43603c_1204f5ea","line":1110,"in_reply_to":"13426238_dff01d9f","updated":"2026-03-28 16:32:15.000000000","message":"Acknowledged","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b6f0f471986a357f2c248ec87588ae9f69936359","unresolved":true,"context_lines":[{"line_number":1661,"context_line":"            man_query_password(man, p[1], p[2]);"},{"line_number":1662,"context_line":"        }"},{"line_number":1663,"context_line":"    }"},{"line_number":1664,"context_line":"    else if (streq(p[0], \"password-base64\"))"},{"line_number":1665,"context_line":"    {"},{"line_number":1666,"context_line":"        if (man_need(man, p, 1, 0))"},{"line_number":1667,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1de6799c_71c005a6","line":1664,"updated":"2026-03-28 15:49:29.000000000","message":"As Gert suggested, we could use \"password \u0027Type\u0027\" with no argument and interpret it differently based on the management-client-version (say MCV_MULTILINE_PASSWORD). Better than introducing a different keyword?","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"},{"author":{"_account_id":1000050,"name":"Bluca","email":"luca.boccassi@gmail.com","username":"Bluca"},"change_message_id":"5141de16c063714da3bafaa84eb36c4db840ca6e","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"            man_query_password(man, p[1], p[2]);"},{"line_number":1662,"context_line":"        }"},{"line_number":1663,"context_line":"    }"},{"line_number":1664,"context_line":"    else if (streq(p[0], \"password-base64\"))"},{"line_number":1665,"context_line":"    {"},{"line_number":1666,"context_line":"        if (man_need(man, p, 1, 0))"},{"line_number":1667,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ef07d82c_af4a08f9","line":1664,"in_reply_to":"1de6799c_71c005a6","updated":"2026-03-28 16:32:15.000000000","message":"Acknowledged","commit_id":"8a79de1dd3ad5bc3a4b9bc278738fc9ef73e0071"}]}