)]}'
{"id":"openvpn~1594","triplet_id":"openvpn~master~I1a6dfc175075636bc7a5761215547077a9dc397a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-03-30 22:24:24.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-03-31 08:00:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1a6dfc175075636bc7a5761215547077a9dc397a","subject":"ssl_ncp: Fix type of \"found\" parameter of check_pull_client_ncp","status":"MERGED","created":"2026-03-30 21:27:19.000000000","updated":"2026-03-31 08:00:14.000000000","submitted":"2026-03-31 08:00:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1594","meta_rev_id":"87462bce0994662d079888b9f12969894c59586b","_number":1594,"virtual_id_number":1594,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-30 21:27:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-03-30 21:27:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"655489d50e7d5a6a9fb1b437937bc0bc0f58ad5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-03-30 21:27:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee874b2972fc257b1cef808b36304c5ee87273ef","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-03-30 22:24:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"87462bce0994662d079888b9f12969894c59586b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-03-31 08:00:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3ba76022430adce09b1ead0438b5c1fe99d3e661","revisions":{"cafe2a4f925d23bf3c9a2a52a88c5fec968f9a99":{"kind":"REWORK","_number":1,"created":"2026-03-30 21:27:19.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/94/1594/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1594/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1 \u0026\u0026 git checkout -b change-1594 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"69949c9101ebccb9ad0d2c4a6d2e6049d0e37de3","subject":"dns: Change arguments to setenv_dns_option to avoid sign-compare warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-30 21:24:06.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-30 21:26:20.000000000","tz":120},"subject":"ssl_ncp: Fix type of \"found\" parameter of check_pull_client_ncp","message":"ssl_ncp: Fix type of \"found\" parameter of check_pull_client_ncp\n\nIn commit 91fd9614f980b02772e4dfbb09144c822ec97df0 type\nof \"found\" was changed to uint64_t. But due to -Wconversion\nnot yet enabled in all of init.c one occurence of the old\ntype was missed.\n\nChange-Id: I1a6dfc175075636bc7a5761215547077a9dc397a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3ba76022430adce09b1ead0438b5c1fe99d3e661":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-03-31 08:00:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/94/1594/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1594/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2 \u0026\u0026 git checkout -b change-1594 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1594/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bee158db0fabd273a19e9cd375832409c0cd5bd3","subject":"buffer: Avoid sign-compare warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-03-31 06:01:05.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-03-31 07:59:22.000000000","tz":120},"subject":"ssl_ncp: Fix type of \"found\" parameter of check_pull_client_ncp","message":"ssl_ncp: Fix type of \"found\" parameter of check_pull_client_ncp\n\nIn commit 91fd9614f980b02772e4dfbb09144c822ec97df0 type\nof \"found\" was changed to uint64_t. But due to -Wconversion\nnot yet enabled in all of init.c one occurence of the old\ntype was missed.\n\nChange-Id: I1a6dfc175075636bc7a5761215547077a9dc397a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1594\nMessage-Id: \u003c20260331060112.5195-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36364.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}