)]}'
{"src/openvpn/ssl_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1140488e3ea1af942fce40fdd43e13e997eb8c21","unresolved":true,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    if (vpm \u003d\u003d NULL)"},{"line_number":690,"context_line":"    {"},{"line_number":691,"context_line":"        msg(D_TLS_DEBUG_MED, \"Failed to initialise certificate verification parameters.\");"},{"line_number":692,"context_line":"    }"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    X509_VERIFY_PARAM_set_flags(vpm, X509_V_FLAG_USE_CHECK_TIME);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ce3d6801_f2791ace","line":691,"updated":"2026-04-01 10:34:38.000000000","message":"Shouldn\u0027t we return from the function here?","commit_id":"9fc2372c9bc05a7db18f2ee4bfe2d3856345159e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"42093d5c4f12ba87524bf22928b14f9645b3a073","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    if (vpm \u003d\u003d NULL)"},{"line_number":690,"context_line":"    {"},{"line_number":691,"context_line":"        msg(D_TLS_DEBUG_MED, \"Failed to initialise certificate verification parameters.\");"},{"line_number":692,"context_line":"    }"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    X509_VERIFY_PARAM_set_flags(vpm, X509_V_FLAG_USE_CHECK_TIME);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9936038d_d6f94305","line":691,"in_reply_to":"ce3d6801_f2791ace","updated":"2026-04-01 11:34:25.000000000","message":"yeah. Good catch","commit_id":"9fc2372c9bc05a7db18f2ee4bfe2d3856345159e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1140488e3ea1af942fce40fdd43e13e997eb8c21","unresolved":true,"context_lines":[{"line_number":705,"context_line":"    {"},{"line_number":706,"context_line":"        msg(M_WARN, \"WARNING: Your certificate is not yet valid!\");"},{"line_number":707,"context_line":"    }"},{"line_number":708,"context_line":"    if (ret \u003d\u003d X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD)"},{"line_number":709,"context_line":"    {"},{"line_number":710,"context_line":"        msg(D_TLS_DEBUG_MED, \"Failed to read certificate notAfter field.\");"},{"line_number":711,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ed877e20_2571c8e7","line":708,"updated":"2026-04-01 10:34:38.000000000","message":"error, not ret","commit_id":"9fc2372c9bc05a7db18f2ee4bfe2d3856345159e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"42093d5c4f12ba87524bf22928b14f9645b3a073","unresolved":false,"context_lines":[{"line_number":705,"context_line":"    {"},{"line_number":706,"context_line":"        msg(M_WARN, \"WARNING: Your certificate is not yet valid!\");"},{"line_number":707,"context_line":"    }"},{"line_number":708,"context_line":"    if (ret \u003d\u003d X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD)"},{"line_number":709,"context_line":"    {"},{"line_number":710,"context_line":"        msg(D_TLS_DEBUG_MED, \"Failed to read certificate notAfter field.\");"},{"line_number":711,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2d685abe_e195c5f2","line":708,"in_reply_to":"ed877e20_2571c8e7","updated":"2026-04-01 11:34:25.000000000","message":"Acknowledged","commit_id":"9fc2372c9bc05a7db18f2ee4bfe2d3856345159e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"03a5d55010a8bc6e06ec5423d753ac94fa382738","unresolved":true,"context_lines":[{"line_number":685,"context_line":"        return;"},{"line_number":686,"context_line":"    }"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    if (error \u003d\u003d X509_V_ERR_ERROR_IN_CERT_NOT_BEFORE_FIELD)"},{"line_number":689,"context_line":"    {"},{"line_number":690,"context_line":"        msg(D_TLS_DEBUG_MED, \"Failed to read certificate notBefore field.\");"},{"line_number":691,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7faf7350_74c0cf48","line":688,"updated":"2026-04-04 16:51:32.000000000","message":"Not sure whether that is bikeshedding, but should we maybe use a case statement here? Looks more appropriate for checking the same variable against 4 values.","commit_id":"eb5c944ddaab5c9b3240c7853b93863b2180dd55"}]}