)]}'
{"id":"openvpn~1609","triplet_id":"openvpn~master~I04a01cf536ee6d48d54ba623dda460c4a98859f9","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-05 10:28:06.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-04-05 10:28:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I04a01cf536ee6d48d54ba623dda460c4a98859f9","subject":"mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready","status":"MERGED","created":"2026-04-04 18:56:23.000000000","updated":"2026-04-05 10:28:06.000000000","submitted":"2026-04-05 10:28:06.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1609-cppcheck","meta_rev_id":"154df37cad51505f114718171ba29ac3f934331c","_number":1609,"virtual_id_number":1609,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-04 18:56:24.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-04 18:56:24.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-04 20:33:22.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1409fd818bcaafc11ba690f0c183cb7a087810b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-04 18:56:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96c5a226b31a6611ddbd8707885f782c0a36fd99","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-04 20:33:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"154df37cad51505f114718171ba29ac3f934331c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-05 10:28:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d44ed886c279de51a936cc0652c9b72c943a6558","revisions":{"745c7e3bdb800e5c1b8a9214d35550cf6fde15f0":{"kind":"REWORK","_number":1,"created":"2026-04-04 18:56:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/09/1609/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/09/1609/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1 \u0026\u0026 git checkout -b change-1609 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4284dc4d406b1e3838884d40deb1cb839facd8d1","subject":"openvpnmsica: Fix setting of iTicks in schedule_adapter_delete"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-04 18:54:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-04 18:54:46.000000000","tz":120},"subject":"mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready","message":"mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready\n\nAssigning to a parameter here has no effect. I can see no\nobvious alternative statement that might have been intended.\n\nFound by cppcheck.\n\nChange-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d44ed886c279de51a936cc0652c9b72c943a6558":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-04-05 10:28:06.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/09/1609/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/09/1609/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2 \u0026\u0026 git checkout -b change-1609 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/09/1609/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6cea99f4a36d170b2c11c89ba95b4dce255b3ee","subject":"Remove various unused structs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-04 20:33:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-05 10:26:48.000000000","tz":120},"subject":"mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready","message":"mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready\n\nAssigning to a parameter here has no effect. I can see no\nobvious alternative statement that might have been intended.\n\nFound by cppcheck.\n\nChange-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609\nMessage-Id: \u003c20260404203335.30650-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36478.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}