)]}'
{"id":"openvpn~1613","triplet_id":"openvpn~master~Iacf06c113e8db5b7c78270f361ee76938ef1db47","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-19 15:56:07.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-04-19 15:56:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iacf06c113e8db5b7c78270f361ee76938ef1db47","subject":"Remove various redundant conditionals","status":"MERGED","created":"2026-04-05 20:39:18.000000000","updated":"2026-04-19 15:56:07.000000000","submitted":"2026-04-19 15:56:07.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1613-cppcheck","meta_rev_id":"925fa506e239403e9f0e62bbb4c68b8db25c9cd5","_number":1613,"virtual_id_number":1613,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-05 20:39:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-05 20:39:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-19 13:51:03.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ecec2cc569e4acd2e71c390763905a82d005b75a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-05 20:39:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5957b5702707238c31a863e2d499a353c4c32f6a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-07 20:06:24.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"568455b72991688c9acf50b2838fa4e9094b19ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-13 11:55:18.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"0804dea55cb79637c31e551d63de3e8cc0a782b4","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-19 13:51:03.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"925fa506e239403e9f0e62bbb4c68b8db25c9cd5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-19 15:56:07.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"22062deb5dc04670b48511580d576df3c4682b2e","revisions":{"8e9a1029b0e42d3092d4b8535c5ec734ffbcf3c1":{"kind":"REWORK","_number":1,"created":"2026-04-05 20:39:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1613/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1613/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1 \u0026\u0026 git checkout -b change-1613 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23841e3ddbf6a000437236a3dfc874d9e5f21542","subject":"Hide various functions when unused"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 19:43:44.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:38:35.000000000","tz":120},"subject":"Remove various redundant conditionals","message":"Remove various redundant conditionals\n\nThese are all already proven to be true by\nsurrounding code.\n\nIdentified by cppcheck.\n\nChange-Id: Iacf06c113e8db5b7c78270f361ee76938ef1db47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5795a2d9406ff2c092d91e80383f81f1e78c7c78":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-04-07 20:06:24.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1613/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1613/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2 \u0026\u0026 git checkout -b change-1613 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db35ef2eaf6f07f923011cb02cfbe0c098a49a1b","subject":"Hide various functions when unused"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 19:43:44.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-07 19:58:20.000000000","tz":120},"subject":"Remove various redundant conditionals","message":"Remove various redundant conditionals\n\nThese are all already proven to be true by\nsurrounding code.\n\nIdentified by cppcheck.\n\nChange-Id: Iacf06c113e8db5b7c78270f361ee76938ef1db47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"72cc8d1c98f336ea568350d75caedd933cd49e64":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-04-13 11:55:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/13/1613/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1613/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3 \u0026\u0026 git checkout -b change-1613 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a9ed9231419ae18262be3d9c8b020bf4b685382","subject":"Hide various functions when unused"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 19:43:44.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-13 11:39:21.000000000","tz":120},"subject":"Remove various redundant conditionals","message":"Remove various redundant conditionals\n\nThese are all already proven to be true by\nsurrounding code.\n\nIdentified by cppcheck.\n\nChange-Id: Iacf06c113e8db5b7c78270f361ee76938ef1db47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"22062deb5dc04670b48511580d576df3c4682b2e":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-04-19 15:56:07.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/13/1613/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/1613/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4 \u0026\u0026 git checkout -b change-1613 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/1613/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d54d7ca5d32ebd830298b303a1146365fb35bbc","subject":"tapctl: Remove unused function dont_mute"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-19 13:51:11.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-19 15:51:47.000000000","tz":120},"subject":"Remove various redundant conditionals","message":"Remove various redundant conditionals\n\nThese are all already proven to be true by\nsurrounding code.\n\nIdentified by cppcheck.\n\nChange-Id: Iacf06c113e8db5b7c78270f361ee76938ef1db47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1613\nMessage-Id: \u003c20260419135116.22170-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36666.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}