)]}'
{"id":"openvpn~1614","triplet_id":"openvpn~master~Idfe2afd9616e17f0f80a914ff054ae18f0b6972b","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-12 15:12:16.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-04-12 15:12:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idfe2afd9616e17f0f80a914ff054ae18f0b6972b","subject":"networking_sitnl: Make sitnl_parse_rtattr* return void","status":"MERGED","created":"2026-04-05 20:39:18.000000000","updated":"2026-04-12 15:12:16.000000000","submitted":"2026-04-12 15:12:16.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1614-cppcheck","meta_rev_id":"d6eb4ce02f50a7ec5858846c6ecf20a6ca26d7d4","_number":1614,"virtual_id_number":1614,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-05 20:39:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-05 20:39:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-08 20:08:56.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"518df22b4dd9f38e60c180b0ea5e298af3cf5739","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-05 20:39:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c7a043642bf5b01839d7a7234323a6d6f75b23d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-07 20:06:24.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"9661f14875730e95076b117e1c9d019f1db81a85","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-04-08 20:08:56.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d6eb4ce02f50a7ec5858846c6ecf20a6ca26d7d4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-12 15:12:16.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9760928e39bce5620273ceb9c4a9f5b7471d1781","revisions":{"dc03ab22563ee49e1a6ee5f65402fea5cfceac8d":{"kind":"REWORK","_number":1,"created":"2026-04-05 20:39:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/14/1614/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1614/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1 \u0026\u0026 git checkout -b change-1614 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8e9a1029b0e42d3092d4b8535c5ec734ffbcf3c1","subject":"Remove various redundant conditionals"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 19:46:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:38:35.000000000","tz":120},"subject":"networking_sitnl: Make sitnl_parse_rtattr* return void","message":"networking_sitnl: Make sitnl_parse_rtattr* return void\n\nIt returned a constant value so it didn\u0027t actually\ndo anything.\n\nIdentified by cppcheck.\n\nChange-Id: Idfe2afd9616e17f0f80a914ff054ae18f0b6972b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"839d625a7b1183b523f95a22592280bd4c65265b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-04-07 20:06:24.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/14/1614/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1614/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2 \u0026\u0026 git checkout -b change-1614 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5795a2d9406ff2c092d91e80383f81f1e78c7c78","subject":"Remove various redundant conditionals"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 19:46:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-07 19:58:20.000000000","tz":120},"subject":"networking_sitnl: Make sitnl_parse_rtattr* return void","message":"networking_sitnl: Make sitnl_parse_rtattr* return void\n\nIt returned a constant value so it didn\u0027t actually\ndo anything.\n\nIdentified by cppcheck.\n\nChange-Id: Idfe2afd9616e17f0f80a914ff054ae18f0b6972b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9760928e39bce5620273ceb9c4a9f5b7471d1781":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-04-12 15:12:16.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/14/1614/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1614/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3 \u0026\u0026 git checkout -b change-1614 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1614/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ab3ba0cab7c38699c38898457f403b9b9a40eb3f","subject":"Optimise iterating over all clients by remembering highest peer id"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-08 20:42:07.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-12 15:11:06.000000000","tz":120},"subject":"networking_sitnl: Make sitnl_parse_rtattr* return void","message":"networking_sitnl: Make sitnl_parse_rtattr* return void\n\nIt returned a constant value so it didn\u0027t actually\ndo anything.\n\nIdentified by cppcheck.\n\nChange-Id: Idfe2afd9616e17f0f80a914ff054ae18f0b6972b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1614\nMessage-Id: \u003c20260408204213.9892-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36559.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}