)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"dc7b0b0f68fa2da9c67d6e03af335685d5b490b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"28ea3c29_2f9a9bc6","updated":"2026-08-08 13:13:30.000000000","message":"This commit also removes the initalisation of the buffer by \u003d clear_buf(); While that might do something. I think that change should be explained in the commit message or the initisation should be kept or replace by a simple \u003d { 0 }; since that is what clear_buf does anyway.","commit_id":"5f440cfa6725af843e25a622588fc010486667a4"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"717c3057479139e2459449c658fd2ba88d805454","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cbace028_e845bb49","in_reply_to":"28ea3c29_2f9a9bc6","updated":"2026-08-10 12:02:09.000000000","message":"In don\u0027t understand your point. As the commit message says we only remove assignments of values that are never used for anything.","commit_id":"5f440cfa6725af843e25a622588fc010486667a4"}],"src/openvpn/console_builtin.c":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"783f36aafc384045a1cc0bf6e1b2a1b2d08dea70","unresolved":true,"context_lines":[{"line_number":200,"context_line":"#if defined(_WIN32)"},{"line_number":201,"context_line":"    return get_console_input_win32(prompt, echo, input, capacity);"},{"line_number":202,"context_line":"#elif !defined(HAVE_TERMIOS_H)"},{"line_number":203,"context_line":"    msg(M_FATAL, \"Sorry, but I can\u0027t get console input on this OS (%s)\", prompt);"},{"line_number":204,"context_line":"#else"},{"line_number":205,"context_line":"    bool restore_tty \u003d false;"},{"line_number":206,"context_line":"    bool ret \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"ed7d4c69_3b98ea0a","line":203,"updated":"2026-08-13 12:58:49.000000000","message":"this loses return. M_FATAL means exit, but won\u0027t we get a compiler warning on the platforms which are not WIN32 and don\u0027t have termios? The fix would be moving \"return red\" in the end of function above #endif.","commit_id":"5f440cfa6725af843e25a622588fc010486667a4"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"22bb1ce17b51b4c7aae05aea37284926abd26166","unresolved":true,"context_lines":[{"line_number":200,"context_line":"#if defined(_WIN32)"},{"line_number":201,"context_line":"    return get_console_input_win32(prompt, echo, input, capacity);"},{"line_number":202,"context_line":"#elif !defined(HAVE_TERMIOS_H)"},{"line_number":203,"context_line":"    msg(M_FATAL, \"Sorry, but I can\u0027t get console input on this OS (%s)\", prompt);"},{"line_number":204,"context_line":"#else"},{"line_number":205,"context_line":"    bool restore_tty \u003d false;"},{"line_number":206,"context_line":"    bool ret \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"a42ad3c9_4f641da3","line":203,"in_reply_to":"ed7d4c69_3b98ea0a","updated":"2026-08-14 10:40:57.000000000","message":"In general we added EXIT_FATAL macro to msg() exactly so that tools would not complain. We do not usually add return statements after M_FATAL. But of course in most functions there is some return still afterwards.\n\nNot sure how we would test this specific instance. I don\u0027t know if we even have a platform where this code branch is used...","commit_id":"5f440cfa6725af843e25a622588fc010486667a4"}]}