)]}'
{"id":"openvpn~1620","triplet_id":"openvpn~master~I125cf63f11257d7245ead2f7feafb86b841580a5","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-22 07:46:27.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-04-22 07:46:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I125cf63f11257d7245ead2f7feafb86b841580a5","subject":"dev-tools: Add script to run cppcheck against the code-base","status":"MERGED","created":"2026-04-05 20:39:18.000000000","updated":"2026-04-22 07:46:27.000000000","submitted":"2026-04-22 07:46:27.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1620-cppcheck","meta_rev_id":"dfc6b73b0df2eeb6cd4cd66b73474002cb44dc12","_number":1620,"virtual_id_number":1620,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-05 20:39:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-05 20:39:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-19 13:41:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"9b997ca5b5ed1aed0499ef3aa3d14eebdfbee77f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-05 20:39:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fcd35dd89847109c1d2ca619375a11e88878546f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-05 22:03:28.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"97ee65a171435316f294a813a3e2129e65a26861","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-07 20:06:24.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"eb5a787a6e61a0f8bb67520590f6ac6aa9e5d03d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-07 23:42:41.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e586c976097260deb94eeb99b43ce8a344a2305f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-04-13 11:55:18.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"10fb52c972af4a24d8c7224def4ff74a9220261d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-19 13:41:48.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"dfc6b73b0df2eeb6cd4cd66b73474002cb44dc12","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-22 07:46:27.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"0b7c29535049baec9fe89821cd2a65437094c9b1","revisions":{"4d9984a694ed8caab915567b9163bc6363871542":{"kind":"REWORK","_number":1,"created":"2026-04-05 20:39:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/1620/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"25fd67ca333500694449119a9941b3c8b1f087bc","subject":"Clarify operator precedence in a \u0026 b ? c : d"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:24:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:38:35.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3f83de2bed2c7e8e5a1da86e587917f76fd4b6e3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-04-05 22:03:28.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/1620/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea9f8f62f42abe41e765f9326f796e73e7df8e23","subject":"test_packet_id: Add a check after malloc to ensure value is valid"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:24:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 22:03:24.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"839a65b7492a699d590934ca18711e0f43777fc9":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-04-07 20:06:24.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/1620/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4915305b17c7eeee2cc98816669545f41685df8d","subject":"openvpnserv: Remove redundant bit-wise operation"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:24:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-07 20:06:04.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3cb8f46c6928ae307226ec13f7f3905cd4fd826f":{"kind":"REWORK","_number":4,"created":"2026-04-07 23:42:41.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/1620/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4915305b17c7eeee2cc98816669545f41685df8d","subject":"openvpnserv: Remove redundant bit-wise operation"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:24:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-07 21:03:44.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0986d93fa75e3fe4f3e96ce5fd75221d26db936f":{"kind":"REWORK","_number":5,"created":"2026-04-13 11:55:18.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/1620/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"845e994821fba08520664fb90da9e0e60852784d","subject":"ssl_mbedtls: Fix format string in get_ssl_library_version"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-05 20:24:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-13 11:55:01.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0b7c29535049baec9fe89821cd2a65437094c9b1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2026-04-22 07:46:27.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/20/1620/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1620/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6 \u0026\u0026 git checkout -b change-1620 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1620/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"25a3cec98d67ad540ebd2f102485caeeb0450d60","subject":"Fix copyright line in README"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-04-19 13:41:57.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-22 07:44:22.000000000","tz":120},"subject":"dev-tools: Add script to run cppcheck against the code-base","message":"dev-tools: Add script to run cppcheck against the code-base\n\nAlso add a suitable suppressions-list file to\nmake it possible to run it without reporting\nerrors.\n\nTested with cppcheck 2.19.0 (Ubuntu 26.04).\n\nChange-Id: I125cf63f11257d7245ead2f7feafb86b841580a5\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1620\nMessage-Id: \u003c20260419134205.21459-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36664.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}