)]}'
{"src/openvpn/ssl_verify.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"b1d76cc9ac545b0aa8ddbd2bb826790d38e0f163","unresolved":true,"context_lines":[{"line_number":394,"context_line":"            msg(D_HANDSHAKE, err_fmt, match_str, opt-\u003everify_x509_name);"},{"line_number":395,"context_line":"            return FAILURE;"},{"line_number":396,"context_line":"        }"},{"line_number":397,"context_line":"        msg(D_HANDSHAKE, \"VERIFY X509NAME OK: %s\", subject);"},{"line_number":398,"context_line":"    }"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    return SUCCESS;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9a8f2a69_b9100741","line":397,"updated":"2026-04-13 09:16:12.000000000","message":"by applying the same logic, shouldn\u0027t we just print the string we have matched against, instead of the whole subject?","commit_id":"b66690602ee8f2b6f3b618efe1d8fc4b999a682f"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f1b501dce496228718ccd18bf8e331fb0da823ca","unresolved":true,"context_lines":[{"line_number":394,"context_line":"            msg(D_HANDSHAKE, err_fmt, match_str, opt-\u003everify_x509_name);"},{"line_number":395,"context_line":"            return FAILURE;"},{"line_number":396,"context_line":"        }"},{"line_number":397,"context_line":"        msg(D_HANDSHAKE, \"VERIFY X509NAME OK: %s\", subject);"},{"line_number":398,"context_line":"    }"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    return SUCCESS;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b73b8520_97809e57","line":397,"in_reply_to":"9a8f2a69_b9100741","updated":"2026-04-13 17:23:52.000000000","message":"Here is my thought on this:\nOn success, its just a gratuitous message and its not confusing. We are just printing what the subject (DN) of the certificate is.\nOn error, its a critical message that says what was expected and what was found. The current code tries to match something and prints something else.","commit_id":"b66690602ee8f2b6f3b618efe1d8fc4b999a682f"}]}