)]}'
{"id":"openvpn~1628","triplet_id":"openvpn~master~I33e55d88d561393ebfbc73a995f700056e19a436","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-24 17:56:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-10-18 19:58:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I33e55d88d561393ebfbc73a995f700056e19a436","subject":"sitnl: use RTM_SETLINK for updating existing interfaces","status":"MERGED","created":"2026-04-15 15:34:59.000000000","updated":"2026-10-18 19:58:06.000000000","submitted":"2026-10-18 19:58:06.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1628","meta_rev_id":"99cb76928e447b479e89ebbb0f9c4833479a49b5","_number":1628,"virtual_id_number":1628,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-15 15:35:00.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-15 15:35:00.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"282081cf67774c829da615cdf67146ed26d211a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-04-15 15:34:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93853369579f56ff60aeea5ac10eab96f0b4a1a2","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-24 17:56:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"99cb76928e447b479e89ebbb0f9c4833479a49b5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-10-18 19:58:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8f3f66f79264acbd13d539bdcec1c12e24e2e7f7","revisions":{"a55090551b9dca2e6a88e81893204ec66df9f1ba":{"kind":"REWORK","_number":1,"created":"2026-04-15 15:34:59.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/28/1628/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/1628/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1 \u0026\u0026 git checkout -b change-1628 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"25c5c42ac265c4731c0e44c0afd773dc89bf22da","subject":"Add unit tests for \u0027auth-user-pass username-only\u0027"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-04-15 15:22:49.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-04-15 15:34:52.000000000","tz":120},"subject":"sitnl: use RTM_SETLINK for updating existing interfaces","message":"sitnl: use RTM_SETLINK for updating existing interfaces\n\nRTM_NEWLINK is primarily intended for link creation and initialization,\nwhile RTM_SETLINK is the canonical interface for modifying attributes of\nan already existing link.\n\nEven though the kernel may accept RTM_NEWLINK for updates, using\nRTM_SETLINK better reflects the intended netlink semantics and follows\nthe dedicated update path in the kernel.\n\nThis makes the behavior more explicit and consistent with how link\nconfiguration changes are expected to be performed.\n\nChange-Id: I33e55d88d561393ebfbc73a995f700056e19a436\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8f3f66f79264acbd13d539bdcec1c12e24e2e7f7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-10-18 19:58:06.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/28/1628/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/1628/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2 \u0026\u0026 git checkout -b change-1628 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/1628/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84cdfa106d3217526f73782e992a55297a1966c0","subject":"Remove support for pkcs11-helper \u003c 1.28"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-10-11 20:24:34.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-10-18 16:10:19.000000000","tz":120},"subject":"sitnl: use RTM_SETLINK for updating existing interfaces","message":"sitnl: use RTM_SETLINK for updating existing interfaces\n\nRTM_NEWLINK is primarily intended for link creation and initialization,\nwhile RTM_SETLINK is the canonical interface for modifying attributes of\nan already existing link.\n\nEven though the kernel may accept RTM_NEWLINK for updates, using\nRTM_SETLINK better reflects the intended netlink semantics and follows\nthe dedicated update path in the kernel.\n\nThis makes the behavior more explicit and consistent with how link\nconfiguration changes are expected to be performed.\n\nChange-Id: I33e55d88d561393ebfbc73a995f700056e19a436\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1628\nMessage-Id: \u003c20261011202439.15128-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39831.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}