)]}'
{"id":"openvpn~1632","triplet_id":"openvpn~release%2F2.6~I92c5f74a27b40fede204f714b042a6cc80b3703e","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-21 14:22:03.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-04-21 14:22:03.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I92c5f74a27b40fede204f714b042a6cc80b3703e","subject":"dco: backport immediate notification processing on Linux and FreeBSD","status":"MERGED","created":"2026-04-20 16:15:47.000000000","updated":"2026-04-21 14:22:03.000000000","submitted":"2026-04-21 14:22:03.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1632","meta_rev_id":"b69e7d13bf1ee6bfb9efb6c9b3be5da5ba3797de","_number":1632,"virtual_id_number":1632,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-20 16:15:47.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-20 16:15:47.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-21 08:48:34.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f0f66e2a4fdc5296c0fa7b166d3833933a8fa70d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-04-20 16:15:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad1e98ab0cc8498186974b1d48ff112ef5c58f0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-04-20 16:29:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d28fed671cf97b8608ab2ef4716cb6cdf330b97b","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-21 08:48:34.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b69e7d13bf1ee6bfb9efb6c9b3be5da5ba3797de","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-21 14:22:03.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e78a8af2f5ce5ef3bbfefc2dc8efeca84027c018","revisions":{"f3842baf19e7cbfd28e5d609d391227536bbd93e":{"kind":"REWORK","_number":1,"created":"2026-04-20 16:15:47.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/32/1632/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1632/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1 \u0026\u0026 git checkout -b change-1632 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a03fbb7ebf9adfdd0cf6714567c557fdbf9e4d4","subject":"dco: port core/context infrastructure needed for backport of commit 7791f53"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-20 15:53:50.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-20 16:04:27.000000000","tz":120},"subject":"dco: backport immediate notification processing on Linux and FreeBSD","message":"dco: backport immediate notification processing on Linux and FreeBSD\n\nBackport the immediate DCO message processing model from commit 7791f53\n(\"dco: process messages immediately after read\").\n\nChange the core DCO API from dco_do_read() to dco_read_and_process(),\nand make the backend read paths own the parsing and immediate handling\nof kernel notifications before handing the resulting state to\nprocess_incoming_dco() or multi_process_incoming_dco().\n\nOn Linux, install a permanent netlink callback and process GET_PEER and\nDEL_PEER messages as they are received, instead of switching callbacks\nfor each read and deferring handling through shared DCO message state.\nAlso add a small guard to avoid requesting peer stats while libnl is\nstill parsing a batch of notifications.\n\nOn FreeBSD, move notification handling into dco_read_and_process() and\nupdate peer statistics directly from the backend instead of storing\ntemporary byte counters in dco_context_t.\n\nThis commit is part of a reworked backport of PR #945 originally\nproposed by Nikolai Shelekhov \u003cnickshv13@icloud.com\u003e.\n\nChange-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/release/2.6"},"6f1bff9763ccab4e1a2eaa1a03a84ee796cb9e72":{"kind":"REWORK","_number":2,"created":"2026-04-20 16:29:10.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/32/1632/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1632/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2 \u0026\u0026 git checkout -b change-1632 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a03fbb7ebf9adfdd0cf6714567c557fdbf9e4d4","subject":"dco: port core/context infrastructure needed for backport of commit 7791f53"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-20 15:53:50.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-20 16:28:58.000000000","tz":120},"subject":"dco: backport immediate notification processing on Linux and FreeBSD","message":"dco: backport immediate notification processing on Linux and FreeBSD\n\nBackport the immediate DCO message processing model from commit 7791f53\n(\"dco: process messages immediately after read\").\n\nChange the core DCO API from dco_do_read() to dco_read_and_process(),\nand make the backend read paths own the parsing and immediate handling\nof kernel notifications before handing the resulting state to\nprocess_incoming_dco() or multi_process_incoming_dco().\n\nOn Linux, install a permanent netlink callback and process GET_PEER and\nDEL_PEER messages as they are received, instead of switching callbacks\nfor each read and deferring handling through shared DCO message state.\nAlso add a small guard to avoid requesting peer stats while libnl is\nstill parsing a batch of notifications.\n\nOn FreeBSD, move notification handling into dco_read_and_process() and\nupdate peer statistics directly from the backend instead of storing\ntemporary byte counters in dco_context_t.\n\nThis commit is part of a reworked backport of PR #945 originally\nproposed by Nikolai Shelekhov \u003cnickshv13@icloud.com\u003e.\n\nChange-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/release/2.6"},"e78a8af2f5ce5ef3bbfefc2dc8efeca84027c018":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-04-21 14:22:03.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/32/1632/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/1632/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3 \u0026\u0026 git checkout -b change-1632 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/1632/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"876a8cf5fd6166a22bfe6b6f37889d3cff3a17c6","subject":"dco: port core/context infrastructure needed for backport of commit 7791f53"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-21 08:49:01.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-21 13:31:10.000000000","tz":120},"subject":"dco: backport immediate notification processing on Linux and FreeBSD","message":"dco: backport immediate notification processing on Linux and FreeBSD\n\nBackport the immediate DCO message processing model from commit 7791f53\n(\"dco: process messages immediately after read\").\n\nChange the core DCO API from dco_do_read() to dco_read_and_process(),\nand make the backend read paths own the parsing and immediate handling\nof kernel notifications before handing the resulting state to\nprocess_incoming_dco() or multi_process_incoming_dco().\n\nOn Linux, install a permanent netlink callback and process GET_PEER and\nDEL_PEER messages as they are received, instead of switching callbacks\nfor each read and deferring handling through shared DCO message state.\nAlso add a small guard to avoid requesting peer stats while libnl is\nstill parsing a batch of notifications.\n\nOn FreeBSD, move notification handling into dco_read_and_process() and\nupdate peer statistics directly from the backend instead of storing\ntemporary byte counters in dco_context_t.\n\nThis commit is part of a reworked backport of PR #945 originally\nproposed by Nikolai Shelekhov \u003cnickshv13@icloud.com\u003e.\n\nGithub: OpenVPN/openvpn#900\nGithub: OpenVPN/openvpn#918\nGithub: OpenVPN/openvpn#931\nGithub: fixes OpenVPN/openvpn#919\nGithub: closes OpenVPN/openvpn#945\n\nChange-Id: I92c5f74a27b40fede204f714b042a6cc80b3703e\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1632\nMessage-Id: \u003c20260421084906.5720-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36707.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
