)]}'
{"id":"openvpn~1633","triplet_id":"openvpn~master~Ica5f37e525c3812609021750ecd3986c1420e2a4","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-20 23:49:38.000000000","reason":"removed on reply"},"1000030":{"account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2026-04-27 14:48:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ica5f37e525c3812609021750ecd3986c1420e2a4","subject":"Mbed TLS: Error out if we have no valid tls-groups","status":"MERGED","created":"2026-04-20 20:51:44.000000000","updated":"2026-04-27 14:48:49.000000000","submitted":"2026-04-27 14:48:49.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1633","meta_rev_id":"086997eb29e077673bb0761bb22fbda36a351f11","_number":1633,"virtual_id_number":1633,"owner":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-20 20:51:45.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-20 20:51:45.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"f84539785625ff3c90d85c9ff34bc69dba44cab5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-04-20 20:51:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"191b466241c4e2fb706065b1ae7deb9a4478af65","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-04-20 23:49:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"086997eb29e077673bb0761bb22fbda36a351f11","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-27 14:48:49.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b2e3e0f0cf21a712b96efb8c053b740ca1947f54","revisions":{"d8fbc7ff90347a8f5b75bd92444cec23203da383":{"kind":"REWORK","_number":1,"created":"2026-04-20 20:51:44.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/33/1633/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1633/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1 \u0026\u0026 git checkout -b change-1633 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f870c0753eccece035f682f8ae43f082e9af805","subject":"dns: Change arguments to setenv_dns_option to avoid sign-compare warning"}],"author":{"name":"Max Fillinger","email":"maximilian.fillinger@sentyron.com","date":"2026-04-20 15:30:34.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2026-04-20 20:50:45.000000000","tz":120},"subject":"Mbed TLS: Error out if we have no valid tls-groups","message":"Mbed TLS: Error out if we have no valid tls-groups\n\nPreviously, when no valid groups were specified with the tls-groups\noption, the Mbed TLS build of OpenVPN would start up and run, but fail\nto complete a handshake, while the OpenSSL build would exit with an\nerror. This commit changes the behavior of the Mbed TLS build to match\nthe OpenSSL version.\n\nChange-Id: Ica5f37e525c3812609021750ecd3986c1420e2a4\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@sentyron.com\u003e\n"},"branch":"refs/heads/master"},"b2e3e0f0cf21a712b96efb8c053b740ca1947f54":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-04-27 14:48:49.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/33/1633/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1633/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2 \u0026\u0026 git checkout -b change-1633 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1633/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9ac9a41b82aecdb5cb17a3746a7fa50878ec7ee0","subject":"Fixup: prompting password from management"}],"author":{"name":"Max Fillinger","email":"maximilian.fillinger@sentyron.com","date":"2026-04-21 05:53:50.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-27 10:41:13.000000000","tz":120},"subject":"Mbed TLS: Error out if we have no valid tls-groups","message":"Mbed TLS: Error out if we have no valid tls-groups\n\nPreviously, when no valid groups were specified with the tls-groups\noption, the Mbed TLS build of OpenVPN would start up and run, but fail\nto complete a handshake, while the OpenSSL build would exit with an\nerror. This commit changes the behavior of the Mbed TLS build to match\nthe OpenSSL version.\n\nChange-Id: Ica5f37e525c3812609021750ecd3986c1420e2a4\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@sentyron.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1633\nMessage-Id: \u003c20260421055357.21708-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36699.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
