)]}'
{"src/openvpn/ssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f77f0c4e950cc00a6af5b29fd7fcd7c728d99d75","unresolved":true,"context_lines":[{"line_number":1948,"context_line":"        if (session-\u003eopt-\u003epull)"},{"line_number":1949,"context_line":"        {"},{"line_number":1950,"context_line":"            /* legacy support for Negotiable Crypto Parameters (deprecated in favour"},{"line_number":1951,"context_line":"             * of IV_CIPHERS */"},{"line_number":1952,"context_line":"            if (tls_item_in_cipher_list(\"AES-128-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers)"},{"line_number":1953,"context_line":"                \u0026\u0026 tls_item_in_cipher_list(\"AES-256-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers))"},{"line_number":1954,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6508d17c_46eba2f4","line":1951,"updated":"2026-06-22 13:21:42.000000000","message":"missing closing parenthesis","commit_id":"fa38630d2e74ea82f40f4bd96758f3b9a7a971c5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff21927a45d3bc8dde2c4d2f4ce7bde78a5b2996","unresolved":false,"context_lines":[{"line_number":1948,"context_line":"        if (session-\u003eopt-\u003epull)"},{"line_number":1949,"context_line":"        {"},{"line_number":1950,"context_line":"            /* legacy support for Negotiable Crypto Parameters (deprecated in favour"},{"line_number":1951,"context_line":"             * of IV_CIPHERS */"},{"line_number":1952,"context_line":"            if (tls_item_in_cipher_list(\"AES-128-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers)"},{"line_number":1953,"context_line":"                \u0026\u0026 tls_item_in_cipher_list(\"AES-256-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers))"},{"line_number":1954,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f68afcba_f0324f2d","line":1951,"in_reply_to":"6508d17c_46eba2f4","updated":"2026-06-22 14:24:54.000000000","message":"Done","commit_id":"fa38630d2e74ea82f40f4bd96758f3b9a7a971c5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f77f0c4e950cc00a6af5b29fd7fcd7c728d99d75","unresolved":true,"context_lines":[{"line_number":1957,"context_line":"        }"},{"line_number":1958,"context_line":"        else"},{"line_number":1959,"context_line":"        {"},{"line_number":1960,"context_line":"            /* We are not using pull or p2mp server, instead do P2P NCP */"},{"line_number":1961,"context_line":"            iv_proto |\u003d IV_PROTO_NCP_P2P;"},{"line_number":1962,"context_line":"        }"},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f3ccea45_937a2361","line":1960,"updated":"2026-06-22 13:21:42.000000000","message":"comment is now out-of-sync with code","commit_id":"fa38630d2e74ea82f40f4bd96758f3b9a7a971c5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff21927a45d3bc8dde2c4d2f4ce7bde78a5b2996","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"        }"},{"line_number":1958,"context_line":"        else"},{"line_number":1959,"context_line":"        {"},{"line_number":1960,"context_line":"            /* We are not using pull or p2mp server, instead do P2P NCP */"},{"line_number":1961,"context_line":"            iv_proto |\u003d IV_PROTO_NCP_P2P;"},{"line_number":1962,"context_line":"        }"},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c67440a8_2d6c4410","line":1960,"in_reply_to":"f3ccea45_937a2361","updated":"2026-06-22 14:24:54.000000000","message":"Done","commit_id":"fa38630d2e74ea82f40f4bd96758f3b9a7a971c5"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d44147658293813b77f5ba6f8cc27ee0db117021","unresolved":true,"context_lines":[{"line_number":1994,"context_line":""},{"line_number":1995,"context_line":"        /* support for Negotiable Crypto Parameters */"},{"line_number":1996,"context_line":"        if (session-\u003eopt-\u003emode \u003d\u003d MODE_SERVER || session-\u003eopt-\u003epull)"},{"line_number":1997,"context_line":"        {"},{"line_number":1998,"context_line":"            if (tls_item_in_cipher_list(\"AES-128-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers)"},{"line_number":1999,"context_line":"                \u0026\u0026 tls_item_in_cipher_list(\"AES-256-GCM\", session-\u003eopt-\u003econfig_ncp_ciphers))"},{"line_number":2000,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"60cdb326_0f4bce27","side":"PARENT","line":1997,"updated":"2026-07-15 14:57:07.000000000","message":"NAK on that change, because it would lead to a setup with `--server` + `--push-peer-info` send out IV_PROTO_NCP_P2P... so the `MODE_SERVER` check is needed.  Unlikely scenario, but possible...","commit_id":"71a6b89896a36a08adac3b61bcccd949bcf149c1"}]}