)]}'
{"id":"openvpn~1636","triplet_id":"openvpn~release%2F2.6~I9b1f4fd06c8a02d3f51b6a3bdea2f92191669660","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-22 07:04:59.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-04-22 07:04:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9b1f4fd06c8a02d3f51b6a3bdea2f92191669660","subject":"dco-linux: enforce ifindex only for DEL_PEER notifications","status":"MERGED","created":"2026-04-21 20:35:04.000000000","updated":"2026-04-22 07:04:59.000000000","submitted":"2026-04-22 07:04:59.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1636","meta_rev_id":"2ddecfe4811f592fc229523e11ff954ee2d7931d","_number":1636,"virtual_id_number":1636,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-21 20:35:05.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-21 20:35:05.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-22 05:56:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"8e50743aeb7b9b0b43d1f797cf3c032030a1ccf2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-04-21 20:35:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c92d22b0876048610a9d52cbfc59bdab53e090b2","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-22 05:56:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2ddecfe4811f592fc229523e11ff954ee2d7931d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-22 07:04:59.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"adece45628f78aa8f1f997850095bc9a57caefbe","revisions":{"ad639fc0fcfd219482130d6ef2b99000abb55c16":{"kind":"REWORK","_number":1,"created":"2026-04-21 20:35:04.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/36/1636/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1636/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1 \u0026\u0026 git checkout -b change-1636 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e78a8af2f5ce5ef3bbfefc2dc8efeca84027c018","subject":"dco: backport immediate notification processing on Linux and FreeBSD"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-21 20:19:08.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-21 20:32:07.000000000","tz":120},"subject":"dco-linux: enforce ifindex only for DEL_PEER notifications","message":"dco-linux: enforce ifindex only for DEL_PEER notifications\n\nThe unconditional ifindex check introduced by commit e78a8af2f5ce\nrejects legitimate kernel replies, specifically peer stats responses,\nbecause those messages do not carry OVPN_ATTR_IFINDEX.\n\nMove the check into ovpn_handle_del_peer() so it applies only to\nspontaneous DEL_PEER notifications from the kernel. This keeps\nresponse handling working while still filtering foreign-instance\nnotifications.\n\nFixes: e78a8af2f5ce (\"dco: backport immediate notification processing on Linux and FreeBSD\")\nGithub: closes OpenVPN/openvpn#1020\nChange-Id: I9b1f4fd06c8a02d3f51b6a3bdea2f92191669660\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/release/2.6"},"adece45628f78aa8f1f997850095bc9a57caefbe":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-04-22 07:04:59.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/36/1636/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1636/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2 \u0026\u0026 git checkout -b change-1636 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1636/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e78a8af2f5ce5ef3bbfefc2dc8efeca84027c018","subject":"dco: backport immediate notification processing on Linux and FreeBSD"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-04-22 05:56:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-22 06:49:20.000000000","tz":120},"subject":"dco-linux: enforce ifindex only for DEL_PEER notifications","message":"dco-linux: enforce ifindex only for DEL_PEER notifications\n\nThe unconditional ifindex check introduced by commit e78a8af2f5ce\nrejects legitimate kernel replies, specifically peer stats responses,\nbecause those messages do not carry OVPN_ATTR_IFINDEX.\n\nMove the check into ovpn_handle_del_peer() so it applies only to\nspontaneous DEL_PEER notifications from the kernel. This keeps\nresponse handling working while still filtering foreign-instance\nnotifications.\n\nFixes: e78a8af2f5ce (\"dco: backport immediate notification processing on Linux and FreeBSD\")\nGithub: closes OpenVPN/openvpn#1020\nChange-Id: I9b1f4fd06c8a02d3f51b6a3bdea2f92191669660\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1636\nMessage-Id: \u003c20260422055636.20691-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36721.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}