)]}'
{"id":"openvpn~1638","triplet_id":"openvpn~master~I4d46c3672691b159cbd98a17020c4f30782bc202","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-25 20:31:24.000000000","reason":"Change was submitted"},"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2026-04-25 20:31:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4d46c3672691b159cbd98a17020c4f30782bc202","subject":"Fixup: prompting password from management","status":"MERGED","created":"2026-04-23 00:12:26.000000000","updated":"2026-04-25 20:31:24.000000000","submitted":"2026-04-25 20:31:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1638","meta_rev_id":"acc53690c3c5937715c21504e771a009b06e7e29","_number":1638,"virtual_id_number":1638,"owner":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-23 00:12:26.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-23 00:12:26.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-04-24 16:18:18.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"cfc8ece58bdaaf1861822ccb800835747b6b7a38","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-04-23 00:12:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0c49dc367335284bd303be4441f4b11ebdef6f5","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-24 16:18:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"acc53690c3c5937715c21504e771a009b06e7e29","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-04-25 20:31:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9ac9a41b82aecdb5cb17a3746a7fa50878ec7ee0","revisions":{"461dc388d87bb53742a8fa2544c4ccaf73c1c2b5":{"kind":"REWORK","_number":1,"created":"2026-04-23 00:12:26.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/38/1638/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1638/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1 \u0026\u0026 git checkout -b change-1638 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64fae9d82989ede6c92e230c594ab9335c05df8d","subject":"Ensure that buffer of freed session are not used"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-23 00:04:31.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-23 00:11:52.000000000","tz":-240},"subject":"Fixup: prompting password from management","message":"Fixup: prompting password from management\n\nCommit b450414 added logic for reading password from management\nwhen not in file or inline, but it was made conditional on\n`response_from_stdin` which is always true! Fix by explicitly\nchecking for `password_from_stdin`.\n\nChange-Id: I4d46c3672691b159cbd98a17020c4f30782bc202\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"9ac9a41b82aecdb5cb17a3746a7fa50878ec7ee0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-04-25 20:31:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/38/1638/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/1638/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2 \u0026\u0026 git checkout -b change-1638 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/38/1638/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64fae9d82989ede6c92e230c594ab9335c05df8d","subject":"Ensure that buffer of freed session are not used"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-24 16:18:33.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-04-25 17:30:50.000000000","tz":120},"subject":"Fixup: prompting password from management","message":"Fixup: prompting password from management\n\nCommit b450414 added logic for reading password from management\nwhen not in file or inline, but it was made conditional on\n`response_from_stdin` which is always true! Fix by explicitly\nchecking for `password_from_stdin`.\n\nGithub: fixes OpenVPN/openvpn#1021\n\nChange-Id: I4d46c3672691b159cbd98a17020c4f30782bc202\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638\nMessage-Id: \u003c20260424161840.5767-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36739.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
