)]}'
{"id":"openvpn~1639","triplet_id":"openvpn~master~I9433baee1f5a66d43d4e43e03128ae6a790a7937","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-04-27 20:52:02.000000000","reason":"Vote got outdated and was removed: Code-Review+1"}},"removed_from_attention_set":{"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2026-04-27 20:14:31.000000000","reason":"\u003cGERRIT_ACCOUNT_1000009\u003e replied on the change","reason_account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}}},"hashtags":[],"change_id":"I9433baee1f5a66d43d4e43e03128ae6a790a7937","subject":"Avoid recursive call of man_read","status":"NEW","created":"2026-04-27 17:33:23.000000000","updated":"2026-04-27 20:56:36.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f3fed4bb9e7c1c60b6b05c0d4eddec6190d865ab","_number":1639,"virtual_id_number":1639,"owner":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-27 17:33:23.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-04-27 17:33:23.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"7b30178ba83caf76720e429148111d0db38f44ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-04-27 17:33:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ecde18e93a4948b7d7f93c9d5c4084f28c8e160e","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-04-27 19:27:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"84d7cc928177fef1244a39ec724dff6ea49cd1aa","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-04-27 20:14:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e190ce58c0a0e5dc666897a5a99644a4b0aea17c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-04-27 20:52:02.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f3fed4bb9e7c1c60b6b05c0d4eddec6190d865ab","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-04-27 20:56:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8180b7b0fda4b2dbd8589fcc9cb7cbf311aa74ad","revisions":{"4b071fccd9a45b9019533707f3e0ccafd0b4d3e6":{"kind":"REWORK","_number":1,"created":"2026-04-27 17:33:23.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/39/1639/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/39/1639/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1 \u0026\u0026 git checkout -b change-1639 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2e3e0f0cf21a712b96efb8c053b740ca1947f54","subject":"Mbed TLS: Error out if we have no valid tls-groups"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-27 16:50:10.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-27 17:30:13.000000000","tz":-240},"subject":"Avoid recursive call of man_read","message":"Avoid recursive call of man_read\n\nRecursion to `man_read()` happens on Windows when `man_process_command`\ntries to log the received command because `management_io`\nfirst checks FD_READ and calls `man_read()` again if there is data is\npending in the receive buffer. This is buggy as `man_read()` is not\ndesigned to be re-entrant.\n\nFix this by disallowing recursion -- just return 0 so that managament_io\nwill complete without recursion. Although this will also clear\nFD_READ from the event mask via\n    `net_event_win32_clear_selected_events(\u0026man-\u003econnection.ne32, FD_READ)`\n(manage.c:3312), read will get serviced next time when the main event loop\ncalls `management_io` thorugh `process_io`.  Note that `management_io`\nalways calls `reset_net_event_win32()` (manage.c: 3298) which will pickup\nif any data to read is pending (win32.c: 357) as FD_READ is level triggered.\n\nGiithub: Fixes OpenVPN/openvpn#1023\n\nChange-Id: I9433baee1f5a66d43d4e43e03128ae6a790a7937\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"8180b7b0fda4b2dbd8589fcc9cb7cbf311aa74ad":{"kind":"REWORK","_number":2,"created":"2026-04-27 20:52:02.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/39/1639/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/39/1639/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2 \u0026\u0026 git checkout -b change-1639 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/39/1639/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2e3e0f0cf21a712b96efb8c053b740ca1947f54","subject":"Mbed TLS: Error out if we have no valid tls-groups"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-27 16:50:10.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-04-27 20:48:13.000000000","tz":-240},"subject":"Avoid recursive call of man_read","message":"Avoid recursive call of man_read\n\nRecursion to `man_read()` happens on Windows when `man_process_command`\ntries to log the received command because `management_io`\nfirst checks FD_READ and calls `man_read()` again if there is data is\npending in the receive buffer. This is buggy as `man_read()` is not\ndesigned to be re-entrant.\n\nFix this by disallowing recursion -- just return 0 so that managament_io\nwill complete without recursion. Check this condition and do not clear\nFD_READ from the event mask in management_io when man_read returns\nwithout calling recv(). Read will get serviced next time when the main event loop\ncalls `management_io` thorugh `process_io`.  Note that `management_io`\nalways calls `reset_net_event_win32()` (manage.c: 3298) which will pickup\nif any new data to read is pending (win32.c: 357) as well as retain FD_READ if\nalready set.\n\nGiithub: Fixes OpenVPN/openvpn#1023\n\nChange-Id: I9433baee1f5a66d43d4e43e03128ae6a790a7937\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}