)]}'
{"id":"openvpn~1661","triplet_id":"openvpn~master~I2b71dae37ebe63c26a66761f877b25d326ed140f","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-05 20:40:02.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I2b71dae37ebe63c26a66761f877b25d326ed140f","subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","status":"NEW","created":"2026-05-05 20:40:01.000000000","updated":"2026-05-11 17:44:40.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d5cc6d65cfa01c9508907a50c2d406bff392eaed","_number":1661,"virtual_id_number":1661,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-05 20:40:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-05 20:40:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c3cf68cf82a234c1789edc2668122c6baa8a613f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-05 20:40:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"450c9bebdf4ef0f85e001bf8ea9c3394c948c231","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-05 21:02:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"88bcf6c416629e855d2ca819d05a726b36db1409","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-06 21:20:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f783c1537c0ac5762c4eba72823deff952bf0240","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d5cc6d65cfa01c9508907a50c2d406bff392eaed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f8c7692cb33579ebcbc0a06149fbb0df65a47e50","revisions":{"825bcfa362a20427ef8622daee59cb5b259a34ae":{"kind":"REWORK","_number":1,"created":"2026-05-05 20:40:01.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/61/1661/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/1661/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1 \u0026\u0026 git checkout -b change-1661 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18577f4793c75549221a94af89c69ec14342dfb7","subject":"Rename variables that shadow other variables or functions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","message":"Remove instances of constVariable/constVariablePointer cppcheck warnings\n\nOf varied usefulness, but easier to just address all of\nthem.\n\nChange-Id: I2b71dae37ebe63c26a66761f877b25d326ed140f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5f8fd045b6ea4d6dcb429aa5566a45efe2ab63aa":{"kind":"REWORK","_number":2,"created":"2026-05-05 21:02:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/61/1661/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/1661/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2 \u0026\u0026 git checkout -b change-1661 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18577f4793c75549221a94af89c69ec14342dfb7","subject":"Rename variables that shadow other variables or functions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-05 20:59:51.000000000","tz":120},"subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","message":"Remove instances of constVariable/constVariablePointer cppcheck warnings\n\nOf varied usefulness, but easier to just address all of\nthem.\n\nAlso change vpn_* parameters of dco_new_peer to const since\nthat is required by one of the changes and it works (and would\nhappen anyway when doing constParameterPointer).\n\nChange-Id: I2b71dae37ebe63c26a66761f877b25d326ed140f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"92f553f4b19088335d32ea82799dd4859311bcc6":{"kind":"REWORK","_number":3,"created":"2026-05-06 21:20:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/61/1661/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/1661/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3 \u0026\u0026 git checkout -b change-1661 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15ae1e0762695966181fc3ed6473dd4be8dc0641","subject":"Rename variables that shadow other variables or functions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 21:20:38.000000000","tz":120},"subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","message":"Remove instances of constVariable/constVariablePointer cppcheck warnings\n\nOf varied usefulness, but easier to just address all of\nthem.\n\nAlso change vpn_* parameters of dco_new_peer to const since\nthat is required by one of the changes and it works (and would\nhappen anyway when doing constParameterPointer).\n\nChange-Id: I2b71dae37ebe63c26a66761f877b25d326ed140f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"82a3723f42f2ce1079533e97be3db340ef274775":{"kind":"REWORK","_number":4,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/61/1661/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/1661/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4 \u0026\u0026 git checkout -b change-1661 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cac915b1fdc013e3d820946729c3b3e479aa9a7a","subject":"tun: Remove one useless if check"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:26:39.000000000","tz":120},"subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","message":"Remove instances of constVariable/constVariablePointer cppcheck warnings\n\nOf varied usefulness, but easier to just address all of\nthem.\n\nAlso change vpn_* parameters of dco_new_peer to const since\nthat is required by one of the changes and it works (and would\nhappen anyway when doing constParameterPointer).\n\nChange-Id: I2b71dae37ebe63c26a66761f877b25d326ed140f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f8c7692cb33579ebcbc0a06149fbb0df65a47e50":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/61/1661/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/1661/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5 \u0026\u0026 git checkout -b change-1661 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/1661/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c81f5a674d051b5e5d2d31be10cc1fe2134c11ae","subject":"pool: Fix a potential NULL pointer de-reference in test code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-04 15:25:22.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"Remove instances of constVariable/constVariablePointer cppcheck warnings","message":"Remove instances of constVariable/constVariablePointer cppcheck warnings\n\nOf varied usefulness, but easier to just address all of\nthem.\n\nAlso change vpn_* parameters of dco_new_peer to const since\nthat is required by one of the changes and it works (and would\nhappen anyway when doing constParameterPointer).\n\nChange-Id: I2b71dae37ebe63c26a66761f877b25d326ed140f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}