)]}'
{"id":"openvpn~1665","triplet_id":"openvpn~master~I05720ccc3bcf706bbe62254afb74562580f5de56","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-08 11:47:59.000000000","reason":"Change was marked ready for review"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I05720ccc3bcf706bbe62254afb74562580f5de56","subject":"dev-tools: Fix run-cppcheck to cover more code","status":"NEW","created":"2026-05-06 21:20:59.000000000","updated":"2026-05-11 17:44:40.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"07fba7ef7fd3b003d30536c93c8195250b9b8fb2","_number":1665,"virtual_id_number":1665,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"14aebd05fb15b7bc1947ac6c51c6db5eb98dad86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-06 21:20:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1333a9cc16a5bbbdccee5fe1dafe800e049f7ddd","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-07 10:05:28.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"80e42119bd624975c6df88eaf7a0d3dbdd0d862b","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c14da3a288b0135f854a2cb35486d3a708ee9a0d","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:47:59.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"07fba7ef7fd3b003d30536c93c8195250b9b8fb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"15a4dbc014c02950312b9e89a1dea3089169a308","revisions":{"9aa25063038fea77814903cbdf294f8e0bffa4a1":{"kind":"REWORK","_number":1,"created":"2026-05-06 21:20:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/65/1665/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/1665/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1 \u0026\u0026 git checkout -b change-1665 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"841ab0b216a424eb0100448362f76a2c12b3a516","subject":"t_client.sh: Do not use CA_CERT variable as indicator for good .rc file"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 13:54:04.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 21:20:38.000000000","tz":120},"subject":"dev-tools: Fix run-cppcheck to cover more code","message":"dev-tools: Fix run-cppcheck to cover more code\n\nWhen specifying any -D argument all other defines\nare ignored unless --force is specified as well.\nI mistakenly assumed that this was covered by\n--check-level\u003dexhaustive.\n\nChange-Id: I05720ccc3bcf706bbe62254afb74562580f5de56\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a857400c0a9eac0042a9597567a24e03ae0360bf":{"kind":"REWORK","_number":2,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/65/1665/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/1665/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2 \u0026\u0026 git checkout -b change-1665 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74d39dfba2aa8d94110467788dfb9160fc739fad","subject":"sample: Fix cppcheck error invalidPrintfArgType_sint"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 13:54:04.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:24:10.000000000","tz":120},"subject":"dev-tools: Fix run-cppcheck to cover more code","message":"dev-tools: Fix run-cppcheck to cover more code\n\nMassively improve how we call cppcheck to cover\nmore code and identify more issues.\n\nWhen specifying any -D argument all other defines\nare ignored unless --force or --max-configs is\nspecified as well. I mistakenly assumed that this\nwas covered by --check-level\u003dexhaustive. We need\nto try finding a value for --max-configs so that\ncppcheck doesn\u0027t spend hours scanning options.c\n\nAdd a library cfg for our code which for now\n- identifies some printf-style functions\n- adds some common macro defines\n\nUse existing libraries.\n\nAdd a second call to cppcheck to separate the\nWindows and Unixy code scans. This avoids some\nvery non-sensical define combinations.\n\nChange-Id: I05720ccc3bcf706bbe62254afb74562580f5de56\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"15a4dbc014c02950312b9e89a1dea3089169a308":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/65/1665/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/1665/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3 \u0026\u0026 git checkout -b change-1665 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/65/1665/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1400926adada824973a3df001fdcc46f523d90ee","subject":"tun: Remove one useless if check"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 13:54:04.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"dev-tools: Fix run-cppcheck to cover more code","message":"dev-tools: Fix run-cppcheck to cover more code\n\nMassively improve how we call cppcheck to cover\nmore code and identify more issues.\n\nWhen specifying any -D argument all other defines\nare ignored unless --force or --max-configs is\nspecified as well. I mistakenly assumed that this\nwas covered by --check-level\u003dexhaustive. We need\nto try finding a value for --max-configs so that\ncppcheck doesn\u0027t spend hours scanning options.c\n\nAdd a library cfg for our code which for now\n- identifies some printf-style functions\n- adds some common macro defines\n\nUse existing libraries.\n\nAdd a second call to cppcheck to separate the\nWindows and Unixy code scans. This avoids some\nvery non-sensical define combinations.\n\nChange-Id: I05720ccc3bcf706bbe62254afb74562580f5de56\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}