)]}'
{"id":"openvpn~1667","triplet_id":"openvpn~master~If58bb807842b7b95aeffe6849e7a7344e4925762","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-13 11:11:06.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-13 11:11:06.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If58bb807842b7b95aeffe6849e7a7344e4925762","subject":"multi: Remove useless checks","status":"MERGED","created":"2026-05-06 21:20:59.000000000","updated":"2026-05-13 11:11:06.000000000","submitted":"2026-05-13 11:11:06.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1667-cppcheck","meta_rev_id":"ab87029a7ce6c91bf603154765bd8eddad90e347","_number":1667,"virtual_id_number":1667,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-13 09:16:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"74d73253740846b88f138393af7e07c261f08934","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-06 21:20:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b7c4c1a56e3a3f28f5d18bc11660b699b9449b72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"e1b51d2ed0e8dacf5e808cfaa2d2a007e09b4f22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"c4ed40d07999b694a97c968ed51b81714840fafc","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-13 09:16:55.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ab87029a7ce6c91bf603154765bd8eddad90e347","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-13 11:11:06.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9922d2c3f397944625b99afe984563cb2d9a0456","revisions":{"7e772bd3112310e7e38b276f9b149e75ff95e23c":{"kind":"REWORK","_number":1,"created":"2026-05-06 21:20:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/1667/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/1667/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1 \u0026\u0026 git checkout -b change-1667 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f0e816422335ebaaf647611b8421d89399dd1ab9","subject":"buffer: Fix some issues with -DVERIFY_ALIGNMENT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:41:01.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 21:20:38.000000000","tz":120},"subject":"multi: Remove useless checks","message":"multi: Remove useless checks\n\nIf mi is NULL, the previous code lines already\nsegfaulted.\n\nIdentified by cppcheck.\n\nChange-Id: If58bb807842b7b95aeffe6849e7a7344e4925762\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4f71ea6b0bf42f83dd52c06fd99b952388c13169":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/1667/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/1667/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2 \u0026\u0026 git checkout -b change-1667 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3ba88ba851b1e8ad038ac7ee9895c84d73385d6","subject":"buffer: Fix some issues with -DVERIFY_ALIGNMENT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:41:01.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:24:13.000000000","tz":120},"subject":"multi: Remove useless checks","message":"multi: Remove useless checks\n\nIf mi is NULL, the previous code lines already\nsegfaulted.\n\nIdentified by cppcheck.\n\nChange-Id: If58bb807842b7b95aeffe6849e7a7344e4925762\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"872679a9c1e00a165d07a41d6f90092ab74f89f6":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/1667/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/1667/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3 \u0026\u0026 git checkout -b change-1667 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3b30a82bb5e82a8f6c893dd5b606c75a538e4ef1","subject":"buffer: Fix some issues with -DVERIFY_ALIGNMENT"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:41:01.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"multi: Remove useless checks","message":"multi: Remove useless checks\n\nIf mi is NULL, the previous code lines already\nsegfaulted.\n\nIdentified by cppcheck.\n\nChange-Id: If58bb807842b7b95aeffe6849e7a7344e4925762\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9922d2c3f397944625b99afe984563cb2d9a0456":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-05-13 11:11:06.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/67/1667/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/1667/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4 \u0026\u0026 git checkout -b change-1667 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/1667/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b887872524d6fc481c23bfac20c3f5d117547eba","subject":"pool: Fix a potential NULL pointer de-reference in test code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-13 09:17:05.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-13 11:09:32.000000000","tz":120},"subject":"multi: Remove useless checks","message":"multi: Remove useless checks\n\nIf mi is NULL, the previous code lines already\nsegfaulted.\n\nIdentified by cppcheck.\n\nChange-Id: If58bb807842b7b95aeffe6849e7a7344e4925762\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1667\nMessage-Id: \u003c20260513091710.28378-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36899.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}