)]}'
{"id":"openvpn~1668","triplet_id":"openvpn~master~I5c9b54dca0a14688a3bb7798cb086f5bde7311b8","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-12 13:50:56.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-05-11 20:06:29.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-12 13:50:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5c9b54dca0a14688a3bb7798cb086f5bde7311b8","subject":"route: Clarify operator precedence in a \u0026 b ? c : d","status":"MERGED","created":"2026-05-06 21:20:59.000000000","updated":"2026-05-12 13:50:56.000000000","submitted":"2026-05-12 13:50:56.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1668-cppcheck","meta_rev_id":"d8338887be90a753eceb33f448a38f6ed413d105","_number":1668,"virtual_id_number":1668,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-06 21:21:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-07 05:49:26.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ce3778f78694f707e368d3e56c428719228c05bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-06 21:20:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3a7264e4c67bfab981ad60ae5514e5f2781126d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-07 05:49:26.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"992c5b801754d7dba5023ab6771effbbe54cf551","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b83e839866f74719f22ac363768b6018c1942609","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b4225b52c472c427b559cb92ed6e2dad8ef3faed","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-11 20:06:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d8338887be90a753eceb33f448a38f6ed413d105","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-12 13:50:56.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9beebd0a80663550b187c6e2f54d8b2f6bfaaf25","revisions":{"e29927473293902643ac18181452888db70e3ab8":{"kind":"REWORK","_number":1,"created":"2026-05-06 21:20:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1668/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1668/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1 \u0026\u0026 git checkout -b change-1668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e772bd3112310e7e38b276f9b149e75ff95e23c","subject":"multi: Remove useless checks"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:51:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 21:20:38.000000000","tz":120},"subject":"route: Clarify operator precedence in a \u0026 b ? c : d","message":"route: Clarify operator precedence in a \u0026 b ? c : d\n\nAs suggested by cppcheck.\n\nChange-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"403e1661ef52108f259ace2e70ba635b102de18a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1668/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1668/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2 \u0026\u0026 git checkout -b change-1668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4f71ea6b0bf42f83dd52c06fd99b952388c13169","subject":"multi: Remove useless checks"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:51:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:24:13.000000000","tz":120},"subject":"route: Clarify operator precedence in a \u0026 b ? c : d","message":"route: Clarify operator precedence in a \u0026 b ? c : d\n\nAs suggested by cppcheck.\n\nChange-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"89930301a14b2b6f8b16a7b3850c8a89d470ce99":{"kind":"REWORK","_number":3,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/1668/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1668/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3 \u0026\u0026 git checkout -b change-1668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"872679a9c1e00a165d07a41d6f90092ab74f89f6","subject":"multi: Remove useless checks"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:51:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"route: Clarify operator precedence in a \u0026 b ? c : d","message":"route: Clarify operator precedence in a \u0026 b ? c : d\n\nAs suggested by cppcheck.\n\nChange-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9beebd0a80663550b187c6e2f54d8b2f6bfaaf25":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2026-05-12 13:50:56.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/68/1668/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1668/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4 \u0026\u0026 git checkout -b change-1668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/1668/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1400926adada824973a3df001fdcc46f523d90ee","subject":"tun: Remove one useless if check"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 20:06:39.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-12 13:49:49.000000000","tz":120},"subject":"route: Clarify operator precedence in a \u0026 b ? c : d","message":"route: Clarify operator precedence in a \u0026 b ? c : d\n\nAs suggested by cppcheck.\n\nChange-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1668\nMessage-Id: \u003c20260511200645.24711-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36880.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}