)]}'
{"id":"openvpn~1669","triplet_id":"openvpn~master~Icd8ea093dfe9f1888570f3d7b786b951b5262e47","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-08 15:48:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-08 15:48:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icd8ea093dfe9f1888570f3d7b786b951b5262e47","subject":"dco_freebsd: Add check_malloc_return after realloc","status":"MERGED","created":"2026-05-06 21:20:59.000000000","updated":"2026-05-08 15:48:45.000000000","submitted":"2026-05-08 15:48:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1669-cppcheck","meta_rev_id":"d4dc0dd5e985e3e3cf6df86773e2207e2c35bf48","_number":1669,"virtual_id_number":1669,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-06 21:21:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-06 21:21:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-07 07:52:57.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"038395d603f63948d407b50ab3ccc8041dce1d5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-06 21:20:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6e0afeeec7356768ed95bee656981e59117ebd8","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-07 07:52:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9fbf647b4cc7406e8063e0c86153d42239fdd198","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d4dc0dd5e985e3e3cf6df86773e2207e2c35bf48","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-08 15:48:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fcc34b135222edf3d53976f406f8db19c19294c0","revisions":{"a804b841364bc1ce9d2d0c66c517baabbf9dff4c":{"kind":"REWORK","_number":1,"created":"2026-05-06 21:20:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/69/1669/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/1669/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1 \u0026\u0026 git checkout -b change-1669 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e29927473293902643ac18181452888db70e3ab8","subject":"route: Clarify operator precedence in a \u0026 b ? c : d"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:54:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 21:20:38.000000000","tz":120},"subject":"dco_freebsd: Add check_malloc_return after realloc","message":"dco_freebsd: Add check_malloc_return after realloc\n\ncppcheck complained about a potential memleak\ndue to realloc failure. But trying to handle that\nis probably not useful. Just abort like we do\nfor other malloc failures.\n\nChange-Id: Icd8ea093dfe9f1888570f3d7b786b951b5262e47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f8cf5633342d5249fcf542e01658b484dda16280":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/69/1669/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/1669/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2 \u0026\u0026 git checkout -b change-1669 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"403e1661ef52108f259ace2e70ba635b102de18a","subject":"route: Clarify operator precedence in a \u0026 b ? c : d"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-06 15:54:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:24:13.000000000","tz":120},"subject":"dco_freebsd: Add check_malloc_return after realloc","message":"dco_freebsd: Add check_malloc_return after realloc\n\ncppcheck complained about a potential memleak\ndue to realloc failure. But trying to handle that\nis probably not useful. Just abort like we do\nfor other malloc failures.\n\nChange-Id: Icd8ea093dfe9f1888570f3d7b786b951b5262e47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"fcc34b135222edf3d53976f406f8db19c19294c0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-05-08 15:48:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/69/1669/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/1669/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3 \u0026\u0026 git checkout -b change-1669 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/1669/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"74d39dfba2aa8d94110467788dfb9160fc739fad","subject":"sample: Fix cppcheck error invalidPrintfArgType_sint"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-07 07:53:15.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-07 08:56:35.000000000","tz":120},"subject":"dco_freebsd: Add check_malloc_return after realloc","message":"dco_freebsd: Add check_malloc_return after realloc\n\ncppcheck complained about a potential memleak\ndue to realloc failure. But trying to handle that\nis probably not useful. Just abort like we do\nfor other malloc failures.\n\nChange-Id: Icd8ea093dfe9f1888570f3d7b786b951b5262e47\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1669\nMessage-Id: \u003c20260507075321.25123-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36842.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}