)]}'
{"id":"openvpn~1671","triplet_id":"openvpn~master~I3d391016dcd3c66e58f3f05b356bcd419224acb1","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-14 14:49:14.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-14 14:49:14.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2026-05-14 09:17:36.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I3d391016dcd3c66e58f3f05b356bcd419224acb1","subject":"openvpnserv: always use W variant of RpcStringFree()","status":"MERGED","created":"2026-05-08 11:26:56.000000000","updated":"2026-05-14 14:49:14.000000000","submitted":"2026-05-14 14:49:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1671-cppcheck","meta_rev_id":"897150bd17c6e3c0f0817de8bec1508d4046fe5a","_number":1671,"virtual_id_number":1671,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-08 11:27:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-08 11:27:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-12 10:11:08.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"a18402a4cb39d84902bd37588fb4372b9e10d183","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a65528bb7421b295dcd24b98df0dd7ceaecda109","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bd067a7129cf4050a1f50b6b96e0e6b91d72cefb","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-05-14 09:17:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"897150bd17c6e3c0f0817de8bec1508d4046fe5a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-14 14:49:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","revisions":{"431b30a78dc282a17198c683a399ce0ab8a93a9d":{"kind":"REWORK","_number":1,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/71/1671/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/1671/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1 \u0026\u0026 git checkout -b change-1671 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"320be5a35a76015d4d250b9b7860177632173d6e","subject":"openvpnserv: Fix memory leak when loading DLLs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 10:52:54.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:26:39.000000000","tz":120},"subject":"openvpnserv: Use same variant of UuidToString and RpcStringFree","message":"openvpnserv: Use same variant of UuidToString and RpcStringFree\n\nProbably not a real issue since it should always use the\nW version in our case, but still unclean.\n\nFixes a cppcheck complaint.\n\nChange-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"fb39fd36f9bcbb2ea030cbf91a1ecaf794f4b605":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/71/1671/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/1671/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2 \u0026\u0026 git checkout -b change-1671 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5951c18ebc1984b46ff7335a282099ffed676194","subject":"openvpnserv: Fix memory leak when loading DLLs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 10:52:54.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"openvpnserv: Use same variant of UuidToString and RpcStringFree","message":"openvpnserv: Use same variant of UuidToString and RpcStringFree\n\nProbably not a real issue since it should always use the\nW version in our case, but still unclean.\n\nFixes a cppcheck complaint.\n\nChange-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-05-14 14:49:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/71/1671/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/1671/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3 \u0026\u0026 git checkout -b change-1671 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1671/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae63905eb97e036756352bfc1576e5f71ffc3873","subject":"openvpnserv: Fix memory leak when loading DLLs"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-14 09:19:12.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-14 14:47:54.000000000","tz":120},"subject":"openvpnserv: always use W variant of RpcStringFree()","message":"openvpnserv: always use W variant of RpcStringFree()\n\nProbably not a real issue since it should always use the\nW version in our case, but still unclean.\n\nFixes a cppcheck complaint.\n\nChange-Id: I3d391016dcd3c66e58f3f05b356bcd419224acb1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1671\nMessage-Id: \u003c20260514091918.18197-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36915.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}