)]}'
{"id":"openvpn~1674","triplet_id":"openvpn~master~Ida6d4fa8c5c5ffbd7909d6afd51b1b6f32ca2d9f","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-14 10:38:09.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-14 10:38:09.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2026-05-13 14:45:18.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ida6d4fa8c5c5ffbd7909d6afd51b1b6f32ca2d9f","subject":"openvpnserv: Address some uninitVariable warnings from cppcheck","status":"MERGED","created":"2026-05-08 11:26:56.000000000","updated":"2026-05-14 10:38:09.000000000","submitted":"2026-05-14 10:38:09.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1674-cppcheck","meta_rev_id":"24c3eb539a21dcd7db8d3f889c06d66e9d1a3d13","_number":1674,"virtual_id_number":1674,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-08 11:27:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-08 11:27:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-12 10:12:00.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"b83cbaae6c767082f0a43a08c98d97214bc67ef8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c310fcebc034f56beb2a61bd100c26f6176492af","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7a7e6327fbcc0d57aedc91884ba7779a981a11d7","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-05-13 14:45:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"24c3eb539a21dcd7db8d3f889c06d66e9d1a3d13","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-14 10:38:09.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"50bcb9206b1dc3100a6b20cf569c4caf9c9105e3","revisions":{"568d387331f802699e35c7b8e695b21cb5b039f3":{"kind":"REWORK","_number":1,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/74/1674/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1674/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1 \u0026\u0026 git checkout -b change-1674 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d99472a354215401bacd6b8172fdeef13747146c","subject":"Do not use deprecated aliases on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:02:42.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:26:39.000000000","tz":120},"subject":"openvpnserv: Address some uninitVariable warnings from cppcheck","message":"openvpnserv: Address some uninitVariable warnings from cppcheck\n\nIn the first case this is about helping cppcheck\nremember that msg-\u003eaddr_len and addr_len are the same\nthing, but we use them in confusing ways.\n\nIn the second case there is indeed a theoretical\ncode path where we use an uninitialized buffer. So\nmake the code safer.\n\nChange-Id: Ida6d4fa8c5c5ffbd7909d6afd51b1b6f32ca2d9f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8a89e496026fa03aac682c52065ab1c6aaf20ce1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/74/1674/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1674/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2 \u0026\u0026 git checkout -b change-1674 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a9747b1346419b4ae6b14b9c262e98243e5105c","subject":"Do not use deprecated aliases on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:02:42.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"openvpnserv: Address some uninitVariable warnings from cppcheck","message":"openvpnserv: Address some uninitVariable warnings from cppcheck\n\nIn the first case this is about helping cppcheck\nremember that msg-\u003eaddr_len and addr_len are the same\nthing, but we use them in confusing ways.\n\nIn the second case there is indeed a theoretical\ncode path where we use an uninitialized buffer. So\nmake the code safer.\n\nChange-Id: Ida6d4fa8c5c5ffbd7909d6afd51b1b6f32ca2d9f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"50bcb9206b1dc3100a6b20cf569c4caf9c9105e3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-05-14 10:38:09.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/74/1674/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1674/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3 \u0026\u0026 git checkout -b change-1674 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1674/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d69a0dfe73de6aa698caa8580d3bf54e76bd0dca","subject":"Do not use deprecated aliases on Windows"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-13 15:08:57.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-14 10:30:30.000000000","tz":120},"subject":"openvpnserv: Address some uninitVariable warnings from cppcheck","message":"openvpnserv: Address some uninitVariable warnings from cppcheck\n\nIn the first case this is about helping cppcheck\nremember that msg-\u003eaddr_len and addr_len are the same\nthing, but we use them in confusing ways.\n\nIn the second case there is indeed a theoretical\ncode path where we use an uninitialized buffer. So\nmake the code safer.\n\nChange-Id: Ida6d4fa8c5c5ffbd7909d6afd51b1b6f32ca2d9f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1674\nMessage-Id: \u003c20260513150902.27447-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36908.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
