)]}'
{"id":"openvpn~1676","triplet_id":"openvpn~master~I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2","project":"openvpn","branch":"master","topic":"cppcheck","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-13 09:15:18.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-13 09:15:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2","subject":"pool: Fix a potential NULL pointer de-reference in test code","status":"MERGED","created":"2026-05-08 11:26:56.000000000","updated":"2026-05-13 09:15:18.000000000","submitted":"2026-05-13 09:15:18.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1676-cppcheck","meta_rev_id":"a00412c9269e472733eb0640876502732d8d1381","_number":1676,"virtual_id_number":1676,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-08 11:27:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-08 11:27:06.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-08 15:31:43.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"19257b234284a43a6d37bf97e0ced9698ef4ad81","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-08 11:26:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb840ba62f262986abbce019a3e62245ebd7a99e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-08 15:31:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9ffa14b49208acf8a36d063e3dad5df15ffa0605","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-11 17:44:40.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a00412c9269e472733eb0640876502732d8d1381","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-05-13 09:15:18.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b887872524d6fc481c23bfac20c3f5d117547eba","revisions":{"f3cc925d667737e584681b9dcc11774f06a1a4ee":{"kind":"REWORK","_number":1,"created":"2026-05-08 11:26:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/76/1676/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/76/1676/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1 \u0026\u0026 git checkout -b change-1676 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5da562e0486a4fbfad3e482a437ffb213caf1a77","subject":"lladdr: Clean up code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:15:01.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:26:39.000000000","tz":120},"subject":"pool: Fix a potential NULL pointer de-reference in test code","message":"pool: Fix a potential NULL pointer de-reference in test code\n\nIdentified by cppcheck. Probably has been a long time\nsince that code has been compiled, though.\n\nChange-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c81f5a674d051b5e5d2d31be10cc1fe2134c11ae":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-11 17:44:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/76/1676/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/76/1676/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2 \u0026\u0026 git checkout -b change-1676 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8a89e496026fa03aac682c52065ab1c6aaf20ce1","subject":"openvpnserv: Address some uninitVariable warnings from cppcheck"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 11:15:01.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-11 17:43:50.000000000","tz":120},"subject":"pool: Fix a potential NULL pointer de-reference in test code","message":"pool: Fix a potential NULL pointer de-reference in test code\n\nIdentified by cppcheck. Probably has been a long time\nsince that code has been compiled, though.\n\nChange-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b887872524d6fc481c23bfac20c3f5d117547eba":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-05-13 09:15:18.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/76/1676/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/76/1676/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3 \u0026\u0026 git checkout -b change-1676 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/76/1676/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9beebd0a80663550b187c6e2f54d8b2f6bfaaf25","subject":"route: Clarify operator precedence in a \u0026 b ? c : d"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-05-08 15:31:51.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-05-13 09:12:13.000000000","tz":120},"subject":"pool: Fix a potential NULL pointer de-reference in test code","message":"pool: Fix a potential NULL pointer de-reference in test code\n\nIdentified by cppcheck. Probably has been a long time\nsince that code has been compiled, though.\n\nChange-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1676\nMessage-Id: \u003c20260508153156.13575-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36865.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}