)]}'
{"id":"openvpn~1679","triplet_id":"openvpn~master~I70560efd113308b7377424127eb2c1da4266371a","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-20 16:33:35.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-05-20 16:33:24.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I70560efd113308b7377424127eb2c1da4266371a","subject":"Replace strtok with strtok_r","status":"NEW","created":"2026-05-16 20:27:12.000000000","updated":"2026-05-20 16:33:35.000000000","submit_type":"CHERRY_PICK","submittable":true,"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"adb09abf4e2e77cb7b923fb5c7d1709a5ef2b73c","_number":1679,"virtual_id_number":1679,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"all":[{"value":2,"date":"2026-05-20 16:33:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-16 20:27:13.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-20 15:48:21.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"CC"},{"updated":"2026-05-20 16:33:35.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"439e7cb355b85996476164e4917011c885ac7226","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-16 20:27:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb60480fdf88a0066c4775ca8aa208b216eaa444","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-18 00:33:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8a516e8bacb9d5168f39154b1eab67fa9ed1c6f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-18 13:17:08.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6aa8f392b60fe34f2400543c7273533df38228ae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-18 13:39:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"efde9109dcbff5c671872960b66db8581b05a984","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-20 15:48:21.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"cd976d57b12cc298823843829d0f6dcfc2a68a6c","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-20 16:01:56.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"7a26e521cc46142dbf64dfa6d931d89f3ffdccc3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-20 16:10:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e688182029ceea88afd13b725f86b6f83d078f46","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-05-20 16:18:20.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"58d305df4c0d0a1049ce25e1631d1a3f0905c7a8","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-20 16:33:24.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"adb09abf4e2e77cb7b923fb5c7d1709a5ef2b73c","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-20 16:33:35.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"96d7c0ec791afbd3c412969bab407ac1a37314df","revisions":{"64785e381b1fc65b47958a14c0b6f7ac48a8fc59":{"kind":"REWORK","_number":1,"created":"2026-05-16 20:27:12.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/79/1679/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/1679/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1 \u0026\u0026 git checkout -b change-1679 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:25:28.000000000","tz":0},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:27:05.000000000","tz":0},"subject":"Replace strtok with strtok_r","message":"Replace strtok with strtok_r\n\nThis dos not change anything in our source code but makes compiling\nwith newer Android NDKs (version 30 pre release) -Werror safe again\nas it has started throwing warning on this.\n\nChange-Id: I70560efd113308b7377424127eb2c1da4266371a\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"8292afaa7b96c0b8b5b80b5592829fec3a460ada":{"kind":"REWORK","_number":2,"created":"2026-05-18 00:33:22.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/79/1679/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/1679/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2 \u0026\u0026 git checkout -b change-1679 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:25:28.000000000","tz":0},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-18 00:31:42.000000000","tz":0},"subject":"Replace strtok with strtok_r","message":"Replace strtok with strtok_r\n\nThis dos not change anything in our source code but makes compiling\nwith newer Android NDKs (version 30 pre release) -Werror safe again\nas it has started throwing warning on this.\n\nThe compat version is taken from current FreeBSD (commit dc36d6f9bb1)\nsrc/lib/libc/string/strtok.c and reformatted to our clang standard.\n\nChange-Id: I70560efd113308b7377424127eb2c1da4266371a\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"417fd4e20465e3d6692640ceaf38f567ac0f9a1c":{"kind":"REWORK","_number":3,"created":"2026-05-18 13:17:08.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/79/1679/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/1679/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3 \u0026\u0026 git checkout -b change-1679 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:25:28.000000000","tz":0},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-18 13:16:40.000000000","tz":0},"subject":"Replace strtok with strtok_r","message":"Replace strtok with strtok_r\n\nThis dos not change anything in our source code but makes compiling\nwith newer Android NDKs (version 30 pre release) -Werror safe again\nas it has started throwing warning on this.\n\nThe compat version is taken from current FreeBSD (commit dc36d6f9bb1)\nsrc/lib/libc/string/strtok.c and reformatted to our clang standard.\n\nChange-Id: I70560efd113308b7377424127eb2c1da4266371a\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"c2db2045f18ba56609fadd81e23bf1bbd5830f11":{"kind":"REWORK","_number":4,"created":"2026-05-18 13:39:21.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/79/1679/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/1679/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4 \u0026\u0026 git checkout -b change-1679 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:25:28.000000000","tz":0},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-18 13:39:10.000000000","tz":0},"subject":"Replace strtok with strtok_r","message":"Replace strtok with strtok_r\n\nThis dos not change anything in our source code but makes compiling\nwith newer Android NDKs (version 30 pre release) -Werror safe again\nas it has started throwing warning on this.\n\nThe compat version is taken from current FreeBSD (commit dc36d6f9bb1)\nsrc/lib/libc/string/strtok.c and reformatted to our clang standard.\n\nChange-Id: I70560efd113308b7377424127eb2c1da4266371a\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"96d7c0ec791afbd3c412969bab407ac1a37314df":{"kind":"REWORK","_number":5,"created":"2026-05-20 16:10:59.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/79/1679/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/1679/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5 \u0026\u0026 git checkout -b change-1679 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/79/1679/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-16 20:25:28.000000000","tz":0},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-20 16:10:55.000000000","tz":0},"subject":"Replace strtok with strtok_r","message":"Replace strtok with strtok_r\n\nThis dos not change anything in our source code but makes compiling\nwith newer Android NDKs (version 30 pre release) -Werror safe again\nas it has started throwing warning on this.\n\nThe compat version is taken from current FreeBSD (commit dc36d6f9bb1)\nsrc/lib/libc/string/strtok.c and reformatted to our clang standard.\n\nChange-Id: I70560efd113308b7377424127eb2c1da4266371a\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}