)]}'
{"id":"openvpn~1681","triplet_id":"openvpn~master~I4068bf8175c23151298d142dc920ab89f861a411","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-08-22 15:54:59.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-08-22 15:54:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4068bf8175c23151298d142dc920ab89f861a411","subject":"clinat: do not adjust UDP checksum if zero","status":"MERGED","created":"2026-05-19 13:35:52.000000000","updated":"2026-08-22 15:54:59.000000000","submitted":"2026-08-22 15:54:59.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1681","meta_rev_id":"ec263dbcfec03e456470ff3340f76a603306bf0f","_number":1681,"virtual_id_number":1681,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-19 13:35:53.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-19 13:35:53.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-21 12:03:38.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"49f4e20fe92007c9520a21076eeed17f6fcf8359","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-19 13:35:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6aa4a57cc379317c5068b1a6cd050ed07b676250","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-21 12:03:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ec263dbcfec03e456470ff3340f76a603306bf0f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-08-22 15:54:59.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c797db6225755e6d7144d433ed55d3992d8ff141","revisions":{"23e9873e15a43ad7673628a6f7d9dadfa906b931":{"kind":"REWORK","_number":1,"created":"2026-05-19 13:35:52.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/81/1681/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1681/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1 \u0026\u0026 git checkout -b change-1681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-19 13:31:17.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-19 13:32:34.000000000","tz":120},"subject":"clinat: do not adjust UDP checksum if zero","message":"clinat: do not adjust UDP checksum if zero\n\nAs per RFC768, when the UDP checksum is zero, it means\nit was not computed by the source, therefore any NAT\nprocessing along the way should leave the checksum alone\nand not update it.\nFailing to do so would result in computing a bogus value.\n\nAt the same time, if the result of updating a non-zero\nchecksum ends up being zero, as per the same RFC, we must\nstore its one-complement (0xFFFF) as zero is reserved\nfor \"checksum not computed\", as mentioned above.\n\nEnsure our Client NAT code follows both rules.\n\nGithub: closes OpenVPN/openvpn#1037\nReported-by: Jeff Salee \u003cjeff@samjackson.com\u003e\nChange-Id: I4068bf8175c23151298d142dc920ab89f861a411\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c797db6225755e6d7144d433ed55d3992d8ff141":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-08-22 15:54:59.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/1681/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/1681/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2 \u0026\u0026 git checkout -b change-1681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/1681/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e8dfe34b01f4ea727ba4a0ce1cf3093087cf960","subject":"options: Factor out options_string code from options.c"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-08-21 18:24:34.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-08-22 15:38:18.000000000","tz":120},"subject":"clinat: do not adjust UDP checksum if zero","message":"clinat: do not adjust UDP checksum if zero\n\nAs per RFC768, when the UDP checksum is zero, it means\nit was not computed by the source, therefore any NAT\nprocessing along the way should leave the checksum alone\nand not update it.\nFailing to do so would result in computing a bogus value.\n\nAt the same time, if the result of updating a non-zero\nchecksum ends up being zero, as per the same RFC, we must\nstore its one-complement (0xFFFF) as zero is reserved\nfor \"checksum not computed\", as mentioned above.\n\nEnsure our Client NAT code follows both rules.\n\nGithub: closes OpenVPN/openvpn#1037\nReported-by: Jeff Salee \u003cjeff@samjackson.com\u003e\nChange-Id: I4068bf8175c23151298d142dc920ab89f861a411\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1681\nMessage-Id: \u003c20260821182442.13542-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38581.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}