)]}'
{"id":"openvpn~1682","triplet_id":"openvpn~master~Ib5832dc56eaeca1b17016396769b84bdf2c1513a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-09-26 20:09:56.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-09-26 20:09:56.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-09-26 20:09:56.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Ib5832dc56eaeca1b17016396769b84bdf2c1513a","subject":"multi/dco: simplify dco_delete_iroutes call chain","status":"MERGED","created":"2026-05-20 08:23:36.000000000","updated":"2026-09-26 20:09:56.000000000","submitted":"2026-09-26 20:09:56.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1682","meta_rev_id":"7d63d922accfaf73b6c0ebe8c823277c9bc22cbf","_number":1682,"virtual_id_number":1682,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-20 08:23:37.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-20 08:23:37.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-05-20 15:41:36.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"CC"},{"updated":"2026-09-10 08:56:11.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"496bf32dd7bd1de865357ab6b30cda71ef946c2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-20 08:23:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"45198610a3bcfe051cc1f5f03b5e9b354515d5e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-20 08:54:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4141fbaeef6da40560f50ded8db8eaebcce5f666","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-05-20 15:41:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bca8020e05d06b8984e9be8eaa71fe727dec80d0","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-20 18:58:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b0ba6cd532cd6df92e5eac44d77613caab9ee8b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-20 20:21:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a4d9ad306bcf60ef7aa5d612fea1b2f8bdc2ccdc","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-05-20 20:22:10.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"736b481da4d7049749bede799ec46dd618d7234c","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-08 20:19:27.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"2891d1991641176d2c4b8450114fc3dd8f2eec1f","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-08 15:26:05.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"a063073ed66e223262c462fb0fb7fbaa0c3eb65d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-10 08:22:43.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"b1d2774253b04355db8fe2a3ae664fb79db0aa51","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-09-10 08:56:11.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"7d63d922accfaf73b6c0ebe8c823277c9bc22cbf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-09-26 20:09:56.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"48939c9cd29b3bd857da10452aae854bc670c04f","revisions":{"f5af8cfaeaee954ba4a81d3dd3e571e030bf2d00":{"kind":"REWORK","_number":1,"created":"2026-05-20 08:23:36.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1682/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1682/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1 \u0026\u0026 git checkout -b change-1682 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:03:34.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:23:17.000000000","tz":120},"subject":"multi/dco: simplify dco_delete_iroutes call chain","message":"multi/dco: simplify dco_delete_iroutes call chain\n\nIn order to be able to delete DCO iroutes from areas of the code\nwhere the multi_context and the multi_instance objects may not be\navailable, let\u0027s simplify the call chain by passing the smallest\nscoped context required.\n\nThis is a refactoring only and does not include any functional change.\n\nThis patch is required in preparation of fixing DCO iroutes removal\nupon client exit, without waiting for the delayed exit routine\nto kick in.\n\nChange-Id: Ib5832dc56eaeca1b17016396769b84bdf2c1513a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c5f02a68b6036a8c30e5e81704b1ffa417b26d83":{"kind":"REWORK","_number":2,"created":"2026-05-20 08:54:27.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1682/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1682/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2 \u0026\u0026 git checkout -b change-1682 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:03:34.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:54:20.000000000","tz":120},"subject":"multi/dco: simplify dco_delete_iroutes call chain","message":"multi/dco: simplify dco_delete_iroutes call chain\n\nIn order to be able to delete DCO iroutes from areas of the code\nwhere the multi_context and the multi_instance objects may not be\navailable, let\u0027s simplify the call chain by passing the smallest\nscoped context required.\n\nThis is a refactoring only and does not include any functional change.\n\nThis patch is required in preparation of fixing DCO iroutes removal\nupon client exit, without waiting for the delayed exit routine\nto kick in.\n\nChange-Id: Ib5832dc56eaeca1b17016396769b84bdf2c1513a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"913767cf436841f1e605089e1b7c2ba5021a335c":{"kind":"REWORK","_number":3,"created":"2026-05-20 20:21:53.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1682/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1682/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3 \u0026\u0026 git checkout -b change-1682 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:03:34.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 20:21:34.000000000","tz":120},"subject":"multi/dco: simplify dco_delete_iroutes call chain","message":"multi/dco: simplify dco_delete_iroutes call chain\n\nIn order to be able to delete DCO iroutes from areas of the code\nwhere the multi_context and the multi_instance objects may not be\navailable, let\u0027s simplify the call chain by passing the smallest\nscoped context required.\n\nThis is a refactoring only and does not include any functional change.\n\nThis patch is required in preparation of fixing DCO iroutes removal\nupon client exit, without waiting for the delayed exit routine\nto kick in.\n\nChange-Id: Ib5832dc56eaeca1b17016396769b84bdf2c1513a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8559184d4d69311300b093095358ddbf4346b90a":{"kind":"REWORK","_number":4,"created":"2026-09-10 08:22:43.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/82/1682/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1682/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4 \u0026\u0026 git checkout -b change-1682 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28ec0f90fd5e4da73d9a0246fcb43d20150943ab","subject":"run-cppcheck.sh: Make it more configurable"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-20 08:03:34.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-10 08:14:11.000000000","tz":120},"subject":"multi/dco: simplify dco_delete_iroutes call chain","message":"multi/dco: simplify dco_delete_iroutes call chain\n\nIn order to be able to delete DCO iroutes from areas of the code\nwhere the multi_context and the multi_instance objects may not be\navailable, let\u0027s simplify the call chain by passing the smallest\nscoped context required.\n\nThis is a refactoring only and does not include any functional change.\n\nThis patch is required in preparation of fixing DCO iroutes removal\nupon client exit, without waiting for the delayed exit routine\nto kick in.\n\nChange-Id: Ib5832dc56eaeca1b17016396769b84bdf2c1513a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"48939c9cd29b3bd857da10452aae854bc670c04f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-09-26 20:09:56.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/82/1682/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/82/1682/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5 \u0026\u0026 git checkout -b change-1682 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/82/1682/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"060b9ebd1460600803d49abed990ab5f71b72395","subject":"cppcheck: Clean up suppressions to not annoy developers"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-09-21 08:22:16.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-09-26 16:47:27.000000000","tz":120},"subject":"multi/dco: simplify dco_delete_iroutes call chain","message":"multi/dco: simplify dco_delete_iroutes call chain\n\nIn order to be able to delete DCO iroutes from areas of the code\nwhere the multi_context and the multi_instance objects may not be\navailable, let\u0027s simplify the call chain by passing the smallest\nscoped context required.\n\nThis is a refactoring only and does not include any functional change.\n\nThis patch is required in preparation of fixing DCO iroutes removal\nupon client exit, without waiting for the delayed exit routine\nto kick in.\n\nChange-Id: Ib5832dc56eaeca1b17016396769b84bdf2c1513a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1682\nMessage-Id: \u003c20260921082222.17813-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg39358.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}