)]}'
{"src/openvpn/mudp.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f6e0d541295f3d1b9b82cab03ed5f5687f05a2c7","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    /* Send synchronously: queueing across event-loop iterations would alias"},{"line_number":59,"context_line":"     * m-\u003etop.c2.from and aux_buf into cross-socket race territory.  The reply"},{"line_number":60,"context_line":"     * is small, stateless, and rate-limited by reflect_filter_rate_limit_check();"},{"line_number":61,"context_line":"     * dropping on EAGAIN is acceptable as the client retransmits its HARD_RESET. */"},{"line_number":62,"context_line":"    msg_set_prefix(\"Connection Attempt\");"},{"line_number":63,"context_line":"    c-\u003ec2.to_link \u003d c-\u003ec2.buffers-\u003eaux_buf;"},{"line_number":64,"context_line":"    c-\u003ec2.to_link_addr \u003d \u0026c-\u003ec2.from;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"19e74ef5_09f25a8d","line":61,"updated":"2026-06-09 07:30:57.000000000","message":"Also, I would reduce this comment to focus on \"what we do\", not \"how we did it in the past, which did not work\" - of course one could make it work asynchronously (just create deep copies of `from`, `aux_buf`, `sock`).\n\nSo maybe something\n\n```\n  /* we do not want to keep any state here, anywhere, so we just send the\n   * reply to the initial packet synchronously, without queueing anything.\n   * Should we hit EAGAIN on a busy socket, the packet would get lost, and\n   * the client needs to retransmit its HARD_RESET - which is considered\n   * an acceptable compromise for managing server resources under attack.\n   */\n```","commit_id":"813856dba54347167bcd041b67ed831479cf37b7"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"34fca11bb5bd474b9f65a3b305e32065b014d57c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    /* Send synchronously: queueing across event-loop iterations would alias"},{"line_number":59,"context_line":"     * m-\u003etop.c2.from and aux_buf into cross-socket race territory.  The reply"},{"line_number":60,"context_line":"     * is small, stateless, and rate-limited by reflect_filter_rate_limit_check();"},{"line_number":61,"context_line":"     * dropping on EAGAIN is acceptable as the client retransmits its HARD_RESET. */"},{"line_number":62,"context_line":"    msg_set_prefix(\"Connection Attempt\");"},{"line_number":63,"context_line":"    c-\u003ec2.to_link \u003d c-\u003ec2.buffers-\u003eaux_buf;"},{"line_number":64,"context_line":"    c-\u003ec2.to_link_addr \u003d \u0026c-\u003ec2.from;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"050409ab_49c408e4","line":61,"in_reply_to":"19e74ef5_09f25a8d","updated":"2026-06-09 07:43:33.000000000","message":"Done","commit_id":"813856dba54347167bcd041b67ed831479cf37b7"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9123f489f7e44a1b3b282ae0062f9e0802d3c1c6","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    c-\u003ec2.to_link_addr \u003d NULL;"},{"line_number":68,"context_line":"    msg_set_prefix(NULL);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    msg(D_MULTI_DEBUG, \"Reset packet from client, sending HMAC based reset challenge\");"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6862dd78_2dcdbb54","line":70,"updated":"2026-06-09 07:26:43.000000000","message":"having this `msg()` *after* we already sent out the packet does not make sense -\u003e this should go upwards, either before or after the `msg_set_prefix()` but definitely before the `process_outgoing_link()`.","commit_id":"813856dba54347167bcd041b67ed831479cf37b7"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"34fca11bb5bd474b9f65a3b305e32065b014d57c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    c-\u003ec2.to_link_addr \u003d NULL;"},{"line_number":68,"context_line":"    msg_set_prefix(NULL);"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    msg(D_MULTI_DEBUG, \"Reset packet from client, sending HMAC based reset challenge\");"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1fbca709_dfbaaa38","line":70,"in_reply_to":"6862dd78_2dcdbb54","updated":"2026-06-09 07:43:33.000000000","message":"Done","commit_id":"813856dba54347167bcd041b67ed831479cf37b7"}]}