)]}'
{"id":"openvpn~1702","triplet_id":"openvpn~master~I2df0fec786184b9fcf9b7c56c74816325cdb6942","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-22 13:18:01.000000000","reason":"Reviewer was added"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-05-22 13:18:00.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I2df0fec786184b9fcf9b7c56c74816325cdb6942","subject":"mudp: send HMAC reset reply synchronously","status":"NEW","created":"2026-05-22 13:18:00.000000000","updated":"2026-05-22 13:18:01.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"15c7d9ca9d976389621d03e1d5d3c56bc257cec0","_number":1702,"virtual_id_number":1702,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-22 13:18:00.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2026-05-22 13:18:01.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-22 13:18:01.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"3109b3e627541b2ef8e3d34255cc41eab7d5e8a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-05-22 13:18:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"813856dba54347167bcd041b67ed831479cf37b7","revisions":{"813856dba54347167bcd041b67ed831479cf37b7":{"kind":"REWORK","_number":1,"created":"2026-05-22 13:18:00.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/02/1702/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1702/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1 \u0026\u0026 git checkout -b change-1702 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1702/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-05-22 09:25:47.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-05-22 11:01:18.000000000","tz":120},"subject":"mudp: send HMAC reset reply synchronously","message":"mudp: send HMAC reset reply synchronously\n\nBuilding a HARD_RESET reply was queueing the result into three\nmulti_context fields and deferring the send to the next event-loop\niteration, where multi_process_outgoing_link() flushed it:\n\n  struct buffer hmac_reply;\n  struct link_socket_actual *hmac_reply_dest;  /* aliased \u0026m-\u003etop.c2.from */\n  struct link_socket *hmac_reply_ls;\n\nThe mechanism had three latent issues:\n\n1. hmac_reply_dest \u003d \u0026m-\u003etop.c2.from stored a pointer alias into\n   shared mutable state.  Any subsequent read into m-\u003etop.c2.from\n   silently retargeted the pending reply to a different peer.\n2. m-\u003ehmac_reply_ls \u003d sock; at the top of multi_get_create_instance_udp()\n   was executed unconditionally for every UDP packet, including packets\n   that did not queue a reply.  A stale queued reply could thus be sent\n   on the wrong listening socket.\n3. hmac_reply.data pointed into m-\u003etop.c2.buffers-\u003eaux_buf (the only\n   slot).  A second send_hmac_reset_packet() before the first flush\n   would overwrite the first reply\u0027s bytes.\n\nThese were latent on master because m-\u003emulti_io-\u003eudp_flags was consumed\nand zeroed by the first event in each multi_io_process_io() loop, so at\nmost one UDP read ran per outer iteration.\n\nSend the reply synchronously from within send_hmac_reset_packet() using\nthe sock that the read fired on (threaded through do_pre_decrypt_check).\nThe reply is small, stateless, and rate-limited by the existing\nreflect_filter_rate_limit_check(); dropping on EAGAIN is acceptable\nbecause the client retransmits its HARD_RESET.  The three multi_context\nfields and the deferred-flush block in multi_process_outgoing_link() are\ngone; p2mp_iow_flags() no longer needs an IOW_TO_LINK branch for hmac\nstate.\n\nChange-Id: I2df0fec786184b9fcf9b7c56c74816325cdb6942\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}