)]}'
{"id":"openvpn~1704","triplet_id":"openvpn~master~I21d782780b7f89b3061dd97500589a24415afc23","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-05-27 11:41:48.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I21d782780b7f89b3061dd97500589a24415afc23","subject":"route: Don\u0027t delete pre-existing host route to VPN server on disconnect","status":"NEW","created":"2026-05-27 11:41:48.000000000","updated":"2026-05-27 11:41:48.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e7a134024417dc05a99a57121b6b211180978866","_number":1704,"virtual_id_number":1704,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-27 11:41:48.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-05-27 11:41:48.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"46cdef80c8966364acd21a5b4d4c27ae9b19f989","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-05-27 11:41:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cfb380539f4084fd65cb54b175cd5258e67cfb0f","revisions":{"cfb380539f4084fd65cb54b175cd5258e67cfb0f":{"kind":"REWORK","_number":1,"created":"2026-05-27 11:41:48.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/04/1704/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1704/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1 \u0026\u0026 git checkout -b change-1704 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1704/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-05-27 11:08:03.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-05-27 11:35:10.000000000","tz":180},"subject":"route: Don\u0027t delete pre-existing host route to VPN server on disconnect","message":"route: Don\u0027t delete pre-existing host route to VPN server on disconnect\n\nWhen a host route to the VPN server already exists at connect time\n(e.g. a manually configured static route), add_route3() returns true\nfor both \"successfully added\" and \"already exists\" but discards the\nper-route RT_ADDED bit, since it operates on a local struct route_ipv4.\nThe caller in redirect_default_route_to_vpn() then sets RL_DID_LOCAL\nunconditionally, and on disconnect undo_redirect_default_route_to_vpn()\nasks del_route3() to delete it -- which forces RT_ADDED on a fresh struct,\nbypassing delete_route()\u0027s protective guard. The result: the pre-existing\nroute gets removed.\n\nChange add_route3() to return RTA_SUCCESS / RTA_EEXIST / RTA_ERROR by\ninspecting the local struct\u0027s RT_ADDED bit after add_route(). Only set\nRL_DID_LOCAL on RTA_SUCCESS so a pre-existing route survives disconnect.\nApply the same fix to the DHCP/DNS bypass routes via a new\nroute_bypass.bypass_added bitmask so each entry is only deleted on undo\nif we added it.\n\nGitHub: #970\n\nChange-Id: I21d782780b7f89b3061dd97500589a24415afc23\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}