)]}'
{"id":"openvpn~1706","triplet_id":"openvpn~master~I2ce954aa5b74002be5e38d53783435736625bb2f","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-05 18:08:20.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2026-06-05 18:08:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2ce954aa5b74002be5e38d53783435736625bb2f","subject":"socket: assert buffer length before reading prepended sockaddr family","status":"MERGED","created":"2026-06-02 12:52:01.000000000","updated":"2026-06-05 18:08:20.000000000","submitted":"2026-06-05 18:08:20.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1706","meta_rev_id":"a81728627545494db58070bac30017a693210d1b","_number":1706,"virtual_id_number":1706,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-02 12:52:02.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-02 12:52:02.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-06-05 14:17:36.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"524a577af992d73176e695b1ff2095a7629963eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2026-06-02 12:52:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e3b1b34d49146956450e696eaf1b097b13e88a32","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-06-05 14:17:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a81728627545494db58070bac30017a693210d1b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-06-05 18:08:20.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"71b271d9a168b7c43f3b78bdc4768edadfa25e86","revisions":{"85c28b13f51ba2d226daacf7e6f9d5dda3cddd07":{"kind":"REWORK","_number":1,"created":"2026-06-02 12:52:01.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/06/1706/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1706/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1 \u0026\u0026 git checkout -b change-1706 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-05-29 08:37:33.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-05-29 08:57:10.000000000","tz":180},"subject":"socket: assert buffer length before reading prepended sockaddr family","message":"socket: assert buffer length before reading prepended sockaddr family\n\nread_sockaddr_from_packet() inspected sa-\u003esa_family before any check\non buf-\u003elen, so a short delivery from the dco-win driver would have\nproduced a garbage peer address from uninitialized buffer memory.\nThe driver always prepends a full sockaddr and validates the family\nbefore writing, so reaching any of the size/family checks would mean\nsomething is severely wrong on the driver side - assert the three\npreconditions instead of M_FATAL\u0027ing on them.\n\nGitHub: https://github.com/OpenVPN/openvpn-private-issues/issues/105\n\nChange-Id: I2ce954aa5b74002be5e38d53783435736625bb2f\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"71b271d9a168b7c43f3b78bdc4768edadfa25e86":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-06-05 18:08:20.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/06/1706/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1706/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2 \u0026\u0026 git checkout -b change-1706 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1706/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2026-06-05 14:18:02.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-06-05 18:03:47.000000000","tz":120},"subject":"socket: assert buffer length before reading prepended sockaddr family","message":"socket: assert buffer length before reading prepended sockaddr family\n\nread_sockaddr_from_packet() inspected sa-\u003esa_family before any check\non buf-\u003elen, so a short delivery from the dco-win driver would have\nproduced a garbage peer address from uninitialized buffer memory.\nThe driver always prepends a full sockaddr and validates the family\nbefore writing, so reaching any of the size/family checks would mean\nsomething is severely wrong on the driver side - assert the three\npreconditions instead of M_FATAL\u0027ing on them.\n\nGitHub: https://github.com/OpenVPN/openvpn-private-issues/issues/105\n\nChange-Id: I2ce954aa5b74002be5e38d53783435736625bb2f\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1706\nMessage-Id: \u003c20260605141808.14028-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37065.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}