)]}'
{"id":"openvpn~1707","triplet_id":"openvpn~master~Iff8b336126a5dff9871213664b1e8585fb70d21e","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-07 17:01:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iff8b336126a5dff9871213664b1e8585fb70d21e","subject":"Ensure pushed tun-mtu is no lower than TUN_MTU_MIN","status":"MERGED","created":"2026-06-03 13:42:40.000000000","updated":"2026-06-07 17:01:08.000000000","submitted":"2026-06-07 17:01:08.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1707","meta_rev_id":"de09642160b68f53de39d88962ae1400d25ce147","_number":1707,"virtual_id_number":1707,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-03 13:42:41.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-03 14:06:38.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"}],"messages":[{"id":"820984336468d1623d8634e9083c682e21634083","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-03 13:42:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a256205e31d6b1f5672927247c5284c8a744fc4","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2026-06-03 14:06:38.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"de09642160b68f53de39d88962ae1400d25ce147","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-06-07 17:01:08.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aca8546df6b04afee275b78f92f5564f5590f76a","revisions":{"282b65e1563fd55637872dda9c18cb9a5bbfe6ac":{"kind":"REWORK","_number":1,"created":"2026-06-03 13:42:40.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/07/1707/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/07/1707/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1 \u0026\u0026 git checkout -b change-1707 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b8afc6c685f4e451fd0fa5aa37f18147520dfc1","subject":"openvpnserv: always use W variant of RpcStringFree()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-27 12:44:44.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-05-27 13:27:51.000000000","tz":120},"subject":"Ensure pushed tun-mtu is no lower than TUN_MTU_MIN","message":"Ensure pushed tun-mtu is no lower than TUN_MTU_MIN\n\nThe normal path ensure that the minimum tun mtu is set to at least\nTUN_MTU_MIN. However, the pushed options path does not have this\nrestriction.\n\nCheck that the tun-mtu is within the limits of min/max mtu\nin options.c. This ensure that the check is also correctly done\non the pushed variant.\n\nAlso add an extra check to keep the allowed payload for icmp6 packets\nto be at least 64 bytes in the the block-ipv6 code path\n(ipv6_send_icmp_unreachable) as extra layer of defence.\n\nPushing a low mtu like 1 and also block-ipv6 could trigger an\nassertion in the ipv6_send_icmp_unreachable code path.\n\nReported-By: Haiyang Huang \u003chuanghaiyang83@gmail.com\u003e\nChange-Id: Iff8b336126a5dff9871213664b1e8585fb70d21e\n"},"branch":"refs/heads/master"},"aca8546df6b04afee275b78f92f5564f5590f76a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2026-06-07 17:01:08.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/07/1707/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/07/1707/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2 \u0026\u0026 git checkout -b change-1707 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/07/1707/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d66de4e0a461c8cc5fff5a00ec14b41dd27fc365","subject":"dco_linux: allow passing KEEPALIVE_TIMEOUT without KEEPALIVE_INTERVAL"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-06-05 18:09:25.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-06-07 16:50:32.000000000","tz":120},"subject":"Ensure pushed tun-mtu is no lower than TUN_MTU_MIN","message":"Ensure pushed tun-mtu is no lower than TUN_MTU_MIN\n\nThe normal path ensure that the minimum tun mtu is set to at least\nTUN_MTU_MIN. However, the pushed options path does not have this\nrestriction.\n\nCheck that the tun-mtu is within the limits of min/max mtu\nin options.c. This ensure that the check is also correctly done\non the pushed variant.\n\nAlso add an extra check to keep the allowed payload for icmp6 packets\nto be at least 64 bytes in the the block-ipv6 code path\n(ipv6_send_icmp_unreachable) as extra layer of defence.\n\nPushing a low mtu like 1 and also block-ipv6 could trigger an\nassertion in the ipv6_send_icmp_unreachable code path.\n\nReported-By: Haiyang Huang \u003chuanghaiyang83@gmail.com\u003e\nChange-Id: Iff8b336126a5dff9871213664b1e8585fb70d21e\nSigned-off-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1707\nMessage-Id: \u003c20260605180931.3547-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37069.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}