)]}'
{"id":"openvpn~1714","triplet_id":"openvpn~master~I52609b71deb8810a3fea639494b5fa13d9e5a493","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-20 14:31:27.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I52609b71deb8810a3fea639494b5fa13d9e5a493","subject":"Whitelist configs in autostart_config_dir","status":"NEW","created":"2026-06-20 14:31:27.000000000","updated":"2026-06-20 14:31:27.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"793d0ffa08aaeea4337beb8012498e23112f1d05","_number":1714,"virtual_id_number":1714,"owner":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-20 14:31:27.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-20 14:31:27.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"b87f842d0cabbe8e6e0f8ae41525942a6f57a096","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2026-06-20 14:31:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e34dc4e6dfe7657b690f015d88c570214f9f9dd6","revisions":{"e34dc4e6dfe7657b690f015d88c570214f9f9dd6":{"kind":"REWORK","_number":1,"created":"2026-06-20 14:31:27.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/14/1714/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1714/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1 \u0026\u0026 git checkout -b change-1714 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1714/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e4236ded8ce8e7e191a5091d55c286c0071f341","subject":"options: Move \u003c\u003d 0 check for keepalive settings earlier"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-06-20 13:23:30.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2026-06-20 14:31:13.000000000","tz":-240},"subject":"Whitelist configs in autostart_config_dir","message":"Whitelist configs in autostart_config_dir\n\nWe currently whitelist these configs by checking that the user is\nNT Service\\\u003covpn_service_user\u003e, which defaults to OpenVPNService.\nIn some setups one may need to change this service user to, say,\nNT Authority\\Local Service, in which case the validation fails.\n\nMake it easier to change the service user by whitelisting all\nconfigs in autostart_config_dir.\n\nSee also: Github OpenVPN/openvpn#1056\n\nChange-Id: I52609b71deb8810a3fea639494b5fa13d9e5a493\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}
