)]}'
{"id":"openvpn~1720","triplet_id":"openvpn~master~I6a032465e66b49ab0ce8b1a84ead8d9acef918de","project":"openvpn","branch":"master","topic":"multipeer","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-28 14:57:30.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-06-25 14:27:35.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I6a032465e66b49ab0ce8b1a84ead8d9acef918de","subject":"Extract handle_connection_attempt from multi_get_create_instance_udp","status":"MERGED","created":"2026-06-22 13:23:08.000000000","updated":"2026-06-28 14:57:30.000000000","submitted":"2026-06-28 14:57:30.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1720-multipeer","meta_rev_id":"f84eba4611ebbb2b52dac72a122471836964a127","_number":1720,"virtual_id_number":1720,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-22 13:23:17.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-22 15:45:47.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"aad0633525f51e962f4781d35f9cad4497c88183","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-22 13:23:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8151500051c020297aa5ccd70010f3ecd4b4363f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-22 15:31:08.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"f9584084e4d06c12c1549e338f3f2076031cc005","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-22 15:45:47.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e3a32960e72bfb5e59cb90c281559f9750f33630","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-25 13:08:10.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"bbed830647620da3ac59c2784ffaef903369fdb4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-06-25 13:37:02.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"3df5318595f278b1f7156aa846de4f0646e7812c","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-06-25 14:27:35.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f84eba4611ebbb2b52dac72a122471836964a127","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-06-28 14:57:30.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1572ee902f1d1ad75c1ad621ddcdc8bc80a5d522","revisions":{"d7a3ff2584547526eed3c49b6ffa9d71e3e1d885":{"kind":"REWORK","_number":1,"created":"2026-06-22 13:23:08.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/20/1720/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1720/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1 \u0026\u0026 git checkout -b change-1720 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"77d7cb922ef91d8ae21aef93c4d544d8671f6c1e","subject":"Support p2p NCP negotiation in p2mp mode"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-21 12:20:24.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-06-22 13:14:54.000000000","tz":120},"subject":"Extract handle_connection_attempt from multi_get_create_instance_udp","message":"Extract handle_connection_attempt from multi_get_create_instance_udp\n\nThe multi_get_create_instance_udp is quite large. This factors out the\none branch that handles and creates new connection attempts.\n\nChange-Id: I6a032465e66b49ab0ce8b1a84ead8d9acef918de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b6d62f43e76d30a195744dd5a129389b3c23327f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-22 15:31:08.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/20/1720/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1720/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2 \u0026\u0026 git checkout -b change-1720 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0541eaa980ef834b0c33d23aa466d7582ea877b","subject":"Support p2p NCP negotiation in p2mp mode"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-21 12:20:24.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-06-22 15:30:51.000000000","tz":120},"subject":"Extract handle_connection_attempt from multi_get_create_instance_udp","message":"Extract handle_connection_attempt from multi_get_create_instance_udp\n\nThe multi_get_create_instance_udp is quite large. This factors out the\none branch that handles and creates new connection attempts.\n\nChange-Id: I6a032465e66b49ab0ce8b1a84ead8d9acef918de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"078c63a08ef283601bd9d8b4a7171b47b6ca89a5":{"kind":"REWORK","_number":3,"created":"2026-06-25 13:37:02.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/20/1720/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1720/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3 \u0026\u0026 git checkout -b change-1720 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f3cb575b1f97e1a49f67cf2d4249da9f723d910f","subject":"Replace custom hash_func with siphash"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-21 12:20:24.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-06-25 13:08:26.000000000","tz":120},"subject":"Extract handle_connection_attempt from multi_get_create_instance_udp","message":"Extract handle_connection_attempt from multi_get_create_instance_udp\n\nThe multi_get_create_instance_udp is quite large. This factors out the\none branch that handles and creates new connection attempts.\n\nChange-Id: I6a032465e66b49ab0ce8b1a84ead8d9acef918de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"1572ee902f1d1ad75c1ad621ddcdc8bc80a5d522":{"kind":"REWORK","_number":4,"created":"2026-06-28 14:57:30.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/20/1720/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1720/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4 \u0026\u0026 git checkout -b change-1720 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/1720/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712f3d61488a47e80577112489e9e9f98a32aac6","subject":"Make get_random return int64 instead of long"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-06-28 13:04:55.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-06-28 13:11:35.000000000","tz":120},"subject":"Extract handle_connection_attempt from multi_get_create_instance_udp","message":"Extract handle_connection_attempt from multi_get_create_instance_udp\n\nThe multi_get_create_instance_udp is quite large. This factors out the\none branch that handles and creates new connection attempts.\n\nChange-Id: I6a032465e66b49ab0ce8b1a84ead8d9acef918de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1720\nMessage-Id: \u003c20260628130500.26086-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37336.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}