)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"032d79713d97267b9a76046d7fe0ec53781e564e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"complications when we want to use both server and client SSL"},{"line_number":12,"context_line":"objects and does not seem to have any advantages."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We later explicitly tell initialise the SSL objects to be a server or"},{"line_number":15,"context_line":"client object in key_state_ssl_init via SSL_set_accept_state or"},{"line_number":16,"context_line":"SSL_set_connect_state. If this is mismatched we end up getting an"},{"line_number":17,"context_line":"error from OpenSSL (\"called a function you should not call\") that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"73b69bd1_a4561a58","line":14,"updated":"2026-07-06 14:25:47.000000000","message":"\"tell initialise\" ?","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d7a5ec13246dd1e2fc46ad652d51ca9d4a5aebc9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"complications when we want to use both server and client SSL"},{"line_number":12,"context_line":"objects and does not seem to have any advantages."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We later explicitly tell initialise the SSL objects to be a server or"},{"line_number":15,"context_line":"client object in key_state_ssl_init via SSL_set_accept_state or"},{"line_number":16,"context_line":"SSL_set_connect_state. If this is mismatched we end up getting an"},{"line_number":17,"context_line":"error from OpenSSL (\"called a function you should not call\") that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e1b4623a_476b04f4","line":14,"in_reply_to":"73b69bd1_a4561a58","updated":"2026-07-23 12:01:42.000000000","message":"Done","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"032d79713d97267b9a76046d7fe0ec53781e564e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"accept/connect or have the ssl_undefined_function that triggers the"},{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mBed TLS code basically does give the SSL contet any personlity"},{"line_number":27,"context_line":"of client or server until we the same area where the OpenSSL code"},{"line_number":28,"context_line":"calls the set accept/connect state call."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"17573b5b_dd6a8176","line":26,"updated":"2026-07-06 14:25:47.000000000","message":"\"mbed TLS\"? \"context\" \"personality\"","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d7a5ec13246dd1e2fc46ad652d51ca9d4a5aebc9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"accept/connect or have the ssl_undefined_function that triggers the"},{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mBed TLS code basically does give the SSL contet any personlity"},{"line_number":27,"context_line":"of client or server until we the same area where the OpenSSL code"},{"line_number":28,"context_line":"calls the set accept/connect state call."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0749af9e_fe6b6537","line":26,"in_reply_to":"17573b5b_dd6a8176","updated":"2026-07-23 12:01:42.000000000","message":"Done","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"032d79713d97267b9a76046d7fe0ec53781e564e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mBed TLS code basically does give the SSL contet any personlity"},{"line_number":27,"context_line":"of client or server until we the same area where the OpenSSL code"},{"line_number":28,"context_line":"calls the set accept/connect state call."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6ca78742_a2889b59","line":27,"updated":"2026-07-06 14:25:47.000000000","message":"\"until we are in the same area\"","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d7a5ec13246dd1e2fc46ad652d51ca9d4a5aebc9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mBed TLS code basically does give the SSL contet any personlity"},{"line_number":27,"context_line":"of client or server until we the same area where the OpenSSL code"},{"line_number":28,"context_line":"calls the set accept/connect state call."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"aa8cc2c9_f6500e61","line":27,"in_reply_to":"6ca78742_a2889b59","updated":"2026-07-23 12:01:42.000000000","message":"Done","commit_id":"9e251ce7c48f9a749e46bb4051ceaf79b41dc1b8"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"876d80ab318f8fb5d5c2d18b39d622f4dd641e47","unresolved":true,"context_lines":[{"line_number":23,"context_line":"accept/connect or have the ssl_undefined_function that triggers the"},{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mbed TLS code basically does give the SSL context any personality"},{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"49dcfa3f_f4ff953b","line":26,"updated":"2026-07-23 12:14:35.000000000","message":"\"doesn\u0027t\" ?","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d94069718e8c8a3885b24da545054d67dbd5d136","unresolved":false,"context_lines":[{"line_number":23,"context_line":"accept/connect or have the ssl_undefined_function that triggers the"},{"line_number":24,"context_line":"\"called a function you should not call\"."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mbed TLS code basically does give the SSL context any personality"},{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3e003769_758190ff","line":26,"in_reply_to":"49dcfa3f_f4ff953b","updated":"2026-08-07 13:49:37.000000000","message":"Done","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"876d80ab318f8fb5d5c2d18b39d622f4dd641e47","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mbed TLS code basically does give the SSL context any personality"},{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"35799328_5aaabb29","line":28,"updated":"2026-07-23 12:14:35.000000000","message":"\"SSL_set_connect_state\"","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d94069718e8c8a3885b24da545054d67dbd5d136","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Our mbed TLS code basically does give the SSL context any personality"},{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0997e078_7e579fd7","line":28,"in_reply_to":"35799328_5aaabb29","updated":"2026-08-07 13:49:37.000000000","message":"Done","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"876d80ab318f8fb5d5c2d18b39d622f4dd641e47","unresolved":true,"context_lines":[{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"44f47685_ddabdc9f","line":30,"updated":"2026-07-23 12:14:35.000000000","message":"\"the mbedTLS backend\" maybe?","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d94069718e8c8a3885b24da545054d67dbd5d136","unresolved":false,"context_lines":[{"line_number":27,"context_line":"of client or server until we are in the same area in which the OpenSSL"},{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e65d33a7_d62837fb","line":30,"in_reply_to":"44f47685_ddabdc9f","updated":"2026-08-07 13:49:37.000000000","message":"Done","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"876d80ab318f8fb5d5c2d18b39d622f4dd641e47","unresolved":true,"context_lines":[{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"},{"line_number":34,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2268e2bc_41f41786","line":31,"updated":"2026-07-23 12:14:35.000000000","message":"\"in that path as the OpenSSL code path\" -\u003e \"in key_state_ssl_init, same as OpenSSL\"","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"d94069718e8c8a3885b24da545054d67dbd5d136","unresolved":false,"context_lines":[{"line_number":28,"context_line":"code calls SSL_set_accept_state/SSL_set_connect_sate."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This also modifies the mbedTLS to use the decision to pick client"},{"line_number":31,"context_line":"and server in that path as the OpenSSL code path."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: Iaf1f3475e4f27a920c028cd73b1a2497953583d0"},{"line_number":34,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bb73947d_7fe0c48e","line":31,"in_reply_to":"2268e2bc_41f41786","updated":"2026-08-07 13:49:37.000000000","message":"Done","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"876d80ab318f8fb5d5c2d18b39d622f4dd641e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe5c9dc5_0d0d536e","updated":"2026-07-23 12:14:35.000000000","message":"Code looks good, commit message could use some work","commit_id":"6ad6d340bf9bd7ae183521fc973ecb115f124f03"}]}