)]}'
{"id":"openvpn~1733","triplet_id":"openvpn~master~I6595695ab6401047d498d530f8739686880bea3a","project":"openvpn","branch":"master","attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2026-07-01 11:30:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-01 11:30:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}},"hashtags":[],"change_id":"I6595695ab6401047d498d530f8739686880bea3a","subject":"mingw: avoid C99 \"hh\" scanf length modifier","status":"NEW","created":"2026-06-26 19:00:11.000000000","updated":"2026-07-01 11:30:47.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"d0cd678794178aa1b6e3fc155d90f334d327d63c","_number":1733,"virtual_id_number":1733,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-26 19:00:12.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-26 19:00:12.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"6516fc8ab6ce54c946c408c1ab0200a394f95713","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-06-26 19:00:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32f09957c4fd70a1da3f86880fb7589a99680f06","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2026-06-26 19:03:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d0cd678794178aa1b6e3fc155d90f334d327d63c","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-01 11:30:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"522eaaef80c1394de08ecf773b6595d0b17a84b3","revisions":{"598ef6d9a287492e03ddfa9f6507d99443fa6265":{"kind":"REWORK","_number":1,"created":"2026-06-26 19:00:11.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/33/1733/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1733/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git checkout -b change-1733 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1281d264a259bf8e95695bbb831737a4778d4afa","subject":"Multisocket: use event engine rwflags for UDP I/O"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:40:19.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:58:11.000000000","tz":120},"subject":"mingw: avoid C99 \"hh\" scanf length modifier","message":"mingw: avoid C99 \"hh\" scanf length modifier\n\nread_key_file() and parse_hexstring() parse hex bytes with sscanf()\nusing the C99 \"hh\" length modifier, storing directly into an octet.\n\nThis is not portable to the legacy MSVCRT runtime that Ubuntu\nresolute\u0027s (26.04) mingw toolchain links against.\n\nScan into an unsigned int and cast to the octet instead. The field width\ncaps the value at 0xFF, so the narrowing cast cannot lose data.\n\nChange-Id: I6595695ab6401047d498d530f8739686880bea3a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"522eaaef80c1394de08ecf773b6595d0b17a84b3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-26 19:03:30.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/33/1733/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1733/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git checkout -b change-1733 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712f3d61488a47e80577112489e9e9f98a32aac6","subject":"Make get_random return int64 instead of long"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:40:19.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 19:03:13.000000000","tz":120},"subject":"mingw: avoid C99 \"hh\" scanf length modifier","message":"mingw: avoid C99 \"hh\" scanf length modifier\n\nread_key_file() and parse_hexstring() parse hex bytes with sscanf()\nusing the C99 \"hh\" length modifier, storing directly into an octet.\n\nThis is not portable to the legacy MSVCRT runtime that Ubuntu\nresolute\u0027s (26.04) mingw toolchain links against.\n\nScan into an unsigned int and cast to the octet instead. The field width\ncaps the value at 0xFF, so the narrowing cast cannot lose data.\n\nChange-Id: I6595695ab6401047d498d530f8739686880bea3a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":true,"status":"PASS","passing_atoms":["checks~ChecksSubmitRule"],"failing_atoms":[]}}]}
