)]}'
{"id":"openvpn~1733","triplet_id":"openvpn~master~I6595695ab6401047d498d530f8739686880bea3a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2026-07-23 20:43:49.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-07-23 20:43:49.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I6595695ab6401047d498d530f8739686880bea3a","subject":"mingw: avoid C99 \"hh\" scanf length modifier","status":"MERGED","created":"2026-06-26 19:00:11.000000000","updated":"2026-07-23 20:43:49.000000000","submitted":"2026-07-23 20:43:49.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1733","meta_rev_id":"22b6a3eafa1241f08e633056676fc9dd9c98fb7a","_number":1733,"virtual_id_number":1733,"owner":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-26 19:00:12.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-26 19:00:12.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-07-03 11:53:04.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"6516fc8ab6ce54c946c408c1ab0200a394f95713","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-06-26 19:00:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32f09957c4fd70a1da3f86880fb7589a99680f06","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-06-26 19:03:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d0cd678794178aa1b6e3fc155d90f334d327d63c","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-07-01 11:30:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"92e74a94dc30056ce3b352ddc180d6efb16d3cb2","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2026-07-02 22:09:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ea99ce7faad4d6654d370f1d0e53b219ec175ba3","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-03 11:53:04.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b2b85c9358639f55a3150d48836748adac34ec3d","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-07-08 15:30:02.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"22b6a3eafa1241f08e633056676fc9dd9c98fb7a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-07-23 20:43:49.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"035a88f97b1ffdc88497faeaa0aeb8a72e1eaf4f","revisions":{"598ef6d9a287492e03ddfa9f6507d99443fa6265":{"kind":"REWORK","_number":1,"created":"2026-06-26 19:00:11.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/33/1733/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1733/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git checkout -b change-1733 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1281d264a259bf8e95695bbb831737a4778d4afa","subject":"Multisocket: use event engine rwflags for UDP I/O"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:40:19.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:58:11.000000000","tz":120},"subject":"mingw: avoid C99 \"hh\" scanf length modifier","message":"mingw: avoid C99 \"hh\" scanf length modifier\n\nread_key_file() and parse_hexstring() parse hex bytes with sscanf()\nusing the C99 \"hh\" length modifier, storing directly into an octet.\n\nThis is not portable to the legacy MSVCRT runtime that Ubuntu\nresolute\u0027s (26.04) mingw toolchain links against.\n\nScan into an unsigned int and cast to the octet instead. The field width\ncaps the value at 0xFF, so the narrowing cast cannot lose data.\n\nChange-Id: I6595695ab6401047d498d530f8739686880bea3a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"522eaaef80c1394de08ecf773b6595d0b17a84b3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-26 19:03:30.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/33/1733/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1733/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git checkout -b change-1733 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712f3d61488a47e80577112489e9e9f98a32aac6","subject":"Make get_random return int64 instead of long"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 18:40:19.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-06-26 19:03:13.000000000","tz":120},"subject":"mingw: avoid C99 \"hh\" scanf length modifier","message":"mingw: avoid C99 \"hh\" scanf length modifier\n\nread_key_file() and parse_hexstring() parse hex bytes with sscanf()\nusing the C99 \"hh\" length modifier, storing directly into an octet.\n\nThis is not portable to the legacy MSVCRT runtime that Ubuntu\nresolute\u0027s (26.04) mingw toolchain links against.\n\nScan into an unsigned int and cast to the octet instead. The field width\ncaps the value at 0xFF, so the narrowing cast cannot lose data.\n\nChange-Id: I6595695ab6401047d498d530f8739686880bea3a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"035a88f97b1ffdc88497faeaa0aeb8a72e1eaf4f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-07-23 20:43:49.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/33/1733/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/1733/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3 \u0026\u0026 git checkout -b change-1733 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/33/1733/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d9e9ec2d289e9a3c44144d4972ffe8e1fbe55978","subject":"options: limit ping and keepalive values to one day"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2026-07-08 18:56:53.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-07-23 18:25:33.000000000","tz":120},"subject":"mingw: avoid C99 \"hh\" scanf length modifier","message":"mingw: avoid C99 \"hh\" scanf length modifier\n\nread_key_file() and parse_hexstring() parse hex bytes with sscanf()\nusing the C99 \"hh\" length modifier, storing directly into an octet.\n\nThis is not portable to the legacy MSVCRT runtime that Ubuntu\nresolute\u0027s (26.04) mingw toolchain links against.\n\nScan into an unsigned int and cast to the octet instead. The field width\ncaps the value at 0xFF, so the narrowing cast cannot lose data.\n\nChange-Id: I6595695ab6401047d498d530f8739686880bea3a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1733\nMessage-Id: \u003c20260708185659.10219-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg37544.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
