)]}'
{"id":"openvpn~1734","triplet_id":"openvpn~master~I72302403bddee4b0b0ee2441ae9e246f48d0bc81","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-27 07:28:34.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I72302403bddee4b0b0ee2441ae9e246f48d0bc81","subject":"Support pre-existing Linux DCO interfaces","status":"NEW","created":"2026-06-27 07:28:34.000000000","updated":"2026-06-27 07:28:34.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"98e776d24f867b99a8669cb831998119ee1d265f","_number":1734,"virtual_id_number":1734,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-27 07:28:34.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-27 07:28:34.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"53d053b673be2fbcbcb5905d633a2602f3fc66ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-06-27 07:28:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2902b94906e9b21e9288d9e43b24a3c6b5775e17","revisions":{"2902b94906e9b21e9288d9e43b24a3c6b5775e17":{"kind":"REWORK","_number":1,"created":"2026-06-27 07:28:34.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/34/1734/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/34/1734/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git checkout -b change-1734 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712f3d61488a47e80577112489e9e9f98a32aac6","subject":"Make get_random return int64 instead of long"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-26 15:45:44.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-27 07:28:29.000000000","tz":120},"subject":"Support pre-existing Linux DCO interfaces","message":"Support pre-existing Linux DCO interfaces\n\nWhen creating an ovpn interface returns -EEXIST, still retrieve the\nifindex and return the error to the generic DCO open path. This lets the\ncaller mark the interface as pre-existing and avoid deleting it on\nclose.\n\nBefore accepting the existing interface, query its rtnetlink link info\nand verify that it is an ovpn device with the expected mode. The ovpn\nmode is fixed at interface creation time, so attaching to an interface\ncreated for the other mode cannot work.\n\nHonor the pre-existing state on close by skipping net_iface_del() for\npersistent interfaces.\n\nGithub: closes OpenVPN/openvpn#1064\nChange-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}