)]}'
{"id":"openvpn~1734","triplet_id":"openvpn~master~I72302403bddee4b0b0ee2441ae9e246f48d0bc81","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000041":{"account":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2026-09-03 20:15:26.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-06-27 07:28:34.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-09-04 09:53:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":[],"change_id":"I72302403bddee4b0b0ee2441ae9e246f48d0bc81","subject":"Support pre-existing Linux DCO interfaces","status":"NEW","created":"2026-06-27 07:28:34.000000000","updated":"2026-10-13 10:04:56.000000000","submit_type":"CHERRY_PICK","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ac00eda8a4b0ef6315c1fe507d09205cc0e63f5d","_number":1734,"virtual_id_number":1734,"owner":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"all":[{"value":2,"date":"2026-10-13 10:04:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-27 07:28:34.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-06-27 07:28:34.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-09-03 14:00:11.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"},{"updated":"2026-09-03 20:15:26.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"53d053b673be2fbcbcb5905d633a2602f3fc66ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-06-27 07:28:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d73bd8cfd1d94bdfa9c9698e32b6add40e26d90","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 14:00:11.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2776685b6a6c9333b2cd27b5d895cc2fd7087cdc","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 14:10:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4ae7aa839ab5874130701b4bde6e0b45c8a54894","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-03 15:07:59.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"01132e978d17979775fc83eafb3b6e87aa57209d","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 15:42:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"24a3b8308990992cf41dd4a41f8855f4bc5844aa","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-03 15:48:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fc4ff1e7147d0d8ddb3d3ac17521de63b2b286c6","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-03 20:15:26.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"b9e083efb2ca0302f5b8806cfa6521fcc25a12cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-09-04 09:37:25.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a75c948e1bbfa2be7408271f44896c3d228929bf","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-09-04 09:53:21.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ac00eda8a4b0ef6315c1fe507d09205cc0e63f5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2026-10-13 10:04:56.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f1edccb06fdbcdcd234a09283f196af9ed8965a2","revisions":{"2902b94906e9b21e9288d9e43b24a3c6b5775e17":{"kind":"REWORK","_number":1,"created":"2026-06-27 07:28:34.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/34/1734/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/34/1734/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git checkout -b change-1734 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"712f3d61488a47e80577112489e9e9f98a32aac6","subject":"Make get_random return int64 instead of long"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-26 15:45:44.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-27 07:28:29.000000000","tz":120},"subject":"Support pre-existing Linux DCO interfaces","message":"Support pre-existing Linux DCO interfaces\n\nWhen creating an ovpn interface returns -EEXIST, still retrieve the\nifindex and return the error to the generic DCO open path. This lets the\ncaller mark the interface as pre-existing and avoid deleting it on\nclose.\n\nBefore accepting the existing interface, query its rtnetlink link info\nand verify that it is an ovpn device with the expected mode. The ovpn\nmode is fixed at interface creation time, so attaching to an interface\ncreated for the other mode cannot work.\n\nHonor the pre-existing state on close by skipping net_iface_del() for\npersistent interfaces.\n\nGithub: closes OpenVPN/openvpn#1064\nChange-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"5c8c4bf4b9c7a4ab34c99e6b899c0d939dc6e479":{"kind":"REWORK","_number":2,"created":"2026-09-04 09:37:25.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/34/1734/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/34/1734/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2 \u0026\u0026 git checkout -b change-1734 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d988ef4508e63b28c8e3efcb9f62eb8c836907fe","subject":"Ignore acks for packets that cannot be outstanding"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-26 15:45:44.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-09-04 09:08:59.000000000","tz":120},"subject":"Support pre-existing Linux DCO interfaces","message":"Support pre-existing Linux DCO interfaces\n\nWhen creating an ovpn interface returns -EEXIST, still retrieve the\nifindex and return the error to the generic DCO open path. This lets the\ncaller mark the interface as pre-existing and avoid deleting it on\nclose.\n\nBefore accepting the existing interface, query its rtnetlink link info\nand verify that it is an ovpn device with the expected mode. The ovpn\nmode is fixed at interface creation time, so attaching to an interface\ncreated for the other mode cannot work.\n\nHonor the pre-existing state on close by skipping net_iface_del() for\npersistent interfaces.\n\nGithub: closes OpenVPN/openvpn#1064\nChange-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"f1edccb06fdbcdcd234a09283f196af9ed8965a2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-10-13 10:04:56.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/34/1734/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/34/1734/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3 \u0026\u0026 git checkout -b change-1734 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/34/1734/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15a1465f981bb3f1950056a8f82b91dfe5f3fdbc","subject":"Make CRL reload EOF detection independent of stale error queue entries"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-06-26 15:45:44.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2026-10-13 10:04:44.000000000","tz":120},"subject":"Support pre-existing Linux DCO interfaces","message":"Support pre-existing Linux DCO interfaces\n\nWhen creating an ovpn interface returns -EEXIST, still retrieve the\nifindex and return the error to the generic DCO open path. This lets the\ncaller mark the interface as pre-existing and avoid deleting it on\nclose.\n\nBefore accepting the existing interface, query its rtnetlink link info\nand verify that it is an ovpn device with the expected mode. The ovpn\nmode is fixed at interface creation time, so attaching to an interface\ncreated for the other mode cannot work.\n\nHonor the pre-existing state on close by skipping net_iface_del() for\npersistent interfaces.\n\nGithub: closes OpenVPN/openvpn#1064\nChange-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}